Page MenuHomePhabricator
Feed All Stories

Aug 20 2019

epriestley requested review of D20722: Fix flag typo in "Managing Caches" documentation.
Aug 20 2019, 7:31 PM
epriestley edited the content of Changelog.
Aug 20 2019, 4:05 PM
epriestley committed rPf74f953c7d26: (stable) Promote 2019 Week 33 (authored by epriestley).
(stable) Promote 2019 Week 33
Aug 20 2019, 4:04 PM
epriestley created an object: 2019 Week 33 (Mid August).
Aug 20 2019, 4:04 PM
epriestley triaged T13383: Provide a "drydock.resource.search" API method as Normal priority.
Aug 20 2019, 3:52 PM · Conduit, Drydock
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 20 2019, 3:50 PM · Harbormaster
epriestley added a comment to T13382: Update various user account CLI tools.

(You can automate at least some administrative actions at an "omnipotent" power level with bin/conduit call --method user.edit nowadays, too, although accountadmin operated with interactive prompts so it's unlikely anyone automated on top of it.)

Aug 20 2019, 2:11 PM · People
epriestley triaged T13382: Update various user account CLI tools as Normal priority.
Aug 20 2019, 2:08 PM · People

Aug 17 2019

epriestley requested review of D20721: Update Phortune subscriptions for modern infrastructure.
Aug 17 2019, 2:52 AM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20721: Update Phortune subscriptions for modern infrastructure.
Aug 17 2019, 2:51 AM · Phortune, Phacility

Aug 16 2019

epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

Stuff to fix with subscriptions:

Aug 16 2019, 10:51 PM · Phortune, Phacility
epriestley requested review of D20720: When a page throws an exception and response construction throws another exception, throw an aggregate exception.
Aug 16 2019, 10:21 PM
epriestley requested review of D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:57 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a revision to T13367: Phortune "enterprise" update errata: D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

if this is really an issue we could likely throw a rate limit on the action

Aug 16 2019, 5:44 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

This is sort-of-quasi-intentional

Aug 16 2019, 5:42 PM · Phortune, Phacility
epriestley added inline comments to D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:30 PM
epriestley updated the diff for D20718: Update PhortunePaymentMethod for modern policy interfaces.

This is actually slightly tricky.

Aug 16 2019, 5:29 PM
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.

A related issue is that when object A returns object B as an extended policy check and the user fails the extended policy check, the "PolicyException" dialog is misleading. It reads like this:

Aug 16 2019, 5:27 PM · Policy
epriestley requested review of D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:10 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:08 PM · Phortune, Phacility
epriestley triaged T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading as Wishlist priority.
Aug 16 2019, 5:04 PM · Policy
epriestley requested review of D20717: Update Phortune payment account interfaces to handle merchant vs customer views.
Aug 16 2019, 4:39 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20717: Update Phortune payment account interfaces to handle merchant vs customer views.
Aug 16 2019, 4:38 PM · Phortune, Phacility
epriestley requested review of D20716: In Phortune, use actual merchant authority (not authority grants) to control account visibility.
Aug 16 2019, 3:19 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20716: In Phortune, use actual merchant authority (not authority grants) to control account visibility.
Aug 16 2019, 3:18 PM · Phortune, Phacility

Aug 15 2019

epriestley requested review of D20715: In Phortune, write relationships between payment accounts and merchants they interact with.
Aug 15 2019, 11:17 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20715: In Phortune, write relationships between payment accounts and merchants they interact with.
Aug 15 2019, 11:16 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 11:00 PM · Phortune, Phacility
epriestley triaged T13380: `git push` fatals when CWD does not exist as Low priority.
Aug 15 2019, 8:02 PM · Arcanist
epriestley closed T13379: Query panels executing bucketed queries with limits have unclear behavior as Wontfix.

Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.

Aug 15 2019, 7:47 PM · Dashboards
epriestley added a comment to T13379: Query panels executing bucketed queries with limits have unclear behavior.

The bucket limit is currently implemented like this:

Aug 15 2019, 7:43 PM · Dashboards
epriestley committed rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret… (authored by epriestley).
Namespace all column references in ProjectQuery to fix ambiguity with Ferret…
Aug 15 2019, 7:22 PM
epriestley closed T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Resolved by committing rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret….
Aug 15 2019, 7:22 PM · Projects
epriestley closed D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:22 PM
epriestley triaged T13379: Query panels executing bucketed queries with limits have unclear behavior as Low priority.
Aug 15 2019, 7:21 PM · Dashboards
epriestley requested review of D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:03 PM
epriestley added a revision to T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging: D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:02 PM · Projects
epriestley triaged T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Low priority.
Aug 15 2019, 7:00 PM · Projects
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

It would also be nice to figure out Phortune permissions better here since this is a good opportunity to vet everything.

Aug 15 2019, 6:49 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 5:54 PM · Phortune, Phacility
avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides
epriestley triaged T13377: Write about "how to solve problems with program behavior" as Wishlist priority.
Aug 15 2019, 4:54 PM · Guides
epriestley triaged T13376: Write about "add more logging / monitoring / tests" as Wishlist priority.
Aug 15 2019, 4:42 PM · Guides

Aug 13 2019

jcox awarded Changelog a Love token.
Aug 13 2019, 4:30 PM

Aug 12 2019

epriestley requested review of D20713: Add scaffolding for ad-hoc email addresses associated with Phortune accounts.
Aug 12 2019, 10:59 PM
epriestley added a revision to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: D20713: Add scaffolding for ad-hoc email addresses associated with Phortune accounts.
Aug 12 2019, 10:58 PM · Phortune, Phacility
epriestley committed rP82cf97ad65a9: When many commits are discovered at once, import them at lower priority (authored by epriestley).
When many commits are discovered at once, import them at lower priority
Aug 12 2019, 7:59 PM
epriestley closed D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:59 PM
epriestley committed rP006cb659cbf1: Make the success message from "bin/config" more clear (authored by epriestley).
Make the success message from "bin/config" more clear
Aug 12 2019, 7:50 PM
epriestley closed D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 7:50 PM
epriestley committed rPc092492a53e0: Fix missing display cell in daemon summary table (authored by epriestley).
Fix missing display cell in daemon summary table
Aug 12 2019, 7:47 PM
epriestley closed D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 7:46 PM
epriestley closed T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Resolved by committing rPc092492a53e0: Fix missing display cell in daemon summary table.
Aug 12 2019, 7:46 PM · Daemons
epriestley requested review of D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:11 PM
epriestley added a revision to T13369: When a large number of commits are pushed to a repository, import them at lower priority: D20712: When many commits are discovered at once, import them at lower priority.
Aug 12 2019, 7:09 PM · Daemons, Diffusion
epriestley requested review of D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 6:23 PM
epriestley added a revision to T13373: Clarify some messaging in `bin/config`: D20711: Make the success message from "bin/config" more clear.
Aug 12 2019, 6:22 PM · Setup, Config
epriestley requested review of D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 6:14 PM
epriestley added a revision to T13374: Daemons summary table is missing a cell in the "Temporary Failures" row: D20710: Fix missing display cell in daemon summary table.
Aug 12 2019, 6:12 PM · Daemons
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

See PHI1378, which is interested in "at least N", for N = 2.

Aug 12 2019, 5:42 PM · Restricted Project, Restricted Project, Differential
epriestley closed T13371: When instances change up/down status, start or stop their daemons as Resolved.

There was one issue with this: bin/host stop --instance X (which is rarely used, and has no prior automated callers) used --force, which stops all daemons on the host. The recent changes to the --force flag in D20601 also had an indirect impact here. I fixed this and redeployed the repo tier.

Aug 12 2019, 3:19 PM · Phacility
epriestley triaged T13375: Treat "'to'" address failures as permanent in Mailgun adapter as Low priority.
Aug 12 2019, 3:14 PM · Mail

Aug 11 2019

epriestley triaged T13374: Daemons summary table is missing a cell in the "Temporary Failures" row as Low priority.
Aug 11 2019, 8:24 PM · Daemons
epriestley edited the content of Changelog.
Aug 11 2019, 4:50 PM
epriestley committed rP26f9ba4684a8: (stable) Promote 2019 Week 32 (authored by epriestley).
(stable) Promote 2019 Week 32
Aug 11 2019, 4:49 PM
epriestley created an object: 2019 Week 32 (Early August).
Aug 11 2019, 4:48 PM
epriestley updated the task description for T13371: When instances change up/down status, start or stop their daemons.
Aug 11 2019, 4:40 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:38 PM · Phacility
epriestley added a revision to T13371: When instances change up/down status, start or stop their daemons: Unknown Object (Differential Revision).
Aug 11 2019, 4:35 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:19 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Aug 11 2019, 4:10 PM · Ops, Restricted Project, Phacility
epriestley closed T13372: Permanently remove references to "phd.bots" in "core/" as Resolved by committing Restricted Diffusion Commit.
Aug 11 2019, 3:57 PM · Phacility
epriestley added a revision to T13372: Permanently remove references to "phd.bots" in "core/": Unknown Object (Differential Revision).
Aug 11 2019, 3:55 PM · Phacility
epriestley triaged T13373: Clarify some messaging in `bin/config` as Low priority.
Aug 11 2019, 3:45 PM · Setup, Config
epriestley triaged T13372: Permanently remove references to "phd.bots" in "core/" as Low priority.
Aug 11 2019, 3:40 PM · Phacility
epriestley triaged T13371: When instances change up/down status, start or stop their daemons as Normal priority.
Aug 11 2019, 3:39 PM · Phacility

Aug 9 2019

avivey awarded T13369: When a large number of commits are pushed to a repository, import them at lower priority a Piece of Eight token.
Aug 9 2019, 6:46 PM · Daemons, Diffusion
epriestley committed rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage (authored by epriestley).
When the feed query on project profile pages overheats, contain the damage
Aug 9 2019, 4:02 AM
epriestley closed D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 9 2019, 4:01 AM

Aug 8 2019

epriestley committed rP9bd74dfa6c07: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login (authored by epriestley).
Autofocus the "App Code" input on the TOTP prompt during MFA gates after login
Aug 8 2019, 7:54 PM
epriestley closed D20703: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login.
Aug 8 2019, 7:54 PM
epriestley created P2122 synthace.js.
Aug 8 2019, 7:05 PM
epriestley requested review of D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 8 2019, 5:39 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20704: When the feed query on project profile pages overheats, contain the damage.
Aug 8 2019, 5:37 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

See downstream https://phabricator.wikimedia.org/T230001 for a similar issue on project pages.

Aug 8 2019, 5:31 PM · Feed
epriestley requested review of D20703: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login.
Aug 8 2019, 5:29 PM
epriestley committed rP46d9065bf148: Drop test for awardable badges on "Badges" tab of user profiles to avoid… (authored by epriestley).
Drop test for awardable badges on "Badges" tab of user profiles to avoid…
Aug 8 2019, 5:19 PM
epriestley closed T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Resolved by committing rP46d9065bf148: Drop test for awardable badges on "Badges" tab of user profiles to avoid….
Aug 8 2019, 5:19 PM · Badges
epriestley closed D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:19 PM
epriestley committed rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated (authored by epriestley).
Fix a warning in BoardLayoutEngine when no objects are being updated
Aug 8 2019, 5:18 PM
epriestley closed D20701: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 8 2019, 5:18 PM
epriestley closed T13368: Correct several issues with "Move to Project..." on Workboards as Resolved by committing rP937edcdc580c: Fix a warning in BoardLayoutEngine when no objects are being updated.
Aug 8 2019, 5:18 PM · Workboards
epriestley requested review of D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:17 PM
epriestley added a revision to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges: D20702: Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating.
Aug 8 2019, 5:16 PM · Badges
epriestley added a comment to T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges.

The repro case is something like:

Aug 8 2019, 5:14 PM · Badges
epriestley triaged T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges as Low priority.
Aug 8 2019, 5:11 PM · Badges
jmeador added a comment to D20221: Improve performance of "arc diff" updates for changes with large diff text.

Oh, good catch. Yeah, that would be an improvement.

use cases seem very weak.

Aug 8 2019, 4:19 PM
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 8 2019, 2:27 PM · Harbormaster