Page MenuHomePhabricator

Make Phortune payment methods transaction-oriented and always support "Add Payment Method"

Authored by epriestley on Aug 16 2019, 9:56 PM.



Depends on D20718. Ref T13366. Ref T13367.

  • Phortune payment methods currently do not use transactions; update them.
  • Give them a proper view page with a transaction log.
  • Add an "Add Payment Method" button which always works.
  • Show which subscriptions a payment method is associated with.
  • Get rid of the "Active" status indicator since we now treat "disabled" as "removed", to align with user expectation/intent.
  • Swap out of some of the super weird div-form-button UI into the new "big, clickable" UI for choice dialogs among a small number of options on a single dimension.
Test Plan
  • As a mechant-authority and account-authority, created payment methods from carts, subscriptions, and accounts. Edited and viewed payment methods.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 16 2019, 9:56 PM
Owners added a subscriber: Restricted Owners Package.Aug 16 2019, 9:56 PM
epriestley requested review of this revision.Aug 16 2019, 9:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 4:04 AM
This revision was automatically updated to reflect the committed changes.