Page MenuHomePhabricator

Phortune "enterprise" update errata
Open, LowPublic

Description

  • Invoices should have a formal void state which merchants can put them into.
  • The "Account Managers" screen should support removal of managers (other than yourself, at least).
  • "Account > Orders" doesn't show invoices.
  • "Account > Overview" is fairly redundant with "Account > Orders".
  • "Account > Payment Methods" should highlight payment methods which will expire soon.
  • When you have unpaid invoices, "Orders" should get a navigation menu alert count.
  • When you have expiring payment methods, "Payment Methods" should get a navigation menu alert count.
  • "Account > Subscriptions" should display autopay status and highlight accounts with autopay expiring soon.
  • "Account > Subscriptions" should show a navigation menu alert count when you have subscriptions with autopay expiring soon.
  • The "Invoice" and "Purchase" columns of the order table aren't clear for instances. "Purchase" probably should not be linked, and "Invoice" should identify the instance. The cart itself could reference the actual instance link.
  • I think "Cart" is a good object, but the UI should be more explicit about providing context about cart state, e.g. "Order", "Invoice", "Receipt".
  • (Phacility specific) If you are a manager but not a member, instances don't show for you.
  • (Phacility specific) Free instances should still have a "billing" tab, since there's no reasonable way to get to your billing account to add instance managers.

Done

  • The "Merchant" profile screen is now somewhat inconsistent with the "Account" profile screen, and uses different icons for "Subscriptions" and "Orders".
  • "Edit Autopay" is MFA-gated on the read side. Preferable would be to MFA-gate this with one-shot when saving. But this should also switch to transactions.

Add Payment Method: This is touched on elsewhere, but it's currently very difficult to add a payment method. This is sort-of-quasi-intentional to make it difficult to validate payment methods, and sort-of-quasi-intentional because some payment processors may not involve real payment methods (I think the Paypal flow was checkout-only?) ,but I assume Stripe (and other processors) do appropriate sets of checks here for managing fraud, and if this is really an issue we could likely throw a rate limit on the action. You can already do it anyway (and we don't see abuse today), it's just a little tricky to find.

Event Timeline

epriestley triaged this task as Low priority.Aug 2 2019, 6:49 PM
epriestley created this task.
epriestley updated the task description. (Show Details)Aug 2 2019, 6:52 PM
epriestley updated the task description. (Show Details)Aug 15 2019, 5:54 PM
epriestley updated the task description. (Show Details)Aug 15 2019, 11:00 PM

This is sort-of-quasi-intentional

Another issue here is that payment methods are bound to a particular merchant -- but the generic interface can just prompt the user, and we know which merchant we're dealing with if we're coming from the context of a subscription.

if this is really an issue we could likely throw a rate limit on the action

This is already rate-limited since D20158.

We're also using inconsistent icons for "Order/Invoice/Receipt/Cart" in different interfaces. I'm going to standardize on this lovely purse, I think:

The "Merchant" profile screen is now somewhat inconsistent with the "Account" profile screen, and uses different icons for "Subscriptions" and "Orders".

This got fixed by D20733.

epriestley updated the task description. (Show Details)Aug 23 2019, 4:19 AM
epriestley updated the task description. (Show Details)Aug 23 2019, 2:58 PM
epriestley updated the task description. (Show Details)Aug 29 2019, 3:19 AM
epriestley updated the task description. (Show Details)Sep 2 2019, 1:04 PM