Page MenuHomePhabricator

When a page throws an exception and response construction throws another exception, throw an aggregate exception
ClosedPublic

Authored by epriestley on Aug 16 2019, 10:20 PM.
Tags
None
Referenced Files
F18444560: D20720.diff
Sun, Aug 31, 7:43 PM
F18107585: D20720.id49402.diff
Mon, Aug 11, 1:43 AM
F18100659: D20720.diff
Sat, Aug 9, 11:59 AM
F17924333: D20720.id.diff
Jul 30 2025, 9:43 AM
F17916139: D20720.diff
Jul 29 2025, 9:41 PM
F17732126: D20720.id.diff
Jul 20 2025, 3:54 AM
Unknown Object (File)
Jul 1 2025, 6:57 PM
Unknown Object (File)
Jun 20 2025, 8:26 AM
Subscribers
None

Details

Summary

Depends on D20719. Currently, if a page throws an exception (like a policy exception) and rendering that exception into a response (like a policy dialog) throws another exception (for example, while constructing breadcrumbs), we only show the orginal exception.

This is usually the more useful exception, but sometimes we actually care about the other exception.

Instead of guessing which one is more likely to be useful, throw them both as an "AggregateException" and let the high-level handler flatten it for display.

Test Plan

Screen Shot 2019-08-16 at 3.18.18 PM.png (1×1 px, 413 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable