Page MenuHomePhabricator

When a page throws an exception and response construction throws another exception, throw an aggregate exception
ClosedPublic

Authored by epriestley on Aug 16 2019, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 8:58 PM
Unknown Object (File)
Fri, Dec 6, 11:11 AM
Unknown Object (File)
Tue, Dec 3, 5:15 AM
Unknown Object (File)
Sun, Dec 1, 10:17 PM
Unknown Object (File)
Fri, Nov 29, 6:42 PM
Unknown Object (File)
Thu, Nov 28, 9:26 AM
Unknown Object (File)
Wed, Nov 27, 1:03 AM
Unknown Object (File)
Nov 23 2024, 3:32 AM
Subscribers
None

Details

Summary

Depends on D20719. Currently, if a page throws an exception (like a policy exception) and rendering that exception into a response (like a policy dialog) throws another exception (for example, while constructing breadcrumbs), we only show the orginal exception.

This is usually the more useful exception, but sometimes we actually care about the other exception.

Instead of guessing which one is more likely to be useful, throw them both as an "AggregateException" and let the high-level handler flatten it for display.

Test Plan

Screen Shot 2019-08-16 at 3.18.18 PM.png (1×1 px, 413 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable