Page MenuHomePhabricator

Update PhortunePaymentMethod for modern policy interfaces
ClosedPublic

Authored by epriestley on Aug 16 2019, 5:08 PM.

Details

Summary

Depends on D20717. Ref T13366. Make PhortunePaymentMethod use an extended policy interface for consistency with modern approaches. Since Accounts have hard-coded policy behavior (and can't have object policies like "Subscribers") this should have no actual impact on program behavior.

This leaves one weird piece in the policy dialog UIs, see T13381.

Test Plan

Viewed and edited payment methods as a merchant and account member. Merchants can only view, not edit.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 16 2019, 5:08 PM
epriestley requested review of this revision.Aug 16 2019, 5:10 PM
epriestley updated this revision to Diff 49400.Aug 16 2019, 5:29 PM

This is actually slightly tricky.

Since payment methods are bound to a particular merchant, we only want to let merchants view payment methods associated with their own merchant account.

Tweak the implementation to align around this.

epriestley added inline comments.Aug 16 2019, 5:30 PM
src/applications/policy/codex/PhabricatorPolicyCodex.php
47–55

(I couldn't find any callers for this anywhere.)

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Aug 23, 4:03 AM
This revision was automatically updated to reflect the committed changes.