Page MenuHomePhabricator
Differential D20721

Update Phortune subscriptions for modern infrastructure
ClosedPublic
Actions

Authored by epriestley on Aug 17 2019, 2:51 AM.

Details

Reviewers
None
Maniphest Tasks
T13366: Update Phortune to work better with "enterprise" billing/accounts departments
Commits
rPa542024b6334: Update Phortune subscriptions for modern infrastructure
Summary

Depends on D20720. Ref T13366.

  • Use modern policies and policy interfaces.
  • Use new merchant authority cache.
  • Add (some) transactions.
  • Move MFA from pre-upgrade-gate to post-one-shot-check.
  • Simplify the autopay workflow.
  • Use the "reloading arrows" icon for subscriptions more consistently.
Test Plan

As a merchant-authority and account-authority, viewed, edited, and changed autopay for subscriptions.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 17 2019, 2:51 AM
Owners added a subscriber: Restricted Owners Package.Aug 17 2019, 2:51 AM
epriestley requested review of this revision.Aug 17 2019, 2:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 4:07 AM
Closed by commit rPa542024b6334: Update Phortune subscriptions for modern infrastructure (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPa542024b6334: Update Phortune subscriptions for modern infrastructure.

Revision Contents
Changeset List

PathPackages
AMresources/sql/autopatches/20190816.subscription.01.xaction.sql (19 lines)
Msrc/__phutil_library_map__.php (25 lines)
Msrc/applications/phortune/application/PhabricatorPhortuneApplication.php (16 lines)
Psrc/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php (1 line)
Copied to src/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php
Psrc/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php (7 lines)
Copied from src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php
Vsrc/applications/phortune/controller/account/{PhortuneAccountPaymentMethodController.php ← PhortuneAccountPaymentMethodListController.php} (2 lines)
Vsrc/applications/phortune/controller/account/{PhortuneAccountPaymentMethodListController.php → PhortuneAccountPaymentMethodController.php}
AMsrc/applications/phortune/controller/account/PhortuneAccountSubscriptionAutopayController.php (137 lines)
AMsrc/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php (338 lines)
Msrc/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php (41 lines)
DMsrc/applications/phortune/controller/subscription/PhortuneSubscriptionViewController.php (224 lines)
AMsrc/applications/phortune/editor/PhortuneSubscriptionEditor.php (18 lines)
Msrc/applications/phortune/phid/PhortunePaymentMethodPHIDType.php (6 lines)
Msrc/applications/phortune/phid/PhortuneSubscriptionPHIDType.php (8 lines)
AMsrc/applications/phortune/query/PhortuneSubscriptionTransactionQuery.php (10 lines)
Msrc/applications/phortune/storage/PhortunePaymentMethod.php (1 line)
Msrc/applications/phortune/storage/PhortuneSubscription.php (78 lines)
AMsrc/applications/phortune/storage/PhortuneSubscriptionTransaction.php (18 lines)
AMsrc/applications/phortune/xaction/subscription/PhortuneSubscriptionAutopayTransaction.php (41 lines)
AMsrc/applications/phortune/xaction/subscription/PhortuneSubscriptionTransactionType.php (4 lines)

Diff 49438

View Options

resources/sql/autopatches/20190816.subscription.01.xaction.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

Loading...
View Options

src/applications/phortune/codex/PhortunePaymentMethodPolicyCodex.php

Loading...
View Options

src/applications/phortune/codex/PhortuneSubscriptionPolicyCodex.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountPaymentMethodListController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionAutopayController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionViewController.php

Loading...
View Options

src/applications/phortune/controller/paymentmethod/PhortunePaymentMethodDisableController.php

Loading...
View Options

src/applications/phortune/controller/subscription/PhortuneSubscriptionViewController.php

Loading...
View Options

src/applications/phortune/editor/PhortuneSubscriptionEditor.php

Loading...
View Options

src/applications/phortune/phid/PhortunePaymentMethodPHIDType.php

Loading...
View Options

src/applications/phortune/phid/PhortuneSubscriptionPHIDType.php

Loading...
View Options

src/applications/phortune/query/PhortuneSubscriptionTransactionQuery.php

Loading...
View Options

src/applications/phortune/storage/PhortunePaymentMethod.php

Loading...
View Options

src/applications/phortune/storage/PhortuneSubscription.php

Loading...
View Options

src/applications/phortune/storage/PhortuneSubscriptionTransaction.php

Loading...
View Options

src/applications/phortune/xaction/subscription/PhortuneSubscriptionAutopayTransaction.php

Loading...
View Options

src/applications/phortune/xaction/subscription/PhortuneSubscriptionTransactionType.php

Loading...
Phabricator · Built by Phacility