Differential D20703

Autofocus the "App Code" input on the TOTP prompt during MFA gates after login
ClosedPublic
Actions

Authored by epriestley on Aug 8 2019, 5:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 7:19 PM

	Unknown Object (File)
	Mon, Nov 18, 9:40 AM

	Unknown Object (File)
	Thu, Nov 14, 8:56 PM

	Unknown Object (File)
	Mon, Nov 11, 4:51 AM

	Unknown Object (File)
	Mon, Nov 11, 2:01 AM

	Unknown Object (File)
	Sat, Nov 9, 10:51 PM

	Unknown Object (File)
	Wed, Nov 6, 8:06 AM

	Unknown Object (File)
	Wed, Oct 30, 8:30 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP9bd74dfa6c07: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login

Summary

See downstream https://phabricator.wikimedia.org/T229757. The "autofocus" attribute mostly just works, so add it to this input.

Test Plan

As a user with TOTP enabled, established a new session. Saw browser automatically focus the "App Code" input on the TOTP prompt screen.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 8 2019, 5:28 PM

Harbormaster completed remote builds in B23237: Diff 49372.Aug 8 2019, 5:29 PM

epriestley requested review of this revision.Aug 8 2019, 5:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 7:54 PM

Closed by commit rP9bd74dfa6c07: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9bd74dfa6c07: Autofocus the "App Code" input on the TOTP prompt during MFA gates after login.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

factor/

PhabricatorTOTPAuthFactor.php

1 line

Diff 49374

View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Autofocus the "App Code" input on the TOTP prompt during MFA gates after loginClosedPublicActions