Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints
ClosedPublic
Actions

Authored by epriestley on Aug 15 2019, 7:02 PM.

Details

Reviewers: None
Maniphest Tasks: T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging
Commits: rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret…

Summary

Fixes T13378. If we join Ferret tables and page, we can end up with an ambiguous id column here.

Explicitly refer to "project.x" in all cases that we're interacting with the project table.

Test Plan

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Aug 15 2019, 7:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 7:22 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

project/

query/

48 lines