Page MenuHomePhabricator

Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints
ClosedPublic

Authored by epriestley on Aug 15 2019, 7:02 PM.

Details

Summary

Fixes T13378. If we join Ferret tables and page, we can end up with an ambiguous id column here.

Explicitly refer to "project.x" in all cases that we're interacting with the project table.

Test Plan
  • Changed page size to 3.
  • Issued a Projects query for "~e", matching more than 3 results.
  • Clicked "Next Page".
    • Before: ambiguous id column fatal.
    • After: next page.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 15 2019, 7:02 PM
epriestley requested review of this revision.Aug 15 2019, 7:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 7:22 PM
This revision was automatically updated to reflect the committed changes.