Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating
ClosedPublic
Actions

Authored by epriestley on Aug 8 2019, 5:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13370: Badges tab on profile pages may overheat if user can not edit the first 10 badges
Commits: rP46d9065bf148: Drop test for awardable badges on "Badges" tab of user profiles to avoid…

Summary

Fixes T13370. We currently show an "Award Badge" button conditionally, based on whether the viewer can award any badges or not.

The query to test this may overheat and this pattern isn't consistent with other UI anyway. Stop doing this test.

Test Plan

Created 12 badges.
As a user who could not edit any of the badges, viewed the "Badges" section of a user profile.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
67	Also: stop building this twice. Once is plenty.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:17 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

people/

controller/

25 lines