Page MenuHomePhabricator

Drop test for awardable badges on "Badges" tab of user profiles to avoid overheating
ClosedPublic

Authored by epriestley on Aug 8 2019, 5:16 PM.

Details

Summary

Fixes T13370. We currently show an "Award Badge" button conditionally, based on whether the viewer can award any badges or not.

The query to test this may overheat and this pattern isn't consistent with other UI anyway. Stop doing this test.

Test Plan
  • Created 12 badges.
  • As a user who could not edit any of the badges, viewed the "Badges" section of a user profile.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 8 2019, 5:16 PM
epriestley added inline comments.Aug 8 2019, 5:16 PM
src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
67

Also: stop building this twice. Once is plenty.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2019, 5:17 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.