Page MenuHomePhabricator
Feed Advanced Search

Apr 7 2018

epriestley triaged T13119: Typeahead datasource debugging UI is broken after introduction of proxy datasources as Normal priority.
Apr 7 2018, 1:24 PM · Typeahead
epriestley added a comment to T13117: `patch` just runs any command?.

A related attack is a bare whatever.patch file which writes to .git/config or .hg/hgconfig or whatever.

Apr 7 2018, 12:54 PM · Security
epriestley added a comment to T13118: Code block headers wrap in the dumbest way in Safari.

In Safari we get this marvel:

Apr 7 2018, 2:26 AM · Remarkup
epriestley triaged T13118: Code block headers wrap in the dumbest way in Safari as Normal priority.
Apr 7 2018, 2:25 AM · Remarkup

Apr 6 2018

epriestley created P2088 nuker.php.
Apr 6 2018, 12:03 AM

Apr 5 2018

arend.danielek awarded T550: Build an SSH conduit client a Love token.
Apr 5 2018, 11:07 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley triaged T13117: `patch` just runs any command? as Normal priority.
Apr 5 2018, 6:46 PM · Security
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 6:40 PM · Plans, Files, Differential, Diffusion
epriestley closed T2442: Show images in Diffusion diffs as Resolved.

This will ultimately be covered by T13105.

Apr 5 2018, 5:54 PM · Wikimedia, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T5698: Github-style Remarkup previews on a checked-in resource, as Resolved.
Apr 5 2018, 5:52 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T12824: Redesign Diffusion, as Resolved.
Apr 5 2018, 5:52 PM · Design, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting as Resolved.

Effectively now covered by T13105.

Apr 5 2018, 5:52 PM · Diffusion
epriestley closed T3788: Improve encoding management in Diffusion, a subtask of T4045: Store diffs as binary, not UTF-8, as Resolved.
Apr 5 2018, 5:51 PM · Restricted Project, Support Impact, Differential
epriestley closed T3788: Improve encoding management in Diffusion as Resolved.

See T13105 for browse cases (and perhaps diff cases, eventually).

Apr 5 2018, 5:51 PM · Restricted Project, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • If a file is non-UTF8, we should try the repository's "Encoding" as a default (or maybe just remove this feature).
Apr 5 2018, 5:50 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Junk I'm about to break in Diffusion (but plan to restore):

Apr 5 2018, 5:38 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 4:17 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Apr 5 2018, 2:33 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:34 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 5 2018, 1:29 PM · Plans, Differential

Apr 4 2018

epriestley closed T3965: Better indentation and tab handling in remarkup editor as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 3:45 PM · Remarkup
epriestley closed T8430: Support emoticons as Wontfix.

We now support emoji; we might support stickers at some point. If we did, I'd expect them to use the autocomplete element (which I think is in a relatively good place for emoji), not actually be invoked with :P, ^-^, etc.

Apr 4 2018, 3:44 PM · Restricted Project, Remarkup
epriestley closed T10398: Phabricator UI uses deprecated <tt> tag as Wontfix.

Since there's no known actual problem with this today, I don't plan to fix it.

Apr 4 2018, 2:11 PM · Remarkup, Bug Report
epriestley closed T11126: Allow embedding XKCD panes in Remarkup as Wontfix.

This is well-suited to a third-party extension, particularly after T5055.

Apr 4 2018, 2:09 PM · Restricted Project, User Delight, Remarkup, Feature Request
epriestley closed T10582: Support colspan and rowspan in tables as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:08 PM · Remarkup, Feature Request
epriestley closed T10729: Improve layout tools for side-by-side tables of images in Remarkup documents as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:08 PM · Remarkup, Feature Request
epriestley closed T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables) as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 2:07 PM · Feature Request, Remarkup
epriestley closed T5427: Force a line break in a table cell as Wontfix.

I don't currently plan to support this.

Apr 4 2018, 2:02 PM · Remarkup
epriestley closed T11284: Allow line breaks in list items as Wontfix.

I don't currently plan to support this. You may be able to add a rule to support something like <br /> with a Remarkup extension.

Apr 4 2018, 2:01 PM · Remarkup
epriestley closed T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax as Wontfix.

I don't currently plan to change the remaining edge case behaviors since I'm not sure they ever occur in the wild.

Apr 4 2018, 1:59 PM · Remarkup, Bug Report
epriestley closed T10163: Remarkup Autocomplete Errata as Resolved.

This seems largely resolved.

Apr 4 2018, 1:59 PM · Remarkup, Typeahead
epriestley closed T5393: Add support for <dl> HTML definition lists in Remarkup as Wontfix.

This request seems very niche, so I don't currently plan to pursue this. It may be possible to implement it as an extension.

Apr 4 2018, 1:57 PM · Remarkup
epriestley closed T7966: would like to have list in table with remarkup or html syntax. as Wontfix.

I don't currently plan to pursue this.

Apr 4 2018, 1:57 PM · Remarkup
epriestley closed T4939: Block level items in lists in remarkup as Wontfix.

This is unlikely to ever happen without stronger use cases for nested block-level elements.

Apr 4 2018, 1:55 PM · Remarkup
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 4 2018, 1:51 PM · Plans, Differential
epriestley closed T8612: Improve handling of "large" changesets as Wontfix.

See T13110 for some followups.

Apr 4 2018, 1:47 PM · Restricted Project, Performance, Differential

Apr 3 2018

epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 11:36 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

This script can back-populate revision sizes that haven't been updated since D18832:

Apr 3 2018, 8:08 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

where I plan to explore the [----++ ] element

Apr 3 2018, 7:45 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 7:32 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 6:51 PM · Plans, Differential
epriestley added a revision to T13116: Plans: 2018 Week 14 Bonus Content: Unknown Object (Differential Revision).
Apr 3 2018, 5:50 PM · Plans
epriestley updated the task description for T13116: Plans: 2018 Week 14 Bonus Content.
Apr 3 2018, 5:50 PM · Plans
epriestley updated the task description for T13116: Plans: 2018 Week 14 Bonus Content.
Apr 3 2018, 5:49 PM · Plans
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 5:04 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 5:00 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:42 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

Some states:

Apr 3 2018, 4:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:28 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:47 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • shouldBroadcast() has been removed; getShouldBroadcast() now means the same thing.
Apr 3 2018, 3:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:23 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • getHasBroadcast(), setHasBroadcast(), and PROPERTY_HAS_BROADCAST are now getShouldBroadcast(), etc.
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 2:31 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Restricted Differential Revision.
Apr 3 2018, 1:48 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • Implementing BuildableInterface now requires implementing newBuildableEngine().
  • Implementing BuildableInterface no longer requires implementing getHarbormasterPublishablePHID(). Publishing indirection is now handled by BuildableEngine.
  • PhabricatorTransactions::TYPE_BUILDABLE no longer exists. Instead, applications should implement application-specific modular transactions to report build status information. DiffusionCommitBuildableTransaction may be useful as a template.
Apr 3 2018, 1:47 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 1:05 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 11:46 AM · Plans, Differential

Apr 2 2018

epriestley added a revision to T13116: Plans: 2018 Week 14 Bonus Content: Unknown Object (Differential Revision).
Apr 2 2018, 11:05 PM · Plans
epriestley triaged T13116: Plans: 2018 Week 14 Bonus Content as Normal priority.
Apr 2 2018, 11:00 PM · Plans
epriestley triaged T13115: Handle mail bounces inside Phabricator as Low priority.
Apr 2 2018, 10:53 PM · Mail

Mar 31 2018

epriestley closed T13114: Plans: 2018 Week 13 Bonus Content as Resolved.
Mar 31 2018, 11:38 AM · Plans
epriestley edited the content of Changelog.
Mar 31 2018, 12:51 AM
epriestley created 2018 Week 13 (Very Late March).
Mar 31 2018, 12:50 AM

Mar 30 2018

epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Mar 30 2018, 10:57 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I'd like to analyze data on the $5 tier with an eye to removing it. Anecdotally, this doesn't seem to be doing anything good for us ... It also feels like we have a lot of $5 test instances.

Mar 30 2018, 10:50 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

The UI and allocation logic for shards need tweaking.

Mar 30 2018, 10:26 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster as Resolved by committing Restricted Diffusion Commit.
Mar 30 2018, 10:25 PM · Ops, Phacility
epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Mar 30 2018, 10:22 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a revision to T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster: Unknown Object (Differential Revision).
Mar 30 2018, 10:22 PM · Ops, Phacility
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Mar 30 2018, 9:51 PM · Plans, Differential
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:31 PM · Plans, Diffusion
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:30 PM · Plans, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 6:15 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T3626: Detection of language for some file types isn't good.

When this eventually moves forward, it's probably also appropriate to remove the syntax-highlighter.engine config option. I think this has essentially zero use in the wild and we have better modern patterns to approach the problem (without extreme-niche config options) if there are real-world use cases.

Mar 30 2018, 4:49 PM · Customer Impact, Restricted Project, Differential
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 4:48 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 30 2018, 3:45 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 30 2018, 3:26 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:53 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 12:01 AM · Plans

Mar 29 2018

epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 9:06 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

Oh, and I found the beast to get a portal to Saqawal's Roost and killed Saqawal and got the boots, but the boots and set in general seem kinda bad so they're sitting in one of my six tabs full of unique items that I will never ever sell or do anything with.

Mar 29 2018, 8:19 PM · Phacility
epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

D19269 makes Harbormaster objects destructible. I've made Build destroy BuildMessage (which it doesn't receive, so this never destroys anything) but not BuildCommand (which it does receive), so that when this change is made (and it starts receiving BuildMessage instead of BuildCommand) things will just work. Until then, BuildCommand objects are technically left hanging, but destroying builds is exceptionally rare so I'm just assuming that this will probably be fixed before anyone notices.

Mar 29 2018, 7:59 PM · Harbormaster
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Plans
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Harbormaster
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 6:42 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Restricted Differential Revision.
Mar 29 2018, 6:29 PM · Plans
epriestley closed T12759: Creating an Owners package before creating any repositories shows a blank select when adding paths to the package as Resolved.

I think this is sort of less bad/weird now, at least. You get a tokenizer instead, which is still empty, but you're prompted to "Type a repository name..." and the UI isn't this odd empty select thing anymore.

Mar 29 2018, 6:27 PM · Bug Report
jcox awarded T13114: Plans: 2018 Week 13 Bonus Content a Party Time token.
Mar 29 2018, 5:34 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 5:04 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 4:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 4:52 PM · Plans
epriestley added a comment to T13114: Plans: 2018 Week 13 Bonus Content.

D19266 adds some additional Support Pact adventure mode content. Some other ideas for improving this mode:

Mar 29 2018, 2:48 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 2:39 PM · Plans
epriestley added a revision to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them: Restricted Differential Revision.
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Restricted Differential Revision.
Mar 29 2018, 2:22 PM · Plans