Page MenuHomePhabricator
Feed All Stories

Feb 21 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 21 2018, 3:43 PM · Plans, Harbormaster
epriestley moved T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:46 PM · Haskell.org, Harbormaster, Feature Request
epriestley moved T9365: Harbormaster results are hard to aggregate from v3 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:41 PM · Harbormaster, Restricted Project, Restricted Project
epriestley moved T9516: Copying text from a Harbormaster build log copies the line numbers as well from v3 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:41 PM · Harbormaster, Restricted Project
epriestley moved T11402: Garbage collect and/or compress/archive harbormaster build unit messages from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Harbormaster, Feature Request
epriestley moved T10868: Make a line-linkable view for individual build logs from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Harbormaster, Feature Request
epriestley moved T10635: Loading differential revision slow when lots of unit test messages exist from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:40 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley moved T10179: Support specifying a log parser or some such construct for Harbormaster build logs from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:38 PM · Restricted Project, Harbormaster, Feature Request
epriestley moved T10123: Allow short "result" message for CI builds from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:38 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley moved T9951: Store/display more information for Unit tests from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:37 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley closed T9277: Harbormaster AutoClose as Wontfix.

The build itself can do this over Conduit. Although it's possible we'll support things like this some day, I think this is currently too niche and disconnected from other application behavior to pursue in the upstream.

Feb 21 2018, 2:37 PM · Restricted Project, Maniphest, Harbormaster
epriestley moved T11798: Allow harbormaster build logs to be downloaded via the API from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:35 PM · Harbormaster
epriestley moved T11810: Live log output from harbormaster from Backlog to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:34 PM · Harbormaster, Feature Request
epriestley moved T5822: Implement garbage collection / automatic archiving for Harbormaster logs from v3 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:32 PM · Harbormaster, Restricted Project
epriestley moved T9124: Support uploading build log data via the Harbormaster API from v2 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:32 PM · Restricted Project, Harbormaster
epriestley moved T8656: Parse ANSI-style color strings in build output from v2 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:32 PM · Haskell.org, Restricted Project, Harbormaster
epriestley moved T6139: Allow designation of "summary" build logs which are sorted to the top or otherwise promoted from v2 to Logs / Unit Logs on the Harbormaster board.
Feb 21 2018, 2:32 PM · Restricted Project, Harbormaster
epriestley triaged T13088: Plans: Harbormaster UI usability and interconnectedness as Normal priority.
Feb 21 2018, 2:21 PM · Plans, Harbormaster
epriestley added a comment to T13083: Plans: Portals and Facts.

See PHI385. I think I stabilized the dashboard arrangement issues in D19123, but the arrange workflows are still in somewhat rough shape.

Feb 21 2018, 1:30 AM · Plans, Facts, Dashboards
epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Unknown Object (Differential Revision).
Feb 21 2018, 1:21 AM · Plans, Differential, Harbormaster
epriestley added a revision to T13083: Plans: Portals and Facts: Unknown Object (Differential Revision).
Feb 21 2018, 1:20 AM · Plans, Facts, Dashboards
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Feb 21 2018, 1:13 AM · Quicksand
epriestley added a comment to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.

That is, we mutated the object outside of the Editor, then relied on the Editor to save the mutation.

Feb 21 2018, 1:04 AM · Plans, Differential, Harbormaster

Feb 20 2018

epriestley triaged T13087: Outbound mail should get X-Phabricator-Mail-ID and X-Phabricator-Unique headers as Low priority.
Feb 20 2018, 9:50 PM · Mail

Feb 19 2018

epriestley added a revision to T13083: Plans: Portals and Facts: Unknown Object (Differential Revision).
Feb 19 2018, 7:38 PM · Plans, Facts, Dashboards
kuba-orlik added a comment to T13086: Configured task priority keywords with uppercase letters can fail to map properly as defaults.

Another option could be to only allow lowercase letters in the json specification, with some kind of warning message

Feb 19 2018, 6:48 PM · Maniphest
epriestley added a revision to T13083: Plans: Portals and Facts: Unknown Object (Differential Revision).
Feb 19 2018, 5:43 PM · Plans, Facts, Dashboards
epriestley triaged T13086: Configured task priority keywords with uppercase letters can fail to map properly as defaults as Low priority.
Feb 19 2018, 5:38 PM · Maniphest
epriestley updated the task description for T13083: Plans: Portals and Facts.
Feb 19 2018, 3:15 PM · Plans, Facts, Dashboards
0 edited the content of Community Resources.
Feb 19 2018, 12:34 AM

Feb 18 2018

epriestley added a revision to T13083: Plans: Portals and Facts: Unknown Object (Differential Revision).
Feb 18 2018, 5:30 PM · Plans, Facts, Dashboards
epriestley added a revision to T13083: Plans: Portals and Facts: Unknown Object (Differential Revision).
Feb 18 2018, 3:31 PM · Plans, Facts, Dashboards
epriestley added a comment to T13083: Plans: Portals and Facts.

One overarching issue here is that facts don't have a clear permissions model. It's bad if anyone can go look up the burndown chart for #critical-security-issues and then correlate that chart against tasks showing up in #weird-things-that-happen-when-you-hold-down-the-letter-a or whatever and get a hint about a security concern. In the general case, charts like "Salary by Employee", "Acuisitions Affecting our Stock Price", etc., are also potentially problematic.

Feb 18 2018, 2:30 PM · Plans, Facts, Dashboards
exp10r3r awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Feb 18 2018, 7:14 AM · Conpherence (v4)

Feb 17 2018

yelirekim awarded T13083: Plans: Portals and Facts a Piece of Eight token.
Feb 17 2018, 4:47 PM · Plans, Facts, Dashboards
epriestley added a comment to T13083: Plans: Portals and Facts.
  • Fact cursors are currently per-object. I think they should likely be per <object, engine> pair so that subsets can be rebuilt more quickly for testing/development and the failure of one engine will not stop all other engines from processing data. On the other hand, fact processing is currently pretty fast and I don't expect to write a ton of engines so I'm not sure how critical this really is. Engines likely don't care how cursors work unless they depend on facts extracted by other engines and need to guarantee they execute later.
  • FactEngine->getFactSpecs() isn't really authoritative -- it takes a fact definition externally. I think this should become the authoritative generator. That is, this piece of code needs to go sooner rather than later:
Feb 17 2018, 3:02 PM · Plans, Facts, Dashboards
epriestley updated the task description for T13083: Plans: Portals and Facts.
Feb 17 2018, 2:27 PM · Plans, Facts, Dashboards
epriestley edited the content of 2018 Week 7 (Mid February).
Feb 17 2018, 12:40 PM
rabahmeradi added a comment to T11495: Drydock doesn't delete working copies.

The company I work for doesn't use Phabricator anymore. If I recall correctly the issue happens when an error occurs when creating the working copy. So DryDock create a copy 'copy-123' for example and then if an error occur (during the creation of the working copy for example can't fetch the repository), the build is stopped and the folder 'copy-123' is not deleted. DryDock will retry after 15s and create another copy 'copy-124'. So you can end up with millions of folders after a couple of hours.

Feb 17 2018, 7:19 AM · Bug Report (Needs Information), Drydock

Feb 16 2018

epriestley edited the content of Changelog.
Feb 16 2018, 10:05 PM
epriestley created 2018 Week 7 (Mid February).
Feb 16 2018, 10:04 PM
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 8:41 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 8:32 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:45 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:37 PM · Plans, Phriction
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

D19111 doesn't fix this in the general case, but should produce the desired behavior for most inputs such that the input is in the form [x](y) and y is the URI of a Wikipedia article.

Feb 16 2018, 7:07 PM · Remarkup, Bug Report
epriestley added a comment to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax.

The intent isn't unambiguous in the general case, consider: Blah blah (see also [x](y)).

Feb 16 2018, 7:06 PM · Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:05 PM · Plans, Phriction
epriestley added a revision to T12343: Link-Parsing fails if URL ends in ) when using "[name](link)" syntax: Unknown Object (Differential Revision).
Feb 16 2018, 7:05 PM · Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 7:01 PM · Plans, Phriction
epriestley merged task T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Remarkup
epriestley merged T5333: Linking to a wiki URL with % encoding in the URL breaks the link into T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Feb 16 2018, 6:28 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Ah thanks!

Feb 16 2018, 6:23 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

The non-bold ones also open in a new tab.

Feb 16 2018, 6:20 PM · Phriction, Remarkup, Bug Report
epriestley added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Oh! Yes. Sort of.

Feb 16 2018, 6:17 PM · Phriction, Remarkup, Bug Report
cspeckmim added a comment to T12344: Relative links to Phriction pages misinterprets URL-encoded characters.

Just curious, but is the bold effect intentional in the "No Encoding Relative" scenario?

Feb 16 2018, 5:57 PM · Phriction, Remarkup, Bug Report
epriestley closed T5941: Show Phriction Pages in Search Typeahead as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:56 PM · Phriction
epriestley closed T12344: Relative links to Phriction pages misinterprets URL-encoded characters as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:55 PM · Phriction, Remarkup, Bug Report
epriestley closed T10969: Incorrect Phriction link in email as Resolved by committing Restricted Diffusion Commit.
Feb 16 2018, 5:55 PM · Phriction, Bug Report
epriestley added a revision to T12241: Make it easier to find objects while in remarkup box: Unknown Object (Differential Revision).
Feb 16 2018, 5:42 PM · Phurl, Remarkup, Feature Request
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 5:42 PM · Plans, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 5:26 PM · Plans, Phriction
epriestley added a revision to T5941: Show Phriction Pages in Search Typeahead: Unknown Object (Differential Revision).
Feb 16 2018, 3:50 PM · Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 3:50 PM · Plans, Phriction
epriestley closed T13085: Test Task for Self Mail + Must Encrypt as Invalid.

This doesn't look like a bug in Phabricator; the reporting user is likely discussing client-side mail filtering rules which, by design, can never work against "Must Encrypt" mail.

Feb 16 2018, 2:59 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 3: Self mail on again.

Feb 16 2018, 2:51 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 2: Self mail off.

Feb 16 2018, 2:51 PM · Must Encrypt Mail
epriestley added a comment to T13085: Test Task for Self Mail + Must Encrypt.

Comment 1: Self mail on.

Feb 16 2018, 2:50 PM · Must Encrypt Mail
epriestley created T13085: Test Task for Self Mail + Must Encrypt.
Feb 16 2018, 2:50 PM · Must Encrypt Mail
mcorteel added a comment to T8824: Allow relative URLs in custom fields of type "link".

It would be perfect if the syntax supported in remarkup links could be used, which means that for @swisspol's example, projects/phabricator_transition/ would translate to https://temp.phacility.com/w/projects/phabricator_transition/.
And it would be even more awesome if the behavior of the displayed link in the "view" page could be the same, which means that in this case, it wouldn't display the link but the name of the Phriction page!

Feb 16 2018, 2:47 PM · Custom Fields
epriestley added a revision to T12344: Relative links to Phriction pages misinterprets URL-encoded characters: Unknown Object (Differential Revision).
Feb 16 2018, 2:44 PM · Phriction, Remarkup, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 2:44 PM · Plans, Phriction
epriestley added a comment to T13084: Phriction page links using URL encoding can be retargeted without editing.

A similar "attack" is to send a link to two destinations based on the viewer:

Feb 16 2018, 2:41 PM · Phriction, Security
epriestley closed T13084: Phriction page links using URL encoding can be retargeted without editing as Wontfix.
Feb 16 2018, 2:23 PM · Phriction, Security
mcorteel awarded T8824: Allow relative URLs in custom fields of type "link" a Like token.
Feb 16 2018, 1:56 PM · Custom Fields
epriestley added a revision to T10969: Incorrect Phriction link in email: Unknown Object (Differential Revision).
Feb 16 2018, 1:18 PM · Phriction, Bug Report
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 1:18 PM · Plans, Phriction
epriestley closed T11163: Speed up wiki documents creation as Wontfix.

We haven't seen other interest in this and the use case feels a little unusual (I suspect 15-20% empty documents is very unusual) so I don't plan to implement it at this time.

Feb 16 2018, 12:48 PM · Phriction, Feature Request
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I'll follow up with more details on what was accessed once we conclude our response.

Feb 16 2018, 2:33 AM · Phacility
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 16 2018, 1:20 AM · Plans, Phriction
epriestley updated the task description for T13077: Plans: Phriction modern "v3" APIs, Drafts.
Feb 16 2018, 12:49 AM · Plans, Phriction
epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Restricted Differential Revision.
Feb 16 2018, 12:22 AM · Plans, Drydock

Feb 15 2018

epriestley added a revision to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Unknown Object (Differential Revision).
Feb 15 2018, 11:39 PM · Plans, Drydock
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 8:56 PM · Plans, Phriction
epriestley added projects to T13083: Plans: Portals and Facts: Dashboards, Facts.
Feb 15 2018, 8:52 PM · Plans, Facts, Dashboards
epriestley triaged T13083: Plans: Portals and Facts as Normal priority.
Feb 15 2018, 8:52 PM · Plans, Facts, Dashboards
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 5:49 PM · Plans, Phriction
epriestley added a comment to T12845: Convert remaining ancient configuration type classes to modern modular type classes.

See PHI372 -- setting user.custom-field-definitions (or, probably, any similar config) to a string will pass validation but then fatal in use.

Feb 15 2018, 5:15 PM · Infrastructure, Config
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 4:56 PM · Quicksand
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 4:31 PM · Plans, Phriction
epriestley added a comment to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags.

No. Mail stamps are not intended to answer "Why am I receiving this mail?" in the general case (which lives in T9412 now, I think).

Feb 15 2018, 4:13 PM · Mail
nemobis added a comment to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags.

Will stamps be applied for all email notifications and reasons for the recipient to receive them, so as to fix T6297: Maniphest email notification doesn't say why I'm receiving it?

Feb 15 2018, 3:38 PM · Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Restricted Differential Revision.
Feb 15 2018, 2:29 PM · Plans, Phriction
epriestley triaged T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title as Low priority.
Feb 15 2018, 2:02 PM · Transactions, Mail
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:50 PM · Plans, Phriction
epriestley added a revision to T6203: Adjust nullability of various questionable columns: Unknown Object (Differential Revision).
Feb 15 2018, 1:50 PM · Infrastructure
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:33 PM · Plans, Phriction
epriestley renamed T13081: Quicksand breaks the back button after a reload, et al from Quicksand breaks the back button after a reload to Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 1:31 PM · Quicksand
epriestley triaged T13081: Quicksand breaks the back button after a reload, et al as Normal priority.
Feb 15 2018, 1:26 PM · Quicksand
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 15 2018, 1:01 PM · Plans, Phriction