Page MenuHomePhabricator
Feed Advanced Search

Jun 15 2017

axelb added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

Okay thanks for your answer. So if i used audit.Query to get (for example) audit statuses etc.. I have to wait that diffusion.commit.search implements all functionnalities?

Jun 15 2017, 12:27 PM · Audit, Diffusion, Conduit, Bug Report
epriestley added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

No.

Jun 15 2017, 12:20 PM · Audit, Diffusion, Conduit, Bug Report
axelb added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

Is it possible to unfreeze audit.query if diffusion.commit.search is not returning enough informations to replace audit.Query?

Jun 15 2017, 12:14 PM · Audit, Diffusion, Conduit, Bug Report
aurelijus added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Thanks! Will check.

Jun 15 2017, 5:27 AM · Maniphest, Conduit, Bug Report

Jun 14 2017

epriestley closed T12846: arc unit uses the config of the current installation when running tests as Resolved.

I think this is worth acting on (by changing MySQL sandboxing or config sandboxing or some combination of things) if:

Jun 14 2017, 10:23 PM · Bug Report
epriestley added a comment to T12846: arc unit uses the config of the current installation when running tests.

Oh, I don't think anyone should ever be running unit tests with actual production credentials. You should assume that arc unit will immediately escape all sandboxing and destroy all the data it can touch, then run BENCHMARK() for an hour and then crash the server. But you should assume arc unit will do this even if it is "supposed" to be Totally Seriously Sandboxed 100% into SQLite.

Jun 14 2017, 10:17 PM · Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

@aurelijus, D18111 is landed now in HEAD if you'd like to test this. Let us know if you have any issues.

Jun 14 2017, 10:10 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12846: arc unit uses the config of the current installation when running tests.

Philosophically I'm happy with that. Just as an exercise though, I came up with:

Jun 14 2017, 10:08 PM · Bug Report
amckinley closed T12124: Counterintuitive priority setting via maniphest.edit conduit call as Resolved by committing Restricted Diffusion Commit.
Jun 14 2017, 9:43 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12846: arc unit uses the config of the current installation when running tests.

I can't really come up with a problem that would prevent, even theoretically -- do you have a specific scenario in mind offhand where some kind of MySQL configuration could mask a test failure locally?

Jun 14 2017, 9:38 PM · Bug Report
amckinley added a comment to T12846: arc unit uses the config of the current installation when running tests.

That makes sense. Probably not much to be done for it (other than potentially doing a config override for maniphest.priorities prior to running ManiphestTaskTestCase).

Jun 14 2017, 8:31 PM · Bug Report
epriestley added a comment to T12846: arc unit uses the config of the current installation when running tests.

This is semi-intended, because we have to pull a lot of config (like mysql.host) from your local install for things to make sense: we can't create test fixtures if we don't know how to connect to the database.

Jun 14 2017, 8:24 PM · Bug Report
amckinley created T12846: arc unit uses the config of the current installation when running tests.
Jun 14 2017, 7:51 PM · Bug Report
amckinley created T12845: Convert remaining ancient configuration type classes to modern modular type classes.
Jun 14 2017, 7:41 PM · Infrastructure, Config
epriestley closed T12844: MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction as Resolved by committing Restricted Diffusion Commit.
Jun 14 2017, 7:27 PM · Daemons, Mail, Restricted Project, Bug Report
epriestley renamed T12844: MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction from MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction to MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction.
Jun 14 2017, 7:19 PM · Daemons, Mail, Restricted Project, Bug Report
epriestley added a revision to T12844: MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction: Restricted Differential Revision.
Jun 14 2017, 7:15 PM · Daemons, Mail, Restricted Project, Bug Report
epriestley added a comment to T12844: MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction.

Oh, this doesn't isolate things because they're on different databases, and thus we establish different connections. The daemon insert does not happen inside a transaction.

Jun 14 2017, 7:10 PM · Daemons, Mail, Restricted Project, Bug Report
epriestley created T12844: MetaMTA worker can win a race against MTAMail despite both being inserted in the same transaction, because they aren't actually inserted in the same transaction.
Jun 14 2017, 6:59 PM · Daemons, Mail, Restricted Project, Bug Report
cspeckmim created T12841: Using `arc patch` on a revision with dependency leaves bookmark on the applied commit.
Jun 14 2017, 2:33 AM · Arcanist, Mercurial, Bug Report

Jun 13 2017

epriestley closed T12839: Can't create one day event as Resolved.

iiam

Jun 13 2017, 9:21 PM · Calendar, Bug Report
Luke081515.2 added a comment to T12839: Can't create one day event.

Should not, but looks like there are. I updated to master now, and it works now.

Jun 13 2017, 9:15 PM · Calendar, Bug Report
epriestley added a comment to T12839: Can't create one day event.

I used the current version, but there should be no meaningful changes to this behavior between your version and HEAD.

Jun 13 2017, 9:10 PM · Calendar, Bug Report
Luke081515.2 added a comment to T12839: Can't create one day event.

That's weird since I exactly did the same with my version from above. Did you used the current or my version? Or should I update and try if I can reproduce it at the master?

Jun 13 2017, 9:09 PM · Calendar, Bug Report
epriestley added a comment to T12839: Can't create one day event.

I can't reproduce this. Here's what I did:

Jun 13 2017, 8:54 PM · Calendar, Bug Report
Luke081515.2 added a comment to T12839: Can't create one day event.

Calendar1.PNG (341×1 px, 21 KB)

Example 1: You can't create an event from day 1 0:00 till day 1 23:59

Jun 13 2017, 8:48 PM · Calendar, Bug Report
Luke081515.2 added a comment to T12821: Herald should allow "only the first time the rule matches" for calendar events as well.

Thanks :)

Jun 13 2017, 8:43 PM · Herald, Bug Report
Luke081515.2 added a comment to T12839: Can't create one day event.

Version infos are:

phabricator
    0d1654446be6de43b2bd12fcc247db0dc1a46464 (Sat, Jun 10) 
arcanist
    c04f141ab0231e593a513356b3832a30f9404627 (Fri, Jun 9) 
phutil
    74a1350416eb2df825c2315d6519bee03f77bee9 (Mon, Jun 5)
Jun 13 2017, 8:42 PM · Calendar, Bug Report
Luke081515.2 created T12839: Can't create one day event.
Jun 13 2017, 8:41 PM · Calendar, Bug Report
chad closed T12836: 12 as Spite.
Jun 13 2017, 5:03 PM · Bug Report
• ianian0915 created T12836: 12.
Jun 13 2017, 4:56 PM · Bug Report
epriestley added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

How did you generate this diff?

Jun 13 2017, 3:43 PM · Arcanist, Bug Report
Pawka updated the task description for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jun 13 2017, 9:21 AM · Arcanist, Bug Report
Pawka created T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jun 13 2017, 9:20 AM · Arcanist, Bug Report
Kwisatz added a comment to T12828: git lfs broken due to missing ttf.relative config key.

Thanks @epriestley, that fixed it indeed!

Jun 13 2017, 6:49 AM · Bug Report

Jun 12 2017

epriestley added a comment to T12828: git lfs broken due to missing ttf.relative config key.

I believe this should now be resolved in HEAD of master. Let us know if it doesn't work for you or if you're still seeing issues after upgrading. Thanks for the report!

Jun 12 2017, 6:25 PM · Bug Report
epriestley closed T12828: git lfs broken due to missing ttf.relative config key as Resolved by committing Restricted Diffusion Commit.
Jun 12 2017, 6:24 PM · Bug Report
epriestley closed T12821: Herald should allow "only the first time the rule matches" for calendar events as well as Resolved by committing Restricted Diffusion Commit.
Jun 12 2017, 6:23 PM · Herald, Bug Report
epriestley added a comment to T12828: git lfs broken due to missing ttf.relative config key.

This is not a configuration problem, and you can't fix it by changing configuration. D18119 should fix it.

Jun 12 2017, 6:21 PM · Bug Report
epriestley added a revision to T12828: git lfs broken due to missing ttf.relative config key: Restricted Differential Revision.
Jun 12 2017, 6:21 PM · Bug Report
epriestley claimed T12828: git lfs broken due to missing ttf.relative config key.
Jun 12 2017, 6:21 PM · Bug Report
alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Beautiful. Sorry for not finding that.

Jun 12 2017, 6:16 PM · Restricted Project, Differential, Bug Report
epriestley merged task T12829: Synchronous accepts for the same project produce a misleading error into T12757: Multiple reviewers can race one another to accept on behalf of packages and get a poor UX.
Jun 12 2017, 6:16 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Presuming resolved by T12757 (May 25).

Jun 12 2017, 6:16 PM · Restricted Project, Differential, Bug Report
alexmv added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Sorry, just pulling that out. 4d2c7e4d3d5d61e34b7e2af3df0e901d89d29433

Jun 12 2017, 6:15 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12829: Synchronous accepts for the same project produce a misleading error.

Version?

Jun 12 2017, 6:15 PM · Restricted Project, Differential, Bug Report
alexmv added a project to T12829: Synchronous accepts for the same project produce a misleading error: Restricted Project.
Jun 12 2017, 6:14 PM · Restricted Project, Differential, Bug Report
alexmv created T12829: Synchronous accepts for the same project produce a misleading error.
Jun 12 2017, 6:14 PM · Restricted Project, Differential, Bug Report
Kwisatz created T12828: git lfs broken due to missing ttf.relative config key.
Jun 12 2017, 6:04 PM · Bug Report
epriestley added a revision to T12821: Herald should allow "only the first time the rule matches" for calendar events as well: Restricted Differential Revision.
Jun 12 2017, 2:46 PM · Herald, Bug Report
epriestley triaged T12827: phd stop --force can’t find any daemons to kill on Solaris as Wishlist priority.

See also T4124 for another Solaris issue.

Jun 12 2017, 12:43 PM · Daemons, Bug Report
mavit created T12827: phd stop --force can’t find any daemons to kill on Solaris.
Jun 12 2017, 11:08 AM · Daemons, Bug Report
ivo created T12826: Previous/Next buttons stop working after editing a single event in a recurring series.
Jun 12 2017, 11:04 AM · Calendar, Bug Report

Jun 10 2017

Luke081515.2 created T12821: Herald should allow "only the first time the rule matches" for calendar events as well.
Jun 10 2017, 5:51 PM · Herald, Bug Report

Jun 9 2017

chad added a comment to T12818: Phriction/Wiki "Move Document" results in "Documents must have content".

(Specifically, if you update this bug should be resolved.)

Jun 9 2017, 11:55 PM · Bug Report
amckinley added a revision to T12124: Counterintuitive priority setting via maniphest.edit conduit call: Restricted Differential Revision.
Jun 9 2017, 10:52 PM · Maniphest, Conduit, Bug Report
chad merged task T12818: Phriction/Wiki "Move Document" results in "Documents must have content" into T12793: Unable to move Phriction documents.
Jun 9 2017, 10:48 PM · Bug Report
chad merged T12818: Phriction/Wiki "Move Document" results in "Documents must have content" into T12793: Unable to move Phriction documents.
Jun 9 2017, 10:48 PM · Customer Impact, Bug Report, Phriction
chad added a comment to T12818: Phriction/Wiki "Move Document" results in "Documents must have content".

Please don't forget to update Phabricator before filing bug reports.

Jun 9 2017, 10:47 PM · Bug Report
daishi created T12818: Phriction/Wiki "Move Document" results in "Documents must have content".
Jun 9 2017, 10:45 PM · Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

With only those fields:

{
  "data": [
    {
      "name": "Open",
      "value": "open",
      "special": "default",
      "closed": false
    },
    {
      "name": "Resolved",
      "value": "resolved",
      "special": "closed",
      "closed": true
    },
    {
      "name": "Wontfix",
      "value": "wontfix",
      "closed": true
    },
    {
      "name": "Invalid",
      "value": "invalid",
      "closed": true
    },
    {
      "name": "Duplicate",
      "value": "duplicate",
      "special": "duplicate",
      "closed": true
    },
    {
      "name": "Spite",
      "value": "spite",
      "closed": true
    }
  ]
}
Jun 9 2017, 7:44 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Maybe just include name, value, closed and special?

Jun 9 2017, 7:39 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Similar example for new maniphest.status.search. I'm happy to drop any of these fields if you think we won't need them (prefixes and suffixes leap to mind).

Jun 9 2017, 7:36 PM · Maniphest, Conduit, Bug Report
epriestley closed T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported as Resolved by committing Restricted Diffusion Commit.
Jun 9 2017, 3:12 PM · Arcanist, Bug Report
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

The behavior of arc land is complex. You can look at the source for the details, or run arc land --trace to see which commands it executes.

Jun 9 2017, 2:11 PM · Arcanist, Bug Report
deadalnix added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

By headless strategy you mean the squash and merge one ?

Jun 9 2017, 2:09 PM · Arcanist, Bug Report
epriestley added a comment to T12814: pholio transaction emails have too much html.

Per @chad's link, PholioMockEditor->buildMailBody() does some improper stuff where it explicitly sets rendering targets and adds raw sections to the mail body.

Jun 9 2017, 2:05 PM · Pholio, Transactions, Bug Report
epriestley claimed T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.
Jun 9 2017, 2:02 PM · Arcanist, Bug Report
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

Prior to October 2015, this flag only had an effect under git. This is why it says "Supports: git".

Jun 9 2017, 2:01 PM · Arcanist, Bug Report
epriestley added a revision to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported: Restricted Differential Revision.
Jun 9 2017, 1:58 PM · Arcanist, Bug Report
epriestley added a comment to T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.

The version of arcanist used is the one packaged in debian.

Jun 9 2017, 1:49 PM · Arcanist, Bug Report
deadalnix created T12815: arc land help mention --update-with-rebase work with git, but running it says it is not supported.
Jun 9 2017, 1:41 PM · Arcanist, Bug Report
chad added a project to T12814: pholio transaction emails have too much html: Pholio.

T12776#225510

Jun 9 2017, 4:08 AM · Pholio, Transactions, Bug Report
chad added a comment to T12814: pholio transaction emails have too much html.

999.99999.9% sure we have this tracked "somewhere"

Jun 9 2017, 4:04 AM · Pholio, Transactions, Bug Report
avivey created T12814: pholio transaction emails have too much html.
Jun 9 2017, 3:59 AM · Pholio, Transactions, Bug Report

Jun 8 2017

epriestley closed T12807: Diffusion's "Grep File Content" doesn't work with UTF characters as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 10:26 PM · Diffusion, Bug Report
epriestley closed T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 10:25 PM · Transactions, Diffusion, Bug Report
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

(We also likely have a similar problem for hg that D18105 won't fix, and can't use the same strategy there since hg grep has no -f flag or equivalent.)

Jun 8 2017, 2:48 PM · Diffusion, Bug Report
epriestley added a comment to T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.

Note that D18104 is not retroactive, so existing feed stories aren't expected to change after upgrading. New feed stories published after picking up the fix should show "alice committed <commit>" as the title again, though.

Jun 8 2017, 1:27 PM · Transactions, Diffusion, Bug Report
epriestley added a revision to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters: Restricted Differential Revision.
Jun 8 2017, 12:56 PM · Diffusion, Bug Report
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See also T7339 and T5554. But the approach we are generally taking there is "wherever possible, use a method where locale configuration is not relevant", which is consistent with using -f -.

Jun 8 2017, 12:49 PM · Diffusion, Bug Report
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

This works properly on my local machine (OSX) so it's some kind of Ubuntu UTF8 CLI thing.

Jun 8 2017, 12:48 PM · Diffusion, Bug Report
epriestley added a revision to T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald: Restricted Differential Revision.
Jun 8 2017, 12:45 PM · Transactions, Diffusion, Bug Report
epriestley renamed T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald from Herald rule message in acticity feed instead of commit message to For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.
Jun 8 2017, 12:02 PM · Transactions, Diffusion, Bug Report
epriestley claimed T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.
Jun 8 2017, 12:01 PM · Transactions, Diffusion, Bug Report
Ben_RMCon added a comment to T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.

Herald rule:

pasted_file (510×939 px, 35 KB)

Jun 8 2017, 11:19 AM · Transactions, Diffusion, Bug Report
Ben_RMCon created T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.
Jun 8 2017, 11:18 AM · Transactions, Diffusion, Bug Report
chad closed T12810: There are processes running that look like Phabricator daemons but have no corresponding PID files as Invalid.

Please read and follow Contributing Bug Reports if you think you've found a bug in Phabricator. Specifically all bug reports require steps that reproduce for the upstream developers. If you have general questions about Phabricator administration, please use Conpherence or Ponder. Thanks!

Jun 8 2017, 5:17 AM · Bug Report
zhoudan_dan created T12810: There are processes running that look like Phabricator daemons but have no corresponding PID files.
Jun 8 2017, 5:09 AM · Bug Report
epriestley closed T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments as Resolved by committing Restricted Diffusion Commit.
Jun 8 2017, 2:10 AM · Bug Report
epriestley added a revision to T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments: Restricted Differential Revision.
Jun 8 2017, 2:06 AM · Bug Report

Jun 7 2017

avivey updated the task description for T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.
Jun 7 2017, 8:08 PM · Diffusion, Bug Report
avivey updated the task description for T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.
Jun 7 2017, 8:08 PM · Diffusion, Bug Report
janitorial created T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.
Jun 7 2017, 7:22 PM · Diffusion, Bug Report
epriestley added a comment to T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments.

This is because of the synthetic comment from Lint near line 108 of DiffusionHistoryController.php, not because of the comment in the screenshot.

Jun 7 2017, 10:21 AM · Bug Report
epriestley added a parent task for T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments: T12733: (2017 Week 20) Inline Comments Errata / Feedback.
Jun 7 2017, 10:20 AM · Bug Report
epriestley renamed T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments from Differential shows unsubmitted comment of other users to In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments.
Jun 7 2017, 10:20 AM · Bug Report
rabahmeradi renamed T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments from differential shows unsubmitted comment of other users to Differential shows unsubmitted comment of other users.
Jun 7 2017, 8:06 AM · Bug Report
rabahmeradi created T12806: In Differential/Diffusion, synthetic inline comments are incorrectly counted as unsubmitted comments.
Jun 7 2017, 8:06 AM · Bug Report

Jun 6 2017

davidgiga1993 created T12802: Schemata error after updating.
Jun 6 2017, 6:30 AM · Bug Report (Needs Information)