Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2016

bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

No worries, we appreciate the quick fixes!

Jun 14 2016, 7:21 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

@bizrad6 Thanks, I think D16118 should fix that once it lands. Sorry about these issues, the actual global stuff happened at the very end of the settings changes and I didn't test it as thoroughly as I should have.

Jun 14 2016, 7:20 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Restricted Differential Revision.
Jun 14 2016, 7:18 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Restricted Differential Revision.
Jun 14 2016, 6:30 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

Bug: The global email preferences are not being respected when Phabricator decides whether or not to send an email.

Jun 14 2016, 6:21 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T11044: Support partitioning application databases across multiple database hosts: Restricted Differential Revision.
Jun 14 2016, 6:15 PM · Clusters, Prioritized
epriestley added a revision to T9789: Make it easier to write custom transaction types: Restricted Differential Revision.
Jun 14 2016, 5:58 PM · Modernization, Transactions
allixsenos added a comment to T11098: Feedback and Errata for Global Settings.

as per T11149, my email format setting defaults do not reflect active instance config

Jun 14 2016, 5:25 PM · Prioritized, Restricted Project, User Preferences
chad merged T11149: user settings and global defaults for email do not reflect site config into T11098: Feedback and Errata for Global Settings.
Jun 14 2016, 5:19 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

Confirmed it fixed the issue we were seeing, thanks for the quick response!

Jun 14 2016, 2:40 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11140: Support at-rest encryption in Files.

My tentative plan is to define keys in local config with some sort of structure like:

Jun 14 2016, 12:50 PM · Prioritized, Files
avivey added a comment to T11140: Support at-rest encryption in Files.

One thing I've seen people do is something like an encrypted ssh key (For SSL certs):

Jun 14 2016, 12:12 AM · Prioritized, Files

Jun 13 2016

epriestley added a revision to T11098: Feedback and Errata for Global Settings: Restricted Differential Revision.
Jun 13 2016, 10:23 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

Cool, pretty sure I've got a repro then -- real fix coming up in a second.

Jun 13 2016, 10:15 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

Yup, that did the trick!

Jun 13 2016, 10:11 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

Ah, I think I've got a repro. Does this "fix" it?

Jun 13 2016, 9:57 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

We are seeing an issue where the global default email preferences are not reflected in the user email preferences.

Jun 13 2016, 9:53 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T9789: Make it easier to write custom transaction types: Restricted Differential Revision.
Jun 13 2016, 9:49 PM · Modernization, Transactions
epriestley moved T11140: Support at-rest encryption in Files from Backlog to Preflight on the Prioritized board.
Jun 13 2016, 7:15 PM · Prioritized, Files
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Catching a couple more funky diffs:

Jun 13 2016, 7:14 PM · Prioritized, Transactions
epriestley created T11140: Support at-rest encryption in Files.
Jun 13 2016, 6:57 PM · Prioritized, Files
epriestley added a revision to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks: Restricted Differential Revision.
Jun 13 2016, 6:27 PM · Prioritized, Wikimedia, Remarkup
epriestley moved T7441: Support OAuth providers in the cluster from The Queue to Paused on the Prioritized board.
Jun 13 2016, 5:48 PM · Auth, Phacility
epriestley added a comment to T7441: Support OAuth providers in the cluster.

I enabled Google for central auth since I think everything we need for it to work already works fine in the cluster, although it's possible some of the invite flow stuff is a little shaky.

Jun 13 2016, 5:39 PM · Auth, Phacility
epriestley closed T10547: Remote SVN repository imports over SSH do not tidy up temporary directories as Resolved.

I believe this is fixed now, but reproduction has always been somewhat elusive so I'm not completely certain. Please let us know if you still see issues after updating. Thanks for the report!

Jun 13 2016, 5:31 PM · Prioritized, Subversion, Bug Report
epriestley added a revision to T10547: Remote SVN repository imports over SSH do not tidy up temporary directories: Restricted Differential Revision.
Jun 13 2016, 4:23 PM · Prioritized, Subversion, Bug Report
epriestley moved T10547: Remote SVN repository imports over SSH do not tidy up temporary directories from Backlog to The Queue on the Prioritized board.
Jun 13 2016, 2:44 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.

I appear to have found a reproduction case for this in the cluster.

Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley claimed T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.
Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley moved T7441: Support OAuth providers in the cluster from Paused to The Queue on the Prioritized board.
Jun 13 2016, 2:21 PM · Auth, Phacility

Jun 12 2016

chad added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

See also T11134

Jun 12 2016, 2:10 AM · Prioritized, Wikimedia, Remarkup

Jun 11 2016

epriestley added a project to T8909: Provide ability to hide all inline or done comments: Prioritized.
Jun 11 2016, 1:33 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD

Jun 10 2016

chad added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

thx!

Jun 10 2016, 4:58 PM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Large diffs like wiki pages should render better in email now:

Jun 10 2016, 4:56 PM · Prioritized, Transactions
epriestley updated the task description for T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Jun 10 2016, 3:57 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 10 2016, 3:30 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 10 2016, 3:13 PM · Prioritized, Transactions
epriestley moved T9789: Make it easier to write custom transaction types from Backlog to The Queue on the Prioritized board.
Jun 10 2016, 1:44 PM · Modernization, Transactions
epriestley added a project to T9789: Make it easier to write custom transaction types: Prioritized.

I spent a couple hours on this last night and a couple hours this morning and I think I have Paste pretty much converted, so things look promising. I'm going to hold this until after the release cut, but expect to put Calendar on top of it and whatever else converts in the future.

Jun 10 2016, 1:44 PM · Modernization, Transactions

Jun 9 2016

epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from The Queue to Paused on the Prioritized board.

D16094 should improve things, let me know if you identify specific problems after deploying that. It's deployed on this server now, although we have fewer similarly-named projects so it's harder to see the effects.

Jun 9 2016, 8:28 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Restricted Differential Revision.
Jun 9 2016, 8:16 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

It's expected that the ordering in "Browse" is alphabetical/raw, and I don't plan to change that.

Jun 9 2016, 7:50 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
20after4 added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

Here's what happens when adding wikidata project tag using the comment form typeahead:

Jun 9 2016, 7:46 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley moved T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier from Backlog to The Queue on the Prioritized board.
Jun 9 2016, 7:29 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from Preflight to The Queue on the Prioritized board.
Jun 9 2016, 7:29 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).
  • We currently use white-space: pre-wrap to handle linebreaks in prose diffs, but at least one client (Airmail) doesn't handle that properly. We could use explicit <br /> to improve behavior.
Jun 9 2016, 7:25 PM · Prioritized, Transactions
epriestley moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Preflight to Paused on the Prioritized board.

I think this should work now. I tested it locally with HTTP and SOCKS proxies via Charles and those both seemed to behave properly.

Jun 9 2016, 7:20 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Restricted Differential Revision.
Jun 9 2016, 6:50 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Restricted Differential Revision.
Jun 9 2016, 6:47 PM · Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Restricted Differential Revision.
Jun 9 2016, 6:45 PM · Prioritized, Restricted Project, Feature Request
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Oh, one more thing:

Jun 9 2016, 4:34 PM · Prioritized, Transactions
epriestley added a comment to T6523: Allow creating/adding images to mocks with a vanilla upload control.

After D16088:

Jun 9 2016, 3:42 PM · Prioritized, Pholio, Wikimedia
epriestley moved T6523: Allow creating/adding images to mocks with a vanilla upload control from Backlog to Paused on the Prioritized board.
Jun 9 2016, 3:41 PM · Prioritized, Pholio, Wikimedia
epriestley added a revision to T6523: Allow creating/adding images to mocks with a vanilla upload control: Restricted Differential Revision.
Jun 9 2016, 3:40 PM · Prioritized, Pholio, Wikimedia
epriestley added a comment to T6523: Allow creating/adding images to mocks with a vanilla upload control.

This should also fix the mobile workflow stragglers from T2644.

Jun 9 2016, 3:11 PM · Prioritized, Pholio, Wikimedia
epriestley merged T2644: Make Pholio work better on mobile into T6523: Allow creating/adding images to mocks with a vanilla upload control.
Jun 9 2016, 3:10 PM · Prioritized, Pholio, Wikimedia
epriestley moved T6523: Allow creating/adding images to mocks with a vanilla upload control from Backlog to v2 on the Pholio board.
Jun 9 2016, 3:09 PM · Prioritized, Pholio, Wikimedia
epriestley added a project to T7924: Unprototype Calendar (v1): Prioritized.
Jun 9 2016, 2:58 PM · Restricted Project, Prioritized, Calendar
epriestley added a project to T10747: Import and export ICS from Calendar: Prioritized.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley claimed T2334: Implement Google Calendar v3 API into Calendar.
Jun 9 2016, 2:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11044: Support partitioning application databases across multiple database hosts.

After a little thought, I'm leaning strongly to putting every schema on every database. I think this makes a lot of the administration, maintenance and implementation easier.

Jun 9 2016, 1:35 PM · Clusters, Prioritized
epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from Backlog to Preflight on the Prioritized board.
Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
epriestley added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

I implemented this, sort of. However, it doesn't work cleanly because transactions are "adjusted" (have old values populated) after they are "expanded" (which generates the @user mention transactions). So when the code runs, it doesn't have access to the old text and can't easily figure out which mentions are new.

Jun 9 2016, 12:56 PM · Prioritized, Wikimedia, Remarkup
jasonrumney added a comment to T10939: Support for OWNERS files.

As an alternative to Luke081515.2's request for an option, I just filed T11118. This would also allow an easy return to the old behaviour of always triggering audits, regardless of who the author is.

Jun 9 2016, 6:04 AM · Prioritized, Restricted Project, Owners

Jun 8 2016

chad added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

O.o

Jun 8 2016, 8:58 PM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

This one feels a bit un-human-like, although it might be tricky to fix:

Jun 8 2016, 8:55 PM · Prioritized, Transactions
epriestley created T11114: Move Differential to EditEngine.
Jun 8 2016, 6:25 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley closed T9411: Tailor Phacility admin NUX funneling a bit, a subtask of T9303: Improve Phacility Onboarding/NUX, as Resolved.
Jun 8 2016, 5:21 PM · Phacility
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

It would also be nice to develop an inline version of this for title changes like this:

Jun 8 2016, 5:19 PM · Prioritized, Transactions
chad merged T11094: Special character extract problem of `phabricator/bin/i18n extract` into T5267: Localize Phabricator.
Jun 8 2016, 4:23 PM · Prioritized, Localization
chad renamed T5267: Localize Phabricator from Use translatewiki.net to localize Phabricator to Localize Phabricator.
Jun 8 2016, 4:22 PM · Prioritized, Localization
chad merged T11109: Strings of Owner and Herald applcaitons cannot translate. into T5267: Localize Phabricator.
Jun 8 2016, 4:22 PM · Prioritized, Localization
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

For completeness, T11107 was also related to this.

Jun 8 2016, 3:15 PM · Prioritized, Restricted Project, User Preferences
jayvdb added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

My device is part of my life based in a real timezone. My OSS development and other intensive online community activity occurs in UTC, to simplify my mental calculations about other people's current time and aiding communication of timestamps and deltas.

Jun 8 2016, 2:25 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

I'm not sure I understand the use case for that. Do you set your client OS to local time, but prefer to use Phabricator in UTC? Offhand, this seems unusual. Do you have any particular reason for doing this (e.g., you live right next to a timezone boundary and change zones multiple times per day)?

Jun 8 2016, 1:56 PM · Prioritized, Restricted Project, User Preferences
jayvdb added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

Could we special case UTC, with a custom message and simpler "no change" process?

Jun 8 2016, 1:46 PM · Prioritized, Restricted Project, User Preferences

Jun 7 2016

epriestley added a revision to T6916: Allow video embed in remarkup: Restricted Differential Revision.
Jun 7 2016, 9:55 PM · Prioritized, Remarkup
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

I'm sure there are still some cases where we don't do a particularly good job, but let me know when you run into them.

Jun 7 2016, 9:51 PM · Prioritized, Transactions
MZMcBride added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Diffs should be less choppy now, here's the improved version of the above change:

Screen Shot 2016-06-07 at 9.01.32 AM.png (508×621 px, 67 KB)

Jun 7 2016, 9:45 PM · Prioritized, Transactions
quiddity added a comment to T6916: Allow video embed in remarkup.

I have no idea if this is MP4 or not:

Jun 7 2016, 9:43 PM · Prioritized, Remarkup
epriestley moved T6916: Allow video embed in remarkup from The Queue to Paused on the Prioritized board.

I think this one works:

Jun 7 2016, 9:24 PM · Prioritized, Remarkup
epriestley added a comment to T6916: Allow video embed in remarkup.

I have no idea if this is MP4 or not:

Jun 7 2016, 9:16 PM · Prioritized, Remarkup
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 8:45 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 8:43 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 7:15 PM · Prioritized, Transactions
epriestley merged T6674: Support video MIME types and distinguish between audio and video OGG files into T6916: Allow video embed in remarkup.
Jun 7 2016, 6:06 PM · Prioritized, Remarkup
epriestley moved T6916: Allow video embed in remarkup from Backlog to The Queue on the Prioritized board.
Jun 7 2016, 6:04 PM · Prioritized, Remarkup
epriestley claimed T6916: Allow video embed in remarkup.
Jun 7 2016, 6:04 PM · Prioritized, Remarkup
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Diffs should be less choppy now, here's the improved version of the above change:

Jun 7 2016, 4:03 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 3:27 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 3:21 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 7 2016, 3:06 PM · Prioritized, Transactions
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Restricted Differential Revision.
Jun 7 2016, 2:00 PM · Prioritized, Restricted Project, User Preferences
avivey added a comment to T11098: Feedback and Errata for Global Settings.

Calls to .edit endpoints fail with cache exception:

Jun 7 2016, 2:18 AM · Prioritized, Restricted Project, User Preferences
epriestley closed T3353: Make Phriction Document changes reviewable as Resolved.

I think this pretty much boiled down to three technical pieces, all now better covered elsewhere by more specific tasks:

Jun 7 2016, 1:00 AM · Restricted Project, Prioritized, Phriction
epriestley closed T3353: Make Phriction Document changes reviewable, a subtask of T7643: Improve prose diffs (was: description changes don't generate usable diffs), as Resolved.
Jun 7 2016, 1:00 AM · Prioritized, Transactions
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

This is pretty rough (particularly, the actual diff part), but wired up everywhere. HTML email includes a link:

Jun 7 2016, 12:46 AM · Prioritized, Transactions
epriestley claimed T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Jun 7 2016, 12:36 AM · Prioritized, Transactions

Jun 6 2016

epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Restricted Differential Revision.
Jun 6 2016, 10:36 PM · Prioritized, Transactions
epriestley moved T7643: Improve prose diffs (was: description changes don't generate usable diffs) from Backlog to The Queue on the Prioritized board.
Jun 6 2016, 10:31 PM · Prioritized, Transactions