Page MenuHomePhabricator
Feed Advanced Search

Apr 3 2016

epriestley moved T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked from Backlog to v0 on the Badges board.
Apr 3 2016, 12:55 PM · Badges (v0)
epriestley added a comment to T10714: Ability to click task number next to maniphest disappeared.

On my mobile device (an iPhone 4S), I think it's slightly faster to tap-wait-tap-copy the URL bar than press-hold-copy a link.

Apr 3 2016, 12:42 AM · Maniphest, Bug Report
epriestley merged task T10713: Changing the remote URI of a repository causes existing Drydock resources to break into T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.
Apr 3 2016, 12:12 AM · Drydock, Bug Report
epriestley merged T10713: Changing the remote URI of a repository causes existing Drydock resources to break into T8153: Improve detection and recovery when resources are mangled outside of Drydock's control.
Apr 3 2016, 12:12 AM · Prioritized, Drydock
epriestley closed T10714: Ability to click task number next to maniphest disappeared as Invalid.

This report doesn't describe a bug.

Apr 3 2016, 12:11 AM · Maniphest, Bug Report

Apr 2 2016

epriestley closed T10709: incoming email handler replies multiple times for a single unrecognized command as Resolved.

This should now be resolved in production.

Apr 2 2016, 6:01 PM · Mail, Bug Report
epriestley added a revision to T10709: incoming email handler replies multiple times for a single unrecognized command: Unknown Object (Differential Revision).
Apr 2 2016, 5:36 PM · Mail, Bug Report
epriestley added a comment to T10709: incoming email handler replies multiple times for a single unrecognized command.

We have an additional safety check which is supposed to prevent this kind of issue: we refuse to process messages with the same "Message-ID" more than once.

Apr 2 2016, 5:25 PM · Mail, Bug Report
epriestley added a comment to T10712: Add support for zuul.

@paladox, we appreciate your enthusiasm but I think you have a very mistaken set of expectations about the kinds of services we provide. See some discussion in Support Resources.

Apr 2 2016, 5:09 PM · Differential, Feature Request
epriestley closed T10712: Add support for zuul as Wontfix.

We don't plan to support this in the upstream. We have a system in a similar role already (Harbormaster) and would prefer to expand it to do more if there is missing functionality.

Apr 2 2016, 4:51 PM · Differential, Feature Request
epriestley added a comment to T10709: incoming email handler replies multiple times for a single unrecognized command.

I think this is happening:

Apr 2 2016, 3:10 PM · Mail, Bug Report
epriestley claimed T10709: incoming email handler replies multiple times for a single unrecognized command.
Apr 2 2016, 3:07 PM · Mail, Bug Report
epriestley closed T10707: arc backout added bonus free "tips" to end of commit message as Resolved by committing Restricted Diffusion Commit.
Apr 2 2016, 2:26 PM · Arcanist, Bug Report
epriestley awarded T10707: arc backout added bonus free "tips" to end of commit message a Pterodactyl token.
Apr 2 2016, 1:32 PM · Arcanist, Bug Report
epriestley added a comment to T10707: arc backout added bonus free "tips" to end of commit message.

Thanks for the report, D15573 should fix this. Sorry about that!

Apr 2 2016, 1:31 PM · Arcanist, Bug Report
epriestley added a revision to T10707: arc backout added bonus free "tips" to end of commit message: Unknown Object (Differential Revision).
Apr 2 2016, 1:29 PM · Arcanist, Bug Report
epriestley renamed T10707: arc backout added bonus free "tips" to end of commit message from arc backout added unwelcome "tips" to end of commit message to arc backout added bonus free "tips" to end of commit message.
Apr 2 2016, 1:26 PM · Arcanist, Bug Report
epriestley updated subscribers of T5813: Countdown should offer sorting by expiration time.
Apr 2 2016, 12:23 PM · Countdown
epriestley merged task T10708: Sort countdowns by expiry time into T5813: Countdown should offer sorting by expiration time.
Apr 2 2016, 12:23 PM · Dashboards, Countdown, Feature Request
epriestley created T10706: Update old badge quality constants in PHUIBadgeExample.
Apr 2 2016, 12:04 AM · Badges (v0)

Apr 1 2016

epriestley edited the content of Changelog.
Apr 1 2016, 11:57 PM
epriestley created 2016 Week 14 (Early April).
Apr 1 2016, 11:57 PM
epriestley added a comment to T10705: You must use withSourcePHIDs() to query edges..

See Support Resources.

Apr 1 2016, 11:40 PM · Bug Report
epriestley added a comment to T8940: Annotate badges with awarder, date.

No, badges themselves don't have an awarder.

Apr 1 2016, 11:33 PM · Badges (v0)
epriestley closed T10705: You must use withSourcePHIDs() to query edges. as Invalid.

I know you guys want reproduction steps

Apr 1 2016, 11:30 PM · Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

jx-tooltip is a free spirit :3

Apr 1 2016, 9:11 PM · PHUI, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

This should now be resolved in HEAD of master. I've deployed the change here, and verified I can interact with the comment in D15565.

Apr 1 2016, 7:58 PM · Differential, Bug Report
epriestley closed T10704: Comments on images in Differential (Right Side) cause JS error as Resolved by committing Restricted Diffusion Commit.
Apr 1 2016, 7:54 PM · Differential, Bug Report
epriestley added a revision to T10704: Comments on images in Differential (Right Side) cause JS error: Unknown Object (Differential Revision).
Apr 1 2016, 7:53 PM · Differential, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

I think a workaround is to swap the particular changeset into unified mode (View Options → View Unified) and then interact with the comment, but the fix seems trivial and straightforward.

Apr 1 2016, 7:51 PM · Differential, Bug Report
epriestley claimed T10704: Comments on images in Differential (Right Side) cause JS error.
Apr 1 2016, 7:48 PM · Differential, Bug Report
epriestley added a comment to T10704: Comments on images in Differential (Right Side) cause JS error.

Thanks, I can reproduce this as well (e.g. D15565).

Apr 1 2016, 7:48 PM · Differential, Bug Report
epriestley removed a reviewer for D15563: This is to test: Blessed Reviewers.
Apr 1 2016, 6:45 PM
epriestley added a comment to T9007: Allow Badges to be ordered by quality.

Too many deck slots, product literally unplayable.

Apr 1 2016, 1:25 PM · Badges (v0)
epriestley renamed T9007: Allow Badges to be ordered by quality from Allow Badges to be ordered by Rarity to Allow Badges to be ordered by quality.
Apr 1 2016, 1:15 PM · Badges (v0)
epriestley added a comment to T9007: Allow Badges to be ordered by quality.

FUN POLICE HERE

Apr 1 2016, 1:15 PM · Badges (v0)
epriestley changed the image for Image Macro "siren".
Apr 1 2016, 1:14 PM
epriestley triaged T10698: Comment previews should display user badges under the author's profile image. as Low priority.

This is fairly messy and probably not worth fixing until the surrounding code is more modernized.

Apr 1 2016, 1:13 PM · Badges
epriestley added a subtask for T10364: Conpherence v4 (UI/UX): T10698: Comment previews should display user badges under the author's profile image..
Apr 1 2016, 1:07 PM · Conpherence (v4)
epriestley added a parent task for T10698: Comment previews should display user badges under the author's profile image.: T10364: Conpherence v4 (UI/UX).
Apr 1 2016, 1:07 PM · Badges
epriestley added a revision to T10698: Comment previews should display user badges under the author's profile image.: Unknown Object (Differential Revision).
Apr 1 2016, 1:06 PM · Badges
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

T7805 was the "use applicationsearch in the dialog" task.

Apr 1 2016, 12:29 PM · Maniphest, Feature Request
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

I think this default ("all my open stuff") is probably the right one for "Edit Dependencies" and "Edit Maniphest Tasks" from Differential, and for "Edit Blocking Tasks", "Edit Pholio Mocks" and "Edit Differential Revisions" in Maniphest, although the argument for some of those is a little weaker.

Apr 1 2016, 12:21 PM · Maniphest, Feature Request
epriestley added a comment to T10703: Merge Duplicate Tasks should maybe default to All Open.

In my flow I essentially only ever merge by copying the task ID, so the filter doesn't matter at all. Do you tend to search for the task by name?

Apr 1 2016, 12:19 PM · Maniphest, Feature Request
epriestley closed T5323: Incorrect syntax highlighting for PHP when using <script language='PHP'> as Wontfix.

Ah, interesting. I wasn't aware it was gone in PHP7. Given that, I agree that this probably isn't worth supporting (I've never seen this syntax in the wild myself).

Apr 1 2016, 12:09 PM

Mar 31 2016

epriestley created T10702: "Award Badge" action on user profiles should use a typeahead for badge selection.
Mar 31 2016, 9:11 PM · Badges (v0)
epriestley closed T10699: Add staging URLs into `repository.create` endpoint as Resolved.

Sounds good. I added you to Community so you should have sweeping administrative powers now.

Mar 31 2016, 8:47 PM · Feature Request
epriestley added a member for Community: • jshirley.
Mar 31 2016, 8:47 PM
epriestley updated subscribers of T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Mar 31 2016, 8:18 PM · Customer Impact, Restricted Project, Mail
epriestley merged task T10701: Allow emails only for @mentions into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Mar 31 2016, 8:18 PM · Feature Request
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

The more modern, slightly more concise process is:

Mar 31 2016, 7:35 PM · Phacility
epriestley renamed T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from Aphlict slowly grows to use an uncomfortably large amount of memory to Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.
Mar 31 2016, 6:44 PM · Aphlict, Phacility, Ops
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm thinking for my case, there's not really a lot of value in keeping the tags around after the diff has been closed. Maybe that's something to consider?

Mar 31 2016, 5:52 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

I probably wouldn't show them in the UI for now, although I don't think adding an "Other Refs" table underneath tags/branches on the main screen with, say, 5 entries and a "See All" button would necessarily be terrible if anyone can come up with a reason that users might ever care about it.

Mar 31 2016, 5:45 PM · Wikimedia, Restricted Project, Diffusion
epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

User profile images should be getting cached. For example, your profile image here:

Mar 31 2016, 5:28 PM · Restricted Project, Restricted Project, Wikimedia, Files
jdiepenmaat awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Mar 31 2016, 2:16 PM · Calendar
epriestley closed T10700: Disable a Username change for the Registration via a Provider as Resolved.

Sounds good. Let us know if you run into anything else.

Mar 31 2016, 1:46 PM · Auth, Feature Request
epriestley added a comment to T10700: Disable a Username change for the Registration via a Provider.

You can register an event listener for the TYPE_AUTH_WILLREGISTERUSER event. We are generally moving away from this system, but it works today and I don't have any near-term plans to replace it in this case. This is the documentation:

Mar 31 2016, 1:35 PM · Auth, Feature Request
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

I haven't been successful locally in getting a GC'd node to reach an appreciable level of memory consumption, and the production servers are currently at ~1.5GB.

Mar 31 2016, 12:52 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

I think the ~1.5GB node instance size is also expected.

Mar 31 2016, 12:38 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

This is useful, but are there any plans to add this functionality to the GUI? Would be nice to have for when we're doing some housekeeping

Mar 31 2016, 3:31 AM · Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

See T10350.

Mar 31 2016, 1:33 AM · Restricted Project, Projects (v3)
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

Sorry, Vehicle VIN Identification Numbers.

Mar 31 2016, 1:26 AM · Badges
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

(It mostly has reference stuff like our vehicle VIN numbers, our PG&E account number and credentials, etc. If you hack it, you can pay our electric bill!)

Mar 31 2016, 1:26 AM · Badges
epriestley added a comment to T10698: Comment previews should display user badges under the author's profile image..

There is, but we don't use it very much.

Mar 31 2016, 1:22 AM · Badges
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

At least locally, I can't manage to get node to not leak:

Mar 31 2016, 12:02 AM · Aphlict, Phacility, Ops

Mar 30 2016

epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

Oh, and as an unusual special case I'll upstream anything you want to do to PhabricatorRepositoryManagementEditWorkflow and we'll keep it not-broken until T10337, although I promise to break it after that. This workflow has special favor and exists outside the normal rules of usptreaming hacks.

Mar 30 2016, 10:42 PM · Feature Request
epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

You can also just update the JSON value in the details column in phabricator_repository.repository directly. This won't generate a proper transaction in the edit record, but will work correctly (that column is authoritative, and not cached by anything).

Mar 30 2016, 10:39 PM · Feature Request
epriestley added a comment to T10699: Add staging URLs into `repository.create` endpoint.

This would be strictly obsoleted by T10337 and not help us build toward it, so we'd prefer not to pursue it in the upstream.

Mar 30 2016, 10:08 PM · Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

To actually do forking, the pathway is roughly:

Mar 30 2016, 9:41 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10691: Support GitHub-like forking of repositories.

We can do "private branches", but you can already do something like this:

Mar 30 2016, 9:27 PM · Restricted Project, Diffusion, Feature Request
epriestley renamed T10691: Support GitHub-like forking of repositories from Provide a way for users to publish rebased or otherwise "rewritten" branches without generating a ton of email to Support GitHub-like forking of repositories.
Mar 30 2016, 9:22 PM · Restricted Project, Diffusion, Feature Request
epriestley added Q353: How do I get a non-block-based custom remarkup rule to work fine in phabricator? (Answer 353).
Mar 30 2016, 8:41 PM
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

We're seeing a lot of connections stick in "R" ("Reading Request") for a long time, but the client is the load balancer and the request hasn't been read yet so it's not clear exactly what's going on with these. I think they may be crawlers, since pretty much every search engine loves indexing everything on this install hundreds of times an hour.

Mar 30 2016, 6:35 PM · Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

I'm fiddling with LB health checks, so it's my fault if the server vanishes.

Mar 30 2016, 6:22 PM · Phacility, Ops
epriestley added a comment to T10697: Move Aphlict server configuration to a separate configuration file.

Per T9293, client-uri and server-uri should be split into client-port, client-host, admin-port and admin-host.

Mar 30 2016, 6:03 PM · Restricted Project, Aphlict
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

I'll make a note on T10697 to split these options into explicit host and port options. The use of uri options which combined hosts and ports was intended to make specifying hosts and ports more convenient, but I think it's clear that it was a grievous error.

Mar 30 2016, 6:02 PM · Restricted Project, Aphlict
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

MaxRequestWorkers 24 appears to be creating some issues. This host only serves about 5 requests/second, but I can hit delays with concurrency of 10 (e.g., ab -n100 -c10):

Mar 30 2016, 5:13 PM · Phacility, Ops
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

Using client-uri will cause us to use wss:// on pages which are http:// on the client. This seems very confusing/unexpected to me. Although this is probably fine usually, it defies user intent and may not work if, for example, the server certificate is self-signed and the user is using http specifically because their client does not recognize the CA. Such a user would be confused: "I'm connecting with HTTP and it says HTTP in my browser, but I'm getting an SSL certificate error. I specifically switched to HTTP because I know that this client can not trust the certificate."

Mar 30 2016, 3:03 PM · Restricted Project, Aphlict
epriestley added a comment to T9293: WebSockets access problems with reverse SSL proxy .

$_SERVER['HTTPS'] should always reflect the SSL-ness of the original connection. If it does not, it is misconfigured.

Mar 30 2016, 3:00 PM · Restricted Project, Aphlict
epriestley added a comment to T10349: Projects v3 Errata.

See T10326.

Mar 30 2016, 2:26 PM · Restricted Project, Projects (v3)
epriestley updated subscribers of T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley merged task T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx) into T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley added a comment to T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).

I plan to make these options explicit instead. This tangled maze of inferring things from various values is a bad state of affairs. See T10697.

Mar 30 2016, 2:20 PM · Restricted Project, Aphlict
epriestley closed T9293: WebSockets access problems with reverse SSL proxy as Wontfix.

To resolve this, configure your server so that $_SERVER['HTTPS'] is set correctly. This impacts other checks, so it is much better to fix it than try to guess our way around it by examining aphlict.client-uri.

Mar 30 2016, 2:18 PM · Restricted Project, Aphlict
epriestley closed T8169: Intermittent issues with Aphlict / Notifications as Invalid.

This doesn't describe a reproducible problem. See Providing Reproduction Steps.

Mar 30 2016, 2:13 PM · Aphlict
epriestley updated subscribers of T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:10 PM · Restricted Project, Aphlict
epriestley merged task T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict into T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:10 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley added a comment to T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.

I plan to separate this configuration and make these options all explicit, see T10697.

Mar 30 2016, 2:10 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley created T10697: Move Aphlict server configuration to a separate configuration file.
Mar 30 2016, 2:09 PM · Restricted Project, Aphlict
epriestley moved T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley moved T8169: Intermittent issues with Aphlict / Notifications from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Aphlict
epriestley moved T9293: WebSockets access problems with reverse SSL proxy from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Restricted Project, Aphlict
epriestley moved T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx) from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Restricted Project, Aphlict
epriestley moved T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from Backlog to vNext on the Aphlict board.
Mar 30 2016, 1:59 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.

The Aphlict logs don't reveal anything useful, and could use some attention: they're heavily geared toward setup/debugging, not maintenance/operations.

Mar 30 2016, 1:16 PM · Aphlict, Phacility, Ops
epriestley added a project to T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full: Aphlict.
Mar 30 2016, 1:14 PM · Aphlict, Phacility, Ops
epriestley created T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full.
Mar 30 2016, 1:10 PM · Aphlict, Phacility, Ops
epriestley added a comment to T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.

I've deployed a MaxRequestWorkers 24 change to this server and wasn't able to get it to burst over 24 workers with ab, so that seems to be working. I'll keep an eye on it for the rest of the week, and the 48 limit will go out to the cluster later this week if no problems turn up.

Mar 30 2016, 12:57 PM · Phacility, Ops
epriestley renamed T10695: OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers from OOM killer nuked `mysql` on `secure.phabricator.com` after numerous simultaneous macro thumbnailing requests (?) forced into a low-memory condition to OOM killer nuked `mysql` on `secure.phabricator.com` after apache2 spawned 75+ workers.
Mar 30 2016, 12:37 PM · Phacility, Ops