Page MenuHomePhabricator
Feed Advanced Search

Nov 22 2015

joshuaspence renamed T9819: Allow Phurl URLs to reference objects from allow multiple aliases to a phurl to Allow multiple aliases to a Phurl URL.
Nov 22 2015, 2:34 AM · Restricted Project, Phurl

Nov 21 2015

epriestley triaged T9819: Allow Phurl URLs to reference objects as Wishlist priority.

If we do this, one has to be designated "primary" (like Projects) so we can get a consistent default /u/xyz when rendering. This broadly seems like a lot of work for not a lot of payoff, to me, at least today.

Nov 21 2015, 4:15 PM · Restricted Project, Phurl

Nov 20 2015

chad added a comment to T9819: Allow Phurl URLs to reference objects.

User Guide: Prototype Applications

Nov 20 2015, 12:13 AM · Restricted Project, Phurl

Nov 19 2015

avivey created T9819: Allow Phurl URLs to reference objects.
Nov 19 2015, 6:40 PM · Restricted Project, Phurl

Nov 18 2015

lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: D14510: Ref T6049, Add Phurl URL create capability.
Nov 18 2015, 8:40 PM · Phurl

Nov 17 2015

lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: D14502: Ref T6049, Phurl object view should always display some sort of header..
Nov 17 2015, 8:03 PM · Phurl
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

If a Phurl doesn't have a name, should we still show the empty name property on the object view?

Nov 17 2015, 7:55 PM · Phurl

Nov 13 2015

lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: D14477: Remarkup links to link to short url instead of long and fix commenting on Phurl's.
Nov 13 2015, 10:54 PM · Phurl
lpriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

If a Phurl doesn't have a name, should we still show the empty name property on the object view?

Nov 13 2015, 10:17 PM · Phurl

Nov 12 2015

michaeloa added a comment to T5867: Move Quick Create to MenuItemEngine.

As mentioned in T9775, we think this would be a very useful feature for those of us who need to work on multiple projects. Having it tied to the flags application would make it awesomely customizable (and make Flags a much more useful application).

Nov 12 2015, 10:59 PM · Design
chad renamed T5867: Move Quick Create to MenuItemEngine from Add Flags icon and dropdown to global header? to Add Flags/Phurl dropdown to global header?.
Nov 12 2015, 10:39 PM · Design
chad merged task T8994: Implement a "Bookmarks" global menu that displays Phurl URL's into T5867: Move Quick Create to MenuItemEngine.
Nov 12 2015, 10:35 PM · Phurl
chad added a comment to T8994: Implement a "Bookmarks" global menu that displays Phurl URL's.

I'm just going to merge this into T5867

Nov 12 2015, 10:35 PM · Phurl

Nov 10 2015

epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.
  • The view page doesn't actually show the short URL anywhere. You can copy it from "View URL", but I think this isn't totally obvious, and we probably have enough room to reasonably add it (e.g., "Short URL: ..." under "Original URL: ...").
  • If a link has an alias, "View URL" still links to the non-alias version (e.g. U6 links to /u/6, but a more-preferred link would be /u/bug).
  • The "Remarkup Reference" document (https://secure.phabricator.com/book/phabricator/article/remarkup/) should explain how to use ((6)) and ((bug)). It might be worthwhile to hint these on the U6 page itself, e.g. In Remarkup: ((bug)) in the properties? Not sure how useful/cluttered that would look.
  • Maybe show aliases on the list at /phurl/?
  • Maybe let users search for the link with a particular alias? If I know ((bug)), there's no way for me to actually find the URL object right now. Hovercards would be one fix but just going to Phurl and being able to search for "Alias: bug" is probably good too.
Nov 10 2015, 10:37 PM · Phurl
chad added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Also "Active" in the Object Header should just be the normal color, not green. Our design pattern is "normal" states are plainly colored and exceptional states are actively colored. (red, green, purple).

Nov 10 2015, 10:29 PM · Phurl
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Oh, transaction publishing from Phurl also currently fails in the daemons:

Nov 10 2015, 10:25 PM · Phurl
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

A couple of notes so far, after poking at this:

Nov 10 2015, 10:19 PM · Phurl

Nov 9 2015

jhgg added a comment to T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain.

I'm starting to think Phurl is something entirely different than what I'm thinking of... Yup. Nevermind me then.

Nov 9 2015, 7:50 PM · Phurl
jhgg added a comment to T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain.

Used

./bin/config set phurl.short-uri http://p/
Nov 9 2015, 7:43 PM · Phurl
jhgg added a comment to T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain.

So I just tested this out, against: http://p/ and all I'm getting is a 404 page. Does it need to have a TLD?

Nov 9 2015, 7:43 PM · Phurl
lpriestley closed T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain as Resolved.
Nov 9 2015, 7:35 PM · Phurl
epriestley created T9745: Configure phurl.io against secure.phabricator.com.
Nov 9 2015, 7:00 PM · Ops, Phurl
epriestley added a comment to T9744: Harden Phurl against anchor reattachment.

(This is just a note for me to make sure I don't forget about it, I'll follow up here before we unprototype.)

Nov 9 2015, 6:45 PM · Security, Phurl
epriestley created T9744: Harden Phurl against anchor reattachment.
Nov 9 2015, 6:38 PM · Security, Phurl
lpriestley moved T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain from Unprotoytpe to In Process on the Phurl board.
Nov 9 2015, 6:15 PM · Phurl
lpriestley added a revision to T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain: D14447: Allow a domain other than the install domain to serve as a short Phurl domain.
Nov 9 2015, 6:12 PM · Phurl

Nov 7 2015

lpriestley closed T9722: Add Phurl Remarkup as Resolved.
Nov 7 2015, 3:43 AM · Phurl

Nov 6 2015

lpriestley added a revision to T9722: Add Phurl Remarkup: D14427: Add Phurl Remarkup.
Nov 6 2015, 9:51 PM · Phurl

Nov 5 2015

lpriestley moved T9722: Add Phurl Remarkup from Backlog to In Process on the Phurl board.
Nov 5 2015, 7:42 PM · Phurl
lpriestley created T9722: Add Phurl Remarkup.
Nov 5 2015, 7:42 PM · Phurl
lpriestley closed T8990: Create a Phurl application path that will arrive at the target URL as Resolved.
Nov 5 2015, 6:58 PM · Phurl
epriestley added a comment to T8990: Create a Phurl application path that will arrive at the target URL.

Yep, this is good.

Nov 5 2015, 6:58 PM · Phurl
lpriestley updated subscribers of T8990: Create a Phurl application path that will arrive at the target URL.

@epriestley This is already implemented, right? Checking that this doesn't entail anything more complex than what we already wrote.

Nov 5 2015, 6:57 PM · Phurl
lpriestley closed T8992: Actually implement an `alias` field on Phurl URL's as Resolved.

I think this is wrapped up. Any loose ends should be added as separate tasks.

Nov 5 2015, 6:56 PM · Phurl
lpriestley added a revision to T8992: Actually implement an `alias` field on Phurl URL's: D14414: Updating xaction titles for Phurl updates.
Nov 5 2015, 6:50 PM · Phurl
lpriestley added a revision to T8992: Actually implement an `alias` field on Phurl URL's: D14413: Preventing duplicate empty string aliases in Phurl's.
Nov 5 2015, 6:13 PM · Phurl

Nov 4 2015

lpriestley added a revision to T8992: Actually implement an `alias` field on Phurl URL's: D14403: Helper method for max text field length and validate alias length.
Nov 4 2015, 6:01 PM · Phurl
lpriestley added a revision to T8992: Actually implement an `alias` field on Phurl URL's: D14401: Check that Phurl alias is unique.
Nov 4 2015, 5:03 PM · Phurl
epriestley added a comment to T8992: Actually implement an `alias` field on Phurl URL's.

I don't think we need to auto-generate (and think it's slightly desirable not to -- I don't think we can do anything reasonable most of the time, and it will tend to make it harder to find a good alias when you actually want one if we do).

Nov 4 2015, 11:50 AM · Phurl
lpriestley moved T8992: Actually implement an `alias` field on Phurl URL's from Unprotoytpe to In Process on the Phurl board.
Nov 4 2015, 3:13 AM · Phurl
lpriestley added a comment to T8992: Actually implement an `alias` field on Phurl URL's.

@epriestley I wrote in the original description (possibly after talking to you):

Should be an optional field that auto-generates a value if no value is given.

Nov 4 2015, 3:12 AM · Phurl

Nov 3 2015

lpriestley added a revision to T8992: Actually implement an `alias` field on Phurl URL's: D14395: Add an alias to Phurl URL's.
Nov 3 2015, 6:43 PM · Phurl
epriestley closed T9695: Have the ability to have an interstitial page for outbound Phurl links. as Wontfix.

I think this is exceedingly mild/theoretical.

Nov 3 2015, 3:54 AM · Phurl
Mnkras added a comment to T9695: Have the ability to have an interstitial page for outbound Phurl links..

This is probably geared towards more public installs, where short urls could be abused, (such as this one).

Nov 3 2015, 3:47 AM · Phurl
epriestley added a comment to T9695: Have the ability to have an interstitial page for outbound Phurl links..

Can you give me a specific scenario where this would be useful?

Nov 3 2015, 3:32 AM · Phurl

Nov 2 2015

Mnkras created T9695: Have the ability to have an interstitial page for outbound Phurl links..
Nov 2 2015, 11:35 PM · Phurl
lpriestley moved T8991: Creating a Phurl URL should validate a URL from In Process to Backlog on the Phurl board.
Nov 2 2015, 10:12 PM · Phurl
lpriestley moved T8991: Creating a Phurl URL should validate a URL from Backlog to In Process on the Phurl board.
Nov 2 2015, 10:08 PM · Phurl
lpriestley moved T8992: Actually implement an `alias` field on Phurl URL's from Backlog to Unprotoytpe on the Phurl board.
Nov 2 2015, 10:08 PM · Phurl
lpriestley moved T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain from Backlog to Unprotoytpe on the Phurl board.
Nov 2 2015, 10:08 PM · Phurl
epriestley changed the edit policy for Phurl.
Nov 2 2015, 10:00 PM
lpriestley closed T9691: Creating a Phurl URL for a URL with an invalid protocol should throw an error as Resolved by committing rP60cf71e724c4: Validate new Phurl URL.
Nov 2 2015, 9:53 PM · Phurl
lpriestley added a revision to T9691: Creating a Phurl URL for a URL with an invalid protocol should throw an error: D14389: Validate new Phurl URL.
Nov 2 2015, 9:50 PM · Phurl
lpriestley created T9691: Creating a Phurl URL for a URL with an invalid protocol should throw an error.
Nov 2 2015, 9:15 PM · Phurl
lpriestley closed T8989: Phurl objects should have a link like "Visit URL". as Resolved.
Nov 2 2015, 9:11 PM · Phurl
lpriestley added a revision to T8989: Phurl objects should have a link like "Visit URL".: D14386: Phurl URL object should show a banner if the URL is invalid.
Nov 2 2015, 9:06 PM · Phurl
lpriestley added a revision to T8989: Phurl objects should have a link like "Visit URL".: D14381: Ref T8989, Phurl "Visit URL" link should route through a separate controller..
Nov 2 2015, 7:39 PM · Phurl
lpriestley added a revision to T8989: Phurl objects should have a link like "Visit URL".: D14379: Ref T8989, Add a "Visit URL" link to Phurl items..
Nov 2 2015, 4:30 PM · Phurl

Oct 8 2015

joshuaspence added a project to T9528: PhabricatorTaskmasterDaemon exiting with error 255 repeatedly: Phurl.
Oct 8 2015, 5:10 AM · Phurl, Daemons

Sep 21 2015

chasemp added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

pretty neat and useful idea

Sep 21 2015, 9:12 PM · Phurl

Jul 30 2015

ox added a comment to T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.

Oh! I didn't notice the prototype tag all the way on the right (we have really wide monitors). That is totally fair. Apologies for wasting your time on prototype bugs.

Jul 30 2015, 2:14 PM · Phurl
chad added a comment to T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.

@ox it literally was just started a few days ago, it should be more usable in a few weeks.

Jul 30 2015, 2:12 PM · Phurl
epriestley closed T9009: Cannot comment on Phurl links as Invalid.
Jul 30 2015, 2:10 PM · Phurl
epriestley added a comment to T9009: Cannot comment on Phurl links.

See T9022 / https://secure.phabricator.com/book/phabricator/article/prototypes/

Jul 30 2015, 2:10 PM · Phurl
epriestley closed T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route as Invalid.

I'm just going to close this and T9009 out under the "we know prototypes are super broken, wait until they unprototype before reporting bugs" rule, I think @lpriestley has a handle on it.

Jul 30 2015, 2:10 PM · Phurl
epriestley closed T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route, a subtask of T9009: Cannot comment on Phurl links, as Invalid.
Jul 30 2015, 2:10 PM · Phurl
ox added a comment to T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.

@chad: Not even eventually?

Jul 30 2015, 2:09 PM · Phurl
chad added a comment to T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.

I don't believe Phurl is meant to be usuable.

Jul 30 2015, 2:07 PM · Phurl
ox created T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.
Jul 30 2015, 2:04 PM · Phurl
chad added a comment to T9009: Cannot comment on Phurl links.

As noted in D13759, there is also no route and no comment controller.

Jul 30 2015, 3:40 AM · Phurl
ox added a revision to T9009: Cannot comment on Phurl links: D13759: Remove extra `/phurl` in request url.
Jul 30 2015, 12:15 AM · Phurl

Jul 29 2015

ox added a comment to T9009: Cannot comment on Phurl links.

yup: https://secure.phabricator.com/diffusion/P/browse/master/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php;b24935df2f74006c8221ee934c3d06b0781ac70b$48

Jul 29 2015, 11:21 PM · Phurl
epriestley added a comment to T9009: Cannot comment on Phurl links.

Probably a getApplicationURI('phurl/x/') which should be getApplicationURI('x/').

Jul 29 2015, 11:20 PM · Phurl
epriestley updated subscribers of T9009: Cannot comment on Phurl links.
Jul 29 2015, 11:20 PM · Phurl
ox created T9009: Cannot comment on Phurl links.
Jul 29 2015, 11:18 PM · Phurl
jhgg added a comment to T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain.

+1 on this, we have phabricator on an internal searchdomain for our deploy. http://p/

Jul 29 2015, 3:30 AM · Phurl
Mnkras added a comment to T8991: Creating a Phurl URL should validate a URL.

Not sure that is needed, on intranets you can have sites like "http://someserver/some_folder/and.file" which isn't a valid public URL but is valid.

Jul 29 2015, 1:49 AM · Phurl

Jul 28 2015

chad added a comment to T8994: Implement a "Bookmarks" global menu that displays Phurl URL's.

See also T5867

Jul 28 2015, 10:14 PM · Phurl
chad changed the edit policy for Phurl.
Jul 28 2015, 10:00 PM
lpriestley created T8995: Allow a domain other than the install domain to serve as the "short" Phurl domain.
Jul 28 2015, 9:49 PM · Phurl
lpriestley created T8994: Implement a "Bookmarks" global menu that displays Phurl URL's.
Jul 28 2015, 9:44 PM · Phurl
lpriestley created T8993: Shortcut to get current Phabricator URL as a Phurl URL.
Jul 28 2015, 9:40 PM · Phurl
lpriestley updated the task description for T8992: Actually implement an `alias` field on Phurl URL's.
Jul 28 2015, 9:38 PM · Phurl
lpriestley created T8992: Actually implement an `alias` field on Phurl URL's.
Jul 28 2015, 9:36 PM · Phurl
lpriestley created T8991: Creating a Phurl URL should validate a URL.
Jul 28 2015, 9:34 PM · Phurl
lpriestley created T8990: Create a Phurl application path that will arrive at the target URL.
Jul 28 2015, 9:32 PM · Phurl
lpriestley created T8989: Phurl objects should have a link like "Visit URL"..
Jul 28 2015, 9:31 PM · Phurl

Jul 26 2015

joshuaspence added a member for Phurl: joshuaspence.
Jul 26 2015, 3:48 AM

Jul 23 2015

cburroughs added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

With my 'I have a corporate install' hat I think 'Alternate Short Domain' is needed for the 'Shortener' case to work out in practice. phabricator.mycompany.com is already longer than an entire t.co url. Those two features are probably enough to replace our current internal shortener thingy.

Jul 23 2015, 12:34 PM · Phurl

Jul 22 2015

epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Walking through some use cases, roughly in increasing order of complexity, and general behaviors -- this is all me just imagining things, not necessarily the best way forward:

Jul 22 2015, 9:39 PM · Phurl
lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: D13681: DRAFT - throw together Phurl skeleton..
Jul 22 2015, 7:35 PM · Phurl

Jul 16 2015

20after4 updated the task description for T6049: Implement Phurl, a URL shortener/bookmarking application.
Jul 16 2015, 5:44 PM · Phurl

May 1 2015

epriestley assigned T6049: Implement Phurl, a URL shortener/bookmarking application to lpriestley.
May 1 2015, 5:40 PM · Phurl

Sep 8 2014

epriestley created T6049: Implement Phurl, a URL shortener/bookmarking application.
Sep 8 2014, 6:06 PM · Phurl