Page MenuHomePhabricator
Create Task
Maniphest T9009

Cannot comment on Phurl links
Closed, InvalidPublic
Actions

Description

When viewing a Phurl link's page, pressing the comment button doesn't do anything and POST requests to the commenting endpoint (/phurl/phurl/comment/1/ [note the 2 phurls in the address]) return 404.

Revisions and Commits

rP Phabricator
AbandonedD13759 Remove extra `/phurl` in request url

Related Objects
Search...

Event Timeline

ox created this task.Jul 29 2015, 11:18 PM
ox raised the priority of this task from to Needs Triage.
ox updated the task description. (Show Details)
ox added a project: Phurl.
ox changed the edit policy from "All Users" to "Task Author".
ox added a subscriber: ox.
epriestley added subscribers: epriestley, lpriestley.Jul 29 2015, 11:20 PM

Probably a getApplicationURI('phurl/x/') which should be getApplicationURI('x/').

ox added a comment.Jul 29 2015, 11:21 PM

yup: https://secure.phabricator.com/diffusion/P/browse/master/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php;b24935df2f74006c8221ee934c3d06b0781ac70b$48

ox added a revision: D13759: Remove extra `/phurl` in request url.Jul 30 2015, 12:15 AM
chad added a subscriber: chad.Jul 30 2015, 3:40 AM

As noted in D13759, there is also no route and no comment controller.

joshuaspence added a subscriber: joshuaspence.Jul 30 2015, 10:24 AM
epriestley mentioned this in T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route.Jul 30 2015, 2:10 PM
epriestley closed subtask T9022: Phurl missing `PhabricatorPhurlCommentController` and commenting route as Invalid.

See T9022 / https://secure.phabricator.com/book/phabricator/article/prototypes/

epriestley closed this task as Invalid.Jul 30 2015, 2:10 PM
epriestley claimed this task.
Phabricator · Built by Phacility