Page MenuHomePhabricator

Ref T6049, Add Phurl URL create capability
ClosedPublic

Authored by lpriestley on Nov 18 2015, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 1:28 AM
Unknown Object (File)
Tue, Mar 12, 3:20 AM
Unknown Object (File)
Mon, Mar 11, 7:10 PM
Unknown Object (File)
Mon, Mar 11, 5:53 PM
Unknown Object (File)
Mon, Mar 11, 5:21 PM
Unknown Object (File)
Mon, Mar 11, 3:50 PM
Unknown Object (File)
Mon, Mar 11, 3:11 PM
Unknown Object (File)
Wed, Mar 6, 5:21 AM
Subscribers

Details

Summary

Ref T6049, Add Phurl URL create capability

Test Plan
  • Change HomeApplicationsPhurlConfigure to allow no one to create Phurl URLs
  • Attempt PhurlShorten URL. Should not be able to create a Phurl.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Ref T6049, Add Phurl URL create capability.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phurl/application/PhabricatorPhurlApplication.php
67

For consistency, just omit this caption. In other applications, "Default Policies" (like "Default View Policy" and "Default Edit Policy") are used to prefill "Can View" and "Can Edit" when creating new objects. This isn't a "Default" policy like those policies.

src/applications/phurl/capability/PhabricatorPhurlURLCreateCapability.php
7

For consistency, omit .default.

This revision is now accepted and ready to land.Nov 18 2015, 8:45 PM
lpriestley edited edge metadata.

Omitting stuff for consistency

This revision was automatically updated to reflect the committed changes.