Page MenuHomePhabricator

Remove extra `/phurl` in request url
AbandonedPublic

Authored by ox on Jul 30 2015, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 3:27 AM
Unknown Object (File)
Sat, Jun 25, 9:39 AM
Unknown Object (File)
Sat, Jun 25, 5:21 AM
Unknown Object (File)
Tue, Jun 21, 5:37 AM
Unknown Object (File)
May 29 2022, 1:39 AM
Unknown Object (File)
Apr 16 2017, 12:25 PM
Unknown Object (File)
Apr 15 2017, 7:02 PM
Unknown Object (File)
Apr 12 2017, 12:26 PM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9009: Cannot comment on Phurl links
Summary

Should fix T9009

Test Plan

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D13759
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 7449
Build 7938: [Placeholder Plan] Wait for 30 Seconds
Build 7937: arc lint + arc unit

Event Timeline

ox retitled this revision from to Remove extra `/phurl` in request url.
ox updated this object.
ox edited the test plan for this revision. (Show Details)
chad added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
48

I think you don't need the first / either

ox marked an inline comment as done.
ox edited edge metadata.

remove leading / as it was getting trimmed anyway

chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 30 2015, 3:18 AM

Although, looking at the code, PhabricatorPhurlCommentController doesn't exist either, nor the route.

But this change is correct!

I don't know enough PHP to really get what this app is doing, but I imagined some smart folks at Phacility had created a generic commenting service and I was just not seeing it. Thanks for the help!

epriestley added a reviewer: epriestley.

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Let's just wait for the normal dev process here.

This revision now requires changes to proceed.Jul 30 2015, 2:11 PM