Page MenuHomePhabricator

Ref T8989, Add a "Visit URL" link to Phurl items.
ClosedPublic

Authored by lpriestley on Nov 2 2015, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 5:47 PM
Unknown Object (File)
Wed, Mar 27, 5:31 PM
Unknown Object (File)
Wed, Mar 27, 4:58 PM
Unknown Object (File)
Wed, Mar 27, 2:31 PM
Unknown Object (File)
Sun, Mar 24, 7:50 PM
Unknown Object (File)
Tue, Mar 5, 1:18 PM
Unknown Object (File)
Feb 17 2024, 1:03 AM
Unknown Object (File)
Feb 3 2024, 2:08 PM
Subscribers

Details

Summary

Ref T8989, Add a "Visit URL" link to Phurl items and make it actionable if the URI has a valid protocol.

Test Plan
  • Create a Phurl object with a URI of "google.com".
  • "Visit URL" action in action view should be greyed out.
  • Edit object to have URI "http://google.com" and save. "Visit URL" link should be available and should redirect to the intended URL.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Ref T8989, Add a "Visit URL" link to Phurl items..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

You can probably click the "Land Revision" button to land this from the web UI if you want to try it.

This revision is now accepted and ready to land.Nov 2 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.