Page MenuHomePhabricator
Differential D14379

Ref T8989, Add a "Visit URL" link to Phurl items.
ClosedPublic
Actions

Authored by lpriestley on Nov 2 2015, 4:30 PM.
Tags
None
Referenced Files
F18835806: D14379.id.diff
Sun, Oct 26, 6:58 PM
F18758278: D14379.diff
Oct 5 2025, 9:34 PM
F18756757: D14379.diff
Oct 5 2025, 1:21 PM
F18712812: D14379.id.diff
Sep 29 2025, 5:33 AM
F18659619: D14379.id34728.diff
Sep 23 2025, 2:02 PM
F18085269: D14379.diff
Aug 5 2025, 7:06 PM
F17946950: D14379.id34727.diff
Jul 31 2025, 3:32 PM
F17943296: D14379.id.diff
Jul 31 2025, 8:06 AM
View All Files
Subscribers
chad
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8989: Phurl objects should have a link like "Visit URL".
Commits
Restricted Diffusion Commit
rP09d4ea884fe4: Ref T8989, Add a "Visit URL" link to Phurl items.
Summary

Ref T8989, Add a "Visit URL" link to Phurl items and make it actionable if the URI has a valid protocol.

Test Plan
  • Create a Phurl object with a URI of "google.com".
  • "Visit URL" action in action view should be greyed out.
  • Edit object to have URI "http://google.com" and save. "Visit URL" link should be available and should redirect to the intended URL.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 34727.Nov 2 2015, 4:30 PM
lpriestley retitled this revision from to Ref T8989, Add a "Visit URL" link to Phurl items..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8989: Phurl objects should have a link like "Visit URL"..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 2 2015, 4:30 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 2 2015, 4:36 PM
epriestley edited edge metadata.

You can probably click the "Land Revision" button to land this from the web UI if you want to try it.

This revision is now accepted and ready to land.Nov 2 2015, 4:36 PM
chad added a subscriber: chad.Nov 2 2015, 4:37 PM

WB!

snoopy_dancing.jpg (1×1 px, 130 KB)

Closed by commit rP09d4ea884fe4: Ref T8989, Add a "Visit URL" link to Phurl items. (authored by lpriestley, committed by lpriestley). · Explain WhyNov 2 2015, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
controller/
34 lines

Diff 34728

View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Loading...
Phabricator · Built by Phacility