Page MenuHomePhabricator

Updating xaction titles for Phurl updates
ClosedPublic

Authored by lpriestley on Nov 5 2015, 6:50 PM.
Tags
None
Referenced Files
F18052379: D14414.diff
Mon, Aug 4, 2:21 AM
F17735550: D14414.id34823.diff
Sun, Jul 20, 2:36 PM
F17735549: D14414.id34822.diff
Sun, Jul 20, 2:35 PM
Unknown Object (File)
Jun 26 2025, 8:14 PM
Unknown Object (File)
Jun 26 2025, 6:39 PM
Unknown Object (File)
Jun 26 2025, 5:21 PM
Unknown Object (File)
Jun 15 2025, 7:53 PM
Unknown Object (File)
May 26 2025, 5:14 PM
Subscribers

Details

Summary

Ref T8992, Cleaning up and clarifying xaction titles for Phurl creation/updating.

Test Plan

Create a Phurl, update information, make sure xaction in the timeline makes sense.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Updating xaction titles for Phurl updates.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

I think the $old != $new clauses should be unnecessary -- we should be dropping those transactions before we ever get to rendering them. Rest of this looks good.

This revision is now accepted and ready to land.Nov 5 2015, 6:51 PM
lpriestley edited edge metadata.

Removing redundant check for $old != $new

This revision was automatically updated to reflect the committed changes.