Page MenuHomePhabricator
Create Task
Maniphest T8992

Actually implement an `alias` field on Phurl URL's
Closed, ResolvedPublic
Actions

Description

The database column already exists, just need to expose it. Should be an optional field that auto-generates a value if no value is given.

per @epriestley:

The alias would be a unique alphanumeric string like "restart", which could not contain special characters. It also could not be purely numeric (for example, you can't give a link the alias 123, because then U123 and the aliased link would both have the URL /u/123.
If a link has an alias, both /u/2 and /u/restart would still work correctly (adding an alias doesn't break old links). The detail URL is still /U2, and the edit URL is still /phurl/edit/2/ or whatever.

Revisions and Commits

rP Phabricator
D14414rP9132b565d5c5 Updating xaction titles for Phurl updates
D14413rPe2c0df4fb49f Preventing duplicate empty string aliases in Phurl's
D14403rP5c6d2be18f59 Helper method for max text field length and validate alias length
D14401rP262d7b7780bd Check that Phurl alias is unique
D14395rP2b05f7cc43da Add an alias to Phurl URL's

Event Timeline

lpriestley created this task.Jul 28 2015, 9:36 PM
lpriestley claimed this task.
lpriestley raised the priority of this task from to Normal.
lpriestley updated the task description. (Show Details)
lpriestley added a project: Phurl.
lpriestley added a subscriber: lpriestley.
lpriestley updated the task description. (Show Details)Jul 28 2015, 9:38 PM
lpriestley added a subscriber: epriestley.
joshuaspence added a subscriber: joshuaspence.Aug 24 2015, 9:11 PM
lpriestley moved this task from Backlog to Unprotoytpe on the Phurl board.Nov 2 2015, 10:08 PM
lpriestley added a revision: D14395: Add an alias to Phurl URL's.Nov 3 2015, 6:43 PM
lpriestley added a commit: rP2b05f7cc43da: Add an alias to Phurl URL's.Nov 4 2015, 3:09 AM
lpriestley added a comment.Nov 4 2015, 3:12 AM

@epriestley I wrote in the original description (possibly after talking to you):

Should be an optional field that auto-generates a value if no value is given.

But isn't that what the ID already does? Is this still something you think we should do?

lpriestley moved this task from Unprotoytpe to In Process on the Phurl board.Nov 4 2015, 3:13 AM
epriestley added a comment.Nov 4 2015, 11:50 AM

I don't think we need to auto-generate (and think it's slightly desirable not to -- I don't think we can do anything reasonable most of the time, and it will tend to make it harder to find a good alias when you actually want one if we do).

lpriestley added a revision: D14401: Check that Phurl alias is unique.Nov 4 2015, 5:03 PM
lpriestley added a commit: rP262d7b7780bd: Check that Phurl alias is unique.Nov 4 2015, 5:05 PM
lpriestley added a revision: D14403: Helper method for max text field length and validate alias length.Nov 4 2015, 6:01 PM
lpriestley added a commit: rP5c6d2be18f59: Helper method for max text field length and validate alias length.Nov 4 2015, 6:22 PM
lpriestley added a revision: D14413: Preventing duplicate empty string aliases in Phurl's.Nov 5 2015, 6:13 PM
lpriestley added a commit: rPe2c0df4fb49f: Preventing duplicate empty string aliases in Phurl's.Nov 5 2015, 6:14 PM
lpriestley added a revision: D14414: Updating xaction titles for Phurl updates.Nov 5 2015, 6:50 PM
lpriestley added a commit: rP9132b565d5c5: Updating xaction titles for Phurl updates.Nov 5 2015, 6:54 PM
lpriestley closed this task as Resolved.Nov 5 2015, 6:56 PM

I think this is wrapped up. Any loose ends should be added as separate tasks.

Phabricator · Built by Phacility