Page MenuHomePhabricator

Give custom controls passable disabled states
ClosedPublic

Authored by epriestley on Dec 17 2015, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 12, 8:18 AM
Unknown Object (File)
Thu, Sep 5, 5:57 PM
Unknown Object (File)
Wed, Sep 4, 11:34 PM
Unknown Object (File)
Wed, Sep 4, 12:27 PM
Unknown Object (File)
Sat, Aug 31, 7:14 PM
Unknown Object (File)
Wed, Aug 28, 10:19 PM
Unknown Object (File)
Wed, Aug 28, 10:18 PM
Unknown Object (File)
Wed, Aug 28, 10:18 PM
Subscribers
None

Details

Summary

Fixes T9871. Ref T10004. These won't win any awards but it fixes them being incredibly weird and confusing.

Test Plan

Screen Shot 2015-12-17 at 1.30.37 PM.png (961×1 px, 83 KB)

  • Tried to use controls, got reasonable behavior.
  • Used normal controls to make sure I didn't break anything.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tokenizers aren't showing default values correctly so I probably need to do that one a little less badly.

epriestley edited edge metadata.
  • Cleaner patch.
  • Fewer debug logs.
  • Less bad behavior.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 17 2015, 11:12 PM
This revision was automatically updated to reflect the committed changes.