Page MenuHomePhabricator
Create Task
Maniphest T10116

ctrl+enter in comment field in maniphest issues with new editor
Closed, ResolvedPublic
Actions

Description

In the new editor, ctrl+enter on the comment field fails with "You can not post an empty comment.", even if there are other changes; this *used* to commit the other changes.

If there is data in the comment field, ctrl+enter doesn't commit the other changes, which will be lost.

Pressing the button does work.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

carlokok created this task.Jan 11 2016, 8:49 AM
carlokok added a project: Maniphest.
epriestley added subscribers: joshuaspence, epriestley.Jan 11 2016, 10:22 AM

@joshuaspence, is it possible that this was causing the issue you were seeing in T10004?

joshuaspence added a comment.Jan 11 2016, 10:56 AM

Hmm, it is possible.

epriestley added a revision: Restricted Differential Revision.Jan 11 2016, 11:01 AM
epriestley added a comment.Jan 11 2016, 11:02 AM

(I never tried to reproduce with Command + Enter because I always use Tab, Enter, and the symptoms seem identical.)

epriestley claimed this task.Jan 11 2016, 11:35 AM
epriestley triaged this task as Normal priority.
epriestley edited projects, added ApplicationEditor; removed Maniphest.
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 11 2016, 5:16 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley mentioned this in T10004: ApplicationEditor Errata.Jan 14 2016, 3:22 PM
epriestley mentioned this in T10263: Using Cmd+Enter on "Add Actions" results in actions not being applied.Feb 2 2016, 3:12 PM
Phabricator · Built by Phacility