Page MenuHomePhabricator
Differential D14911

Give IconSetControl a meaningful disabled state
ClosedPublic
Actions

Authored by epriestley on Dec 30 2015, 11:26 AM.
Tags
None
Referenced Files
F14856179: D14911.diff
Wed, Feb 5, 2:11 PM
Unknown Object (File)
Sat, Feb 1, 7:51 AM
Unknown Object (File)
Thu, Jan 30, 1:10 PM
Unknown Object (File)
Sun, Jan 26, 11:54 PM
Unknown Object (File)
Fri, Jan 24, 10:51 AM
Unknown Object (File)
Fri, Jan 24, 10:51 AM
Unknown Object (File)
Fri, Jan 24, 10:51 AM
Unknown Object (File)
Tue, Jan 21, 11:45 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
rP972788b8b5df: Give IconSetControl a meaningful disabled state
Summary

Ref T10004. This control doesn't disable visually or behaviorally, e.g. when locked in an EditEngine configuration.

Test Plan
  • Locked field for Projects.
  • Reviewed form in EditEngine.
  • Created/edited a project.
  • Swapped default.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36036.Dec 30 2015, 11:26 AM
epriestley retitled this revision from to Give IconSetControl a meaningful disabled state.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10004: ApplicationEditor Errata.
chad accepted this revision.Dec 30 2015, 5:08 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2015, 5:08 PM
Closed by commit rP972788b8b5df: Give IconSetControl a meaningful disabled state (authored by epriestley, committed by epriestley). · Explain WhyDec 30 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
project/
editor/
2 lines
view/
form/
control/
13 lines
webroot/
rsrc/
js/
core/
9 lines

Diff 36045

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/view/form/control/PHUIFormIconSetControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-choose-control.js

Loading...
Phabricator · Built by Phacility