Page MenuHomePhabricator

Remove all setObjectURI() from ActionListViews
ClosedPublic

Authored by epriestley on Dec 17 2015, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 7:18 AM
Unknown Object (File)
Tue, Mar 5, 7:18 AM
Unknown Object (File)
Tue, Mar 5, 7:18 AM
Unknown Object (File)
Tue, Mar 5, 7:18 AM
Unknown Object (File)
Feb 10 2024, 11:46 AM
Unknown Object (File)
Feb 4 2024, 7:50 AM
Unknown Object (File)
Jan 24 2024, 5:46 PM
Unknown Object (File)
Jan 6 2024, 6:52 PM
Subscribers

Details

Summary

Ref T10004. After D14804, we get this behavior by default and no longer need to set it explicitly.

(If some endpoint did eventually need to set it explicitly, it could just change what it passes to setHref(), but I believe we currently have no such endpoints and do not foresee ever having any.)

Test Plan
  • As a logged out user, clicked various links in Differential, Maniphest, Files, etc., always got redirected to a sensible place after login.
  • Grepped for setObjectURI(), getObjectURI() (there are a few remaining callsites, but to a different method with the same name in Doorkeeper).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove all setObjectURI() from ActionListViews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
This revision is now accepted and ready to land.Dec 17 2015, 3:31 PM
This revision was automatically updated to reflect the committed changes.