Paths

Table of Contentst

Differential D14857

Allow users to swipe away stacked actions on mobile
ClosedPublic
Actions

Authored by epriestley on Dec 23 2015, 2:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 10:39 AM

	Unknown Object (File)
	Mon, Dec 16, 8:45 PM

	Unknown Object (File)
	Sun, Dec 15, 5:59 PM

	Unknown Object (File)
	Sat, Dec 14, 8:04 AM

	Unknown Object (File)
	Fri, Dec 13, 8:43 PM

	Unknown Object (File)
	Fri, Dec 6, 10:39 AM

	Unknown Object (File)
	Tue, Dec 3, 7:43 AM

	Unknown Object (File)
	Tue, Dec 3, 2:32 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10004: ApplicationEditor Errata

Commits

Restricted Diffusion Commit
rPf422c9b955ed: Allow users to swipe away stacked actions on mobile

Summary

Ref T10004. This might be a little too funky or magical, but is probably not necessary too often and easier than doing new layout with the CSS.

Also make the desktop icons a little meatier.

Test Plan

Swiped things away on mobile. Clicked things away on desktop.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35919.Dec 23 2015, 2:14 AM

epriestley retitled this revision from to Allow users to swipe away stacked actions on mobile.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10004: ApplicationEditor Errata.

Herald edited edge metadata. · View Herald TranscriptDec 23 2015, 2:14 AM

chad accepted this revision.Dec 23 2015, 3:06 AM

chad edited edge metadata.

chad added inline comments.

webroot/rsrc/css/phui/phui-form-view.css
540	.device too?

This revision is now accepted and ready to land.Dec 23 2015, 3:06 AM

epriestley added inline comments.Dec 23 2015, 3:15 AM

webroot/rsrc/css/phui/phui-form-view.css
540	This element isn't visible on `.device` anyway.

Oh, maybe it's visible on tablet.

.device-desktop the hover.

Closed by commit rPf422c9b955ed: Allow users to swipe away stacked actions on mobile (authored by epriestley, committed by epriestley). · Explain WhyDec 23 2015, 3:17 AM

This revision was automatically updated to reflect the committed changes.

This feels okay to me in production. I think it's probably hard to guess that it works, but maybe users are more inclined to try swiping than I am or just won't run into this very much (in most cases, you can just leave the action anyway).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

27 lines

webroot/

rsrc/

css/

phui/

phui-form-view.css

9 lines

js/

application/

transactions/

behavior-comment-actions.js

29 lines

Diff 35923

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-form-view.css

Loading...

webroot/rsrc/js/application/transactions/behavior-comment-actions.js

Loading...