Fix an issue where storage inlines are fed to InlineAdjustmentEngine
ClosedPublic
Actions

Authored by epriestley on May 8 2020, 11:51 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPebf254dac351: (stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine
rP6dc20d1e2e71: Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Summary

Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan

Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 8 2020, 11:51 PM

Harbormaster completed remote builds in B24397: Diff 50580.May 8 2020, 11:53 PM

epriestley requested review of this revision.May 8 2020, 11:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 11:55 PM

Closed by commit rP6dc20d1e2e71: Fix an issue where storage inlines are fed to InlineAdjustmentEngine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6dc20d1e2e71: Fix an issue where storage inlines are fed to InlineAdjustmentEngine.

epriestley added a commit: rPebf254dac351: (stable) Fix an issue where storage inlines are fed to InlineAdjustmentEngine.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

2 lines

Diff 50581

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Fix an issue where storage inlines are fed to InlineAdjustmentEngineClosedPublicActions