Page MenuHomePhabricator

Fix an issue where storage inlines are fed to InlineAdjustmentEngine
ClosedPublic

Authored by epriestley on Fri, May 8, 11:51 PM.

Details

Summary

Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan

Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, May 8, 11:51 PM
epriestley requested review of this revision.Fri, May 8, 11:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, May 8, 11:55 PM
This revision was automatically updated to reflect the committed changes.