Page MenuHomePhabricator

Fix an issue where storage inlines are fed to InlineAdjustmentEngine
ClosedPublic

Authored by epriestley on May 8 2020, 11:51 PM.

Details

Summary

Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan

Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable