Page MenuHomePhabricator

Fix an issue where storage inlines are fed to InlineAdjustmentEngine
ClosedPublic

Authored by epriestley on May 8 2020, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 4:54 PM
Unknown Object (File)
Jun 3 2025, 5:02 AM
Unknown Object (File)
Jun 1 2025, 5:35 AM
Unknown Object (File)
May 31 2025, 1:42 PM
Unknown Object (File)
May 4 2025, 2:31 AM
Unknown Object (File)
Apr 29 2025, 5:34 AM
Unknown Object (File)
Apr 28 2025, 1:44 PM
Unknown Object (File)
Apr 25 2025, 2:36 AM
Subscribers
None

Details

Summary

Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan

Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable