Page MenuHomePhabricator

TransactionsProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Anything related to the abstraction "transactions" in the Phabricator code stack. These bad boys are what individual actions like comments are composed of within a given Phabricator application. In theory anyway...

Recent Activity

Jul 21 2020

epriestley triaged T13553: Creating a milestone via the API fails when accessing the project's parent as Normal priority.
Jul 21 2020, 5:54 PM · Transactions, Projects

May 4 2020

epriestley closed T10926: Make it more likely to see assignee & reporter in task view without having to scroll down as Resolved.

I reordered these elements in D21200. See also D20967.

May 4 2020, 7:52 PM · Transactions, Feature Request, Maniphest

Nov 8 2019

epriestley added a parent task for T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules: T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.
Nov 8 2019, 12:57 AM · Transactions
epriestley triaged T13449: When objects are created with a particular subtype, apply subtype-appropriate validation rules as Normal priority.
Nov 8 2019, 12:57 AM · Transactions

Oct 17 2019

epriestley added a revision to T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior: D20860: Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project.
Oct 17 2019, 4:43 PM · Transactions
epriestley triaged T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior as Low priority.
Oct 17 2019, 4:34 PM · Transactions

Jun 22 2019

epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20611: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function.
Jun 22 2019, 4:03 PM · Transactions

Jun 20 2019

epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20605: Fix two "msort()" vs "msortv()" issues in "arc land".
Jun 20 2019, 9:41 PM · Transactions

Jun 19 2019

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

I think that might be everything? Not entirely sure, but haven't seen any more since the last deploy.

Jun 19 2019, 5:29 PM · Transactions
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20587: Fix more "msort()" vs "msortv()" callsites.
Jun 19 2019, 5:29 PM · Transactions

Jun 17 2019

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

I deployed that last round of things to secure. Not totally confident I got everything, but hopefully we're in better shape now.

Jun 17 2019, 9:25 PM · Transactions
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20585: Fix another stray "msort()/msortv()" issue.
Jun 17 2019, 8:11 PM · Transactions
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes.
Jun 17 2019, 5:40 PM · Transactions
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20582: Consider "msort()" on "PhutilSortVector" objects to be an error.
Jun 17 2019, 5:36 PM · Transactions
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

uhoh looks like I'm a dum dum

Jun 17 2019, 5:33 PM · Transactions
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

This is doing somewhat better now, but I've still seen:

Jun 17 2019, 5:23 PM · Transactions

May 30 2019

epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.

D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

May 30 2019, 11:15 PM · Transactions
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order.
May 30 2019, 10:37 PM · Transactions
epriestley renamed T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes from There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changs to There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
May 30 2019, 7:09 PM · Transactions
epriestley created T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
May 30 2019, 7:09 PM · Transactions

May 23 2019

epriestley triaged T13295: Clean up magic / passthrough request parameters as Low priority.
May 23 2019, 6:34 PM · Transactions

May 22 2019

epriestley added a comment to T13294: Provide a transaction-level view of feed.

Per D20533, the major query this UI uses is currently unkeyed (no dateCreated key on transaction tables).

May 22 2019, 3:44 PM · Feed, Transactions

May 21 2019

epriestley added a revision to T13294: Provide a transaction-level view of feed: D20535: Support export of feed transactions to CSV/Excel/etc.
May 21 2019, 1:06 PM · Feed, Transactions
epriestley added a revision to T13294: Provide a transaction-level view of feed: D20533: Add support for querying feed transactions by author and date range.
May 21 2019, 12:25 PM · Feed, Transactions

May 20 2019

epriestley added a revision to T13294: Provide a transaction-level view of feed: D20531: Build a rough transaction-level view of Feed.
May 20 2019, 9:23 PM · Feed, Transactions
epriestley triaged T13294: Provide a transaction-level view of feed as Normal priority.
May 20 2019, 1:03 PM · Feed, Transactions

May 9 2019

epriestley closed T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository as Resolved.

My expectation is that this is effectively resolved by T13277. Since "Autoclose" is no longer a separate permission from "Publish", commits should now always mention + close or never mention + close.

May 9 2019, 5:05 PM · Transactions, Diffusion

Apr 22 2019

epriestley renamed T8370: Index "TODO" comments and other references present in source code from Allow mentions in commit contents to Index "TODO" comments and other references present in source code.
Apr 22 2019, 6:06 PM · Transactions, Diffusion

Apr 15 2019

epriestley moved T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository from Backlog to "Track Only" on the Diffusion board.
Apr 15 2019, 3:39 PM · Transactions, Diffusion

Feb 26 2019

20after4 added a comment to T13255: transaction.search should accept user PHIDs as constraints.

quack

Feb 26 2019, 3:57 PM · Conduit, Transactions

Feb 25 2019

epriestley closed T13255: transaction.search should accept user PHIDs as constraints as Resolved.
  • D20208 adds an authorPHIDs constraint.
  • D20209 provides details for transactions which add or remove projects. See above for format and rationale, or just query something and see what pops out.
  • D20211 makes the documentation less bare-bones.
Feb 25 2019, 7:08 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: D20211: Expand documentation for "transaction.search".
Feb 25 2019, 3:26 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: D20209: Enrich the "change project tags" transaction in "transaction.search".
Feb 25 2019, 1:35 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

Currently, project tag changes and subscriber changes don't expose data in "transaction.search" because there's no "obviously correct" way to represent these changes in a future-proof way.

Feb 25 2019, 1:27 PM · Conduit, Transactions
epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

To my surprise, it also seems the method does not output any project tag changes that happened on a task?

Feb 25 2019, 1:24 PM · Conduit, Transactions
epriestley added a revision to T13255: transaction.search should accept user PHIDs as constraints: D20208: Support an "authorPHIDs" constraint for "transaction.search".
Feb 25 2019, 1:02 PM · Conduit, Transactions

Feb 24 2019

aklapper added a comment to T13255: transaction.search should accept user PHIDs as constraints.

Thanks for the quick reply!
Haven't played with webhooks yet so I did not know/realize it's transaction PHIDs only - "PHID" sounded generic enough that I incorrectly expected any kinds of PHIDs to be accepted as input. So this task is somewhere between either "clarify documentation that only transaction PHIDs are supported" or a "support other PHIDs" low-prio enhancement request.

Feb 24 2019, 2:13 PM · Conduit, Transactions

Feb 23 2019

epriestley added a comment to T13255: transaction.search should accept user PHIDs as constraints.

The phids constraints matches transactions with specific PHIDs (PHID-XACT-...). Usually, you'll have a list of transaction PHIDs when you're responding to a webhook callback, so the phids constraint is most useful for webhooks.

Feb 23 2019, 1:15 PM · Conduit, Transactions
aklapper triaged T13255: transaction.search should accept user PHIDs as constraints as Wishlist priority.
Feb 23 2019, 5:14 AM · Conduit, Transactions

Feb 20 2019

epriestley closed T12746: Add support for PHUIPinboardItemView to timeline/transactions as Wontfix.

Probably a good idea, but not worth keeping a task around for.

Feb 20 2019, 11:33 PM · Maniphest, Macros, Transactions

Feb 15 2019

epriestley closed T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish as Resolved.

I believe we haven't seen more of this in two years, and "make the worker always exit in less than 2 hours" is a more-or-less reasonable remedy. Getting one extra email every two hours also isn't a huge problem even if we do get this wrong.

Feb 15 2019, 3:47 AM · Restricted Project, Daemons, Differential, Transactions

Jan 21 2019

epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

I believe D19969 has now fixed this, although I'm not entirely certain, since it was never reliably reproducible in production so there's no way to really test or verify it.

Jan 21 2019, 5:09 AM · Transactions, Mail
epriestley closed T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title as Resolved by committing rPafd2ace0dc9c: Apply inverse edge edits after committing primary object edits.
Jan 21 2019, 5:03 AM · Transactions, Mail

Jan 14 2019

epriestley added a revision to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title: D19969: Apply inverse edge edits after committing primary object edits.
Jan 14 2019, 9:03 PM · Transactions, Mail
epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

This isn't trivial to resolve. The inverse transaction goes through standard "old value / new value" logic, so if we just move the entire "apply inverse transactions" block to later on, the transactions automatically no-op themselves: they do nothing by the time we apply them.

Jan 14 2019, 8:31 PM · Transactions, Mail
epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

I made this edit:

Jan 14 2019, 8:08 PM · Transactions, Mail
epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

Unsurprisingly, I think this is a race condition.

Jan 14 2019, 8:05 PM · Transactions, Mail

Jan 2 2019

epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

This is the most upsetting bug in the software.

Jan 2 2019, 5:13 PM · Transactions, Mail
epriestley moved T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title from Backlog to Soon? on the Mail board.
Jan 2 2019, 5:12 PM · Transactions, Mail

Nov 21 2018

joshuaspence added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

I do have a real-life example where the prose diff engine rendered a suboptimal diff. I was able to fix it by changing the maximum length of the edit distance matrix from 128 to 256.

Nov 21 2018, 5:44 AM · Prioritized, Transactions