Paths

Table of Contentst

Differential D20605

Fix two "msort()" vs "msortv()" issues in "arc land"
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:41 PM.

Tags

None

Referenced Files

	F15478508: D20605.id49150.diff
	Tue, Apr 8, 12:20 AM

	F15471320: D20605.id.diff
	Sat, Apr 5, 4:31 AM

	F15469555: D20605.diff
	Fri, Apr 4, 2:33 PM

	F15468859: D20605.diff
	Fri, Apr 4, 6:58 AM

	F15426568: D20605.id49150.diff
	Sun, Mar 23, 9:40 AM

	F15384435: D20605.id49141.diff
	Fri, Mar 14, 7:53 PM

	F15370758: D20605.diff
	Wed, Mar 12, 9:51 AM

	F15283894: D20605.diff
	Mar 4 2025, 8:49 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes

Commits

rARCd92fa96366c0: Fix two "msort()" vs "msortv()" issues in "arc land"

Summary

See https://github.com/phacility/arcanist/pull/242. Ref T13303. A little more fallout turned up in arc.

Test Plan

grep msort(

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 9:41 PM

Harbormaster completed remote builds in B23013: Diff 49141.Jun 20 2019, 9:41 PM

epriestley requested review of this revision.Jun 20 2019, 9:41 PM

amckinley accepted this revision.Jun 20 2019, 10:10 PM

This revision is now accepted and ready to land.Jun 20 2019, 10:10 PM

Closed by commit rARCd92fa96366c0: Fix two "msort()" vs "msortv()" issues in "arc land" (authored by epriestley). · Explain WhyJun 20 2019, 11:07 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCd92fa96366c0: Fix two "msort()" vs "msortv()" issues in "arc land".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLandWorkflow.php

4 lines

Diff 49150

View Options

src/workflow/ArcanistLandWorkflow.php

Fix two "msort()" vs "msortv()" issues in "arc land"ClosedPublicActions