Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
F13996352: D20611.id49158.diff
Wed, Oct 23, 8:22 PM
F13993404: D20611.id.diff
Tue, Oct 22, 10:37 PM
F13982780: D20611.id49157.diff
Sun, Oct 20, 1:57 AM
F13979126: D20611.diff
Sat, Oct 19, 2:48 AM
Unknown Object (File)
Sep 30 2024, 1:46 PM
Unknown Object (File)
Sep 9 2024, 2:58 AM
Unknown Object (File)
Sep 6 2024, 6:31 AM
Unknown Object (File)
Sep 1 2024, 1:21 PM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable