Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
F22588373: D20611.id.diff
Mon, Sep 28, 3:28 AM
Unknown Object (File)
Sat, Sep 12, 11:29 AM
Unknown Object (File)
Aug 17 2026, 9:01 PM
Unknown Object (File)
Jul 30 2026, 12:01 AM
Unknown Object (File)
Jul 2 2026, 1:45 PM
Unknown Object (File)
Jul 1 2026, 1:17 AM
Unknown Object (File)
Jun 29 2026, 10:14 PM
Unknown Object (File)
Jun 28 2026, 12:36 AM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable