Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
F18985144: D20611.id.diff
Nov 17 2025, 12:54 PM
F18897346: D20611.diff
Nov 7 2025, 5:05 PM
F18854731: D20611.diff
Nov 1 2025, 12:30 AM
F18850646: D20611.id49157.diff
Oct 30 2025, 6:27 PM
F18825625: D20611.id.diff
Oct 23 2025, 11:05 PM
F18769474: D20611.id.diff
Oct 8 2025, 7:44 AM
F18766482: D20611.diff
Oct 7 2025, 4:55 PM
F18754493: D20611.id49158.diff
Oct 4 2025, 11:17 PM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable