Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 10 2025, 5:00 AM
Unknown Object (File)
Apr 29 2025, 5:28 PM
Unknown Object (File)
Apr 15 2025, 8:51 PM
Unknown Object (File)
Apr 1 2025, 12:19 AM
Unknown Object (File)
Mar 30 2025, 9:28 PM
Unknown Object (File)
Mar 29 2025, 9:24 AM
Unknown Object (File)
Mar 28 2025, 6:53 PM
Unknown Object (File)
Mar 12 2025, 2:33 AM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable