Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function

Authored by epriestley on Jun 22 2019, 4:03 PM.



Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

rPHU libphutil
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 22 2019, 4:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2019, 4:04 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.