Page MenuHomePhabricator

Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
ClosedPublic

Authored by epriestley on Jun 22 2019, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 2, 1:45 PM
Unknown Object (File)
Wed, Jul 1, 1:17 AM
Unknown Object (File)
Mon, Jun 29, 10:14 PM
Unknown Object (File)
Jun 28 2026, 12:36 AM
Unknown Object (File)
Jun 12 2026, 12:53 PM
Unknown Object (File)
Jun 11 2026, 9:50 PM
Unknown Object (File)
Jun 11 2026, 8:27 PM
Unknown Object (File)
Jun 3 2026, 7:30 PM
Subscribers
None

Details

Summary

Ref T13303. I didn't find any explicit "msortv()" issues in instances/, but did catch one during deploy where we run a ClassMapQuery with a vector-returning sort method.

Test if the sort method returns vectors and "msortv()" it if it does.

Test Plan

Will cherry-pick and redeploy, just throwing this up for reference/context.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable