Page MenuHomePhabricator

Resolve deleted packages properly as having no mailable members
ClosedPublic

Authored by epriestley on Wed, Jul 21, 9:22 PM.

Details

Summary

Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.

Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.

Test Plan
  • Added a package to a revision as a reviewer.
  • Destroyed the package.
  • Commented on the revision.
  • Processed the publishing worker with bin/worker execute.
  • Before: fatal after expanding the destroyed package.
  • After: clean publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 21, 9:50 PM
This revision was automatically updated to reflect the committed changes.