Page MenuHomePhabricator

Resolve deleted packages properly as having no mailable members
ClosedPublic

Authored by epriestley on Jul 21 2021, 9:22 PM.
Tags
None
Referenced Files
F11519396: D21707.diff
Thu, Feb 2, 8:35 AM
Unknown Object (File)
Sat, Jan 28, 4:19 PM
Unknown Object (File)
Tue, Jan 24, 3:03 PM
Unknown Object (File)
Mon, Jan 23, 4:55 PM
Unknown Object (File)
Thu, Jan 19, 12:49 PM
Unknown Object (File)
Wed, Jan 11, 7:18 AM
Unknown Object (File)
Wed, Jan 11, 7:18 AM
Unknown Object (File)
Wed, Jan 11, 7:18 AM
Subscribers
None

Details

Summary

Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.

Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.

Test Plan
  • Added a package to a revision as a reviewer.
  • Destroyed the package.
  • Commented on the revision.
  • Processed the publishing worker with bin/worker execute.
  • Before: fatal after expanding the destroyed package.
  • After: clean publish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:50 PM
This revision was automatically updated to reflect the committed changes.