Page MenuHomePhabricator

Update the arc-hg.py extension to work with mercurial 6.4
ClosedPublic

Authored by cspeckmim on Mar 31 2023, 3:17 AM.
Tags
None
Referenced Files
F13336920: D21859.diff
Wed, Jun 19, 8:32 AM
F13326657: D21859.diff
Sat, Jun 15, 8:12 AM
F13296319: D21859.diff
Thu, Jun 6, 2:19 PM
F13283598: D21859.diff
Sun, Jun 2, 3:59 PM
F13270503: D21859.id52100.diff
Wed, May 29, 9:49 AM
F13270502: D21859.id52099.diff
Wed, May 29, 9:49 AM
F13270500: D21859.id.diff
Wed, May 29, 9:49 AM
F13245397: D21859.diff
May 23 2024, 5:59 AM
Subscribers

Details

Summary

Mercurial 6.4 was recently released and showing up in package managers. With
the update to 6.4 using arc land would result in an exception indicating that
expandpath function does not exist.

The ui.expandpath function was deprecated in 5.8 and now removed in 6.4. The
functionality has been moved to utils.urlutil.get_ functions (they are split
between getting pull, push, and clone paths).

This updates the script to try utils.urlutil.get_clone_path function if the
ui.expandpath function is not present.

Test Plan

I updated my latest mercurial install to 6.4 and verified with hg --version.

I created a diff in a mercurial repo and used arc land to successfully land
the revision without any exceptions.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 31 2023, 1:25 PM

I also cherry-picked this to stable, since I don't have any specific plans around when I'm going to cut the next release right now.

Thank you it’s very appreciated!