HomePhabricator

Correct a PHP8 compatibility issue when running "arc diff" with no active branch

Description

Correct a PHP8 compatibility issue when running "arc diff" with no active branch

Summary: Ref T13588. See PHI2228. When there is no active branch name (for example, because you are in Git on a detached HEAD), this section currently fails under PHP8 when we try to strlen(null).

Test Plan: Under PHP 8.1: ran git checkout <hash of head>, then arc diff to generate this revision.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21856

Details

Provenance
epriestleyAuthored on Feb 4 2023, 1:01 PM
epriestleyPushed on Feb 4 2023, 1:16 PM
Differential Revision
D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch
Parents
rARC85c953ebe4a6: Fix a PHP 8.1 repository marker issue in Mercurial
Branches
Unknown
Tags
Unknown
Tasks
T13588: PHP 8 Compatibility