Page MenuHomePhabricator
Differential D21870

Address some PHP8 incompatibilities - Arcanist
ClosedPublic
Actions

Authored by cspeckmim on May 29 2023, 11:40 PM.
Tags
None
Referenced Files
F15460464: D21870.diff
Mon, Mar 31, 11:07 PM
F15459525: D21870.id52172.diff
Mon, Mar 31, 1:46 PM
F15449646: D21870.id52177.diff
Fri, Mar 28, 11:27 AM
F15449639: D21870.id52172.diff
Fri, Mar 28, 11:25 AM
F15449634: D21870.id52166.diff
Fri, Mar 28, 11:22 AM
F15449628: D21870.id.diff
Fri, Mar 28, 11:21 AM
F15438953: D21870.diff
Wed, Mar 26, 4:54 AM
F15425886: D21870.id52166.diff
Sun, Mar 23, 6:32 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist
Summary

Found a few more issues while playing around with arc.

Refs T13588

Test Plan
  • Run arc look and variants with subcommands
  • Run arc diff while not on a git branch

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cspeckmim created this revision.May 29 2023, 11:40 PM
cspeckmim held this revision as a draft.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2023, 11:40 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B25825: Diff 52166.May 29 2023, 11:40 PM
cspeckmim updated this revision to Diff 52172.May 30 2023, 3:22 PM

Update version check for Cppcheck to include optional bugfix version

Harbormaster completed remote builds in B25831: Diff 52172.May 30 2023, 3:22 PM
cspeckmim edited the summary of this revision. (Show Details)May 30 2023, 3:34 PM
cspeckmim added a task: T13588: PHP 8 Compatibility.
cspeckmim published this revision for review.May 30 2023, 4:26 PM

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

epriestley accepted this revision.May 30 2023, 4:29 PM
This revision is now accepted and ready to land.May 30 2023, 4:29 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 30 2023, 4:29 PM
This revision was landed with ongoing or failed builds.May 30 2023, 4:39 PM
Closed by commit rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist (authored by cspeckmim). · Explain Why
This revision was automatically updated to reflect the committed changes.
cspeckmim added a commit: rARCe50d1bc4eaba: Address some PHP8 incompatibilities - Arcanist.

Revision Contents
Changeset List

PathSize
src/
browse/
query/
2 lines
lint/
linter/
2 lines
10 lines
ref/
10 lines
repository/
api/
2 lines
workflow/
4 lines

Diff 52177

View Options

src/browse/query/ArcanistBrowseObjectNameURIHardpointQuery.php

Loading...
View Options

src/lint/linter/ArcanistCppcheckLinter.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/ref/ArcanistRefView.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility