Page MenuHomePhabricator

Address some PHP8 incompatibilities - Arcanist

Authored by cspeckmim on May 29 2023, 11:40 PM.
Referenced Files
F12198460: D21870.diff
Fri, Sep 29, 1:57 PM
F12194196: D21870.id52166.diff
Sun, Sep 24, 5:45 PM
F12193918: D21870.diff
Sun, Sep 24, 7:01 AM
F12193038: D21870.diff
Sat, Sep 23, 9:06 AM
F12192751: D21870.diff
Sat, Sep 23, 3:05 AM
F12191203: D21870.diff
Thu, Sep 21, 11:10 PM
F12186937: D21870.id52177.diff
Sun, Sep 17, 4:36 AM
F12183012: D21870.diff
Thu, Sep 14, 2:32 AM



Found a few more issues while playing around with arc.

Refs T13588

Test Plan
  • Run arc look and variants with subcommands
  • Run arc diff while not on a git branch

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

cspeckmim held this revision as a draft.

Update version check for Cppcheck to include optional bugfix version

Looking at the rest of the UT failures I think those are due to updated/newer versions of linters emitting slightly different results.

This revision is now accepted and ready to land.May 30 2023, 4:29 PM
This revision was landed with ongoing or failed builds.May 30 2023, 4:39 PM
This revision was automatically updated to reflect the committed changes.