HomePhabricator

Correct Aphlict websocket URI construction after PHP8 compatibility changes

Description

Correct Aphlict websocket URI construction after PHP8 compatibility changes

Summary:
See D21862. Ref T13700. D21862 affected notification server URI generation behavior when a notification server client is configured with:

  1. no "path" argument; and
  2. "cluster.instance" not set.

Condition (1) is not true default, and condition (2) is not true in my local environment, so it was easy for this to slip through the cracks. Apply the change suggested in D21862.

Also fix a couple other string-null issues I caught locally.

Test Plan: Generated notification server URIs under various simulated local conditions (no instance, path set) and everything seemed to be working correctly.

Maniphest Tasks: T13700

Differential Revision: https://secure.phabricator.com/D21875

Details

Provenance
epriestleyAuthored on Nov 13 2023, 6:53 PM
epriestleyPushed on Nov 13 2023, 7:04 PM
Differential Revision
D21875: Correct Aphlict websocket URI construction after PHP8 compatibility changes
Parents
rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous
Branches
Unknown
Tags
Unknown
References
HEAD -> master
Tasks
T13700: Notes to Self, Late 2023