Page MenuHomePhabricator

Correct a PHP8 compatibility issue when running "arc diff" with no active branch
ClosedPublic

Authored by epriestley on Feb 4 2023, 1:03 PM.
Tags
None
Referenced Files
F13262496: D21856.diff
Mon, May 27, 2:11 AM
F13256872: D21856.id.diff
Sat, May 25, 6:42 PM
F13245594: D21856.diff
Thu, May 23, 6:07 AM
F13236124: D21856.id52092.diff
Tue, May 21, 8:16 AM
F13223668: D21856.diff
Sun, May 19, 4:46 AM
F13205686: D21856.diff
Wed, May 15, 2:17 AM
F13198348: D21856.diff
Mon, May 13, 5:52 AM
F13189690: D21856.diff
Sat, May 11, 6:17 AM
Subscribers
None

Details

Summary

Ref T13588. See PHI2228. When there is no active branch name (for example, because you are in Git on a detached HEAD), this section currently fails under PHP8 when we try to strlen(null).

Test Plan

Under PHP 8.1: ran git checkout <hash of head>, then arc diff to generate this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2023, 1:16 PM
This revision was automatically updated to reflect the committed changes.