Page MenuHomePhabricator
Differential D21869

Addressing PHP8 incompatibilities - Miscellaneous
ClosedPublic
Actions

Authored by cspeckmim on May 29 2023, 11:38 PM.
Tags
None
Referenced Files
F13101362: D21869.diff
Fri, Apr 26, 11:31 PM
Unknown Object (File)
Thu, Apr 25, 7:35 AM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Tue, Apr 23, 5:26 PM
Unknown Object (File)
Tue, Apr 23, 5:26 PM
Unknown Object (File)
Tue, Apr 23, 5:26 PM
Unknown Object (File)
Tue, Apr 23, 5:26 PM
Unknown Object (File)
Tue, Apr 23, 1:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous
Summary

More perusing through Phabricator to find and address incompatibilities.

Refs T13588

Test Plan
  • Creating macros, changing their text.
  • Upload to use existing SSH key instead of generate one.
  • Modify alt text of an uploaded file.
  • Create phame post
  • Delete phriction document
  • Move tasks around on workboard, assign story points
  • Generate Diviner docs
  • Bulk modify tasks

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cspeckmim created this revision.May 29 2023, 11:38 PM
cspeckmim held this revision as a draft.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2023, 11:38 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B25824: Diff 52165.May 29 2023, 11:38 PM
cspeckmim updated this revision to Diff 52167.May 29 2023, 11:48 PM

Minor tidying

Harbormaster completed remote builds in B25826: Diff 52167.May 29 2023, 11:48 PM
cspeckmim published this revision for review.May 29 2023, 11:56 PM
epriestley accepted this revision.May 30 2023, 2:34 PM

One actual logical issue inline.

scripts/repository/commit_hook.php
122

This incorrectly prevents use of the common and desirable username "0".

(A user with this wholly reasonable username has a registered account on this server and has contributed to Phabricator in the past.)

This revision is now accepted and ready to land.May 30 2023, 2:34 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 30 2023, 2:34 PM
cspeckmim added inline comments.May 30 2023, 3:19 PM
scripts/repository/commit_hook.php
122

👀

cspeckmim planned changes to this revision.May 30 2023, 3:19 PM
cspeckmim updated this revision to Diff 52171.May 30 2023, 3:21 PM

Correct the check for an empty username

This revision is now accepted and ready to land.May 30 2023, 3:21 PM
Harbormaster completed remote builds in B25830: Diff 52171.May 30 2023, 3:21 PM
cspeckmim edited the summary of this revision. (Show Details)May 30 2023, 3:34 PM
cspeckmim added a task: T13588: PHP 8 Compatibility.
Closed by commit rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous (authored by cspeckmim). · Explain WhyMay 30 2023, 4:06 PM
This revision was automatically updated to reflect the committed changes.
cspeckmim added a commit: rP40b272fa51ea: Addressing PHP8 incompatibilities - Miscellaneous.

Revision Contents
Changeset List

PathSize
scripts/
repository/
8 lines
ssh/
4 lines
src/
aphront/
response/
2 lines
applications/
auth/
controller/
4 lines
conduit/
controller/
4 lines
diviner/
atom/
13 lines
storage/
2 lines
workflow/
2 lines
files/
xaction/
8 lines
herald/
typeahead/
14 lines
macro/
engine/
9 lines
maniphest/
xaction/
2 lines
metamta/
controller/
2 lines
management/
2 lines
owners/
typeahead/
18 lines
people/
mail/
2 lines
4 lines
phame/
controller/
2 lines
storage/
3 lines
phriction/
editor/
4 lines
project/
controller/
4 lines
state/
9 lines
typeahead/
9 lines
repository/
storage/
3 lines
search/
controller/
2 lines
settings/
panel/
7 lines
transactions/
bulk/
2 lines
infrastructure/
log/
2 lines
support/
startup/
2 lines

Diff 52176

View Options

scripts/repository/commit_hook.php

Loading...
View Options

scripts/ssh/ssh-exec.php

Loading...
View Options

src/aphront/response/AphrontAjaxResponse.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
View Options

src/applications/diviner/atom/DivinerAtom.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
View Options

src/applications/files/xaction/PhabricatorFileAltTextTransaction.php

Loading...
View Options

src/applications/herald/typeahead/HeraldRuleDatasource.php

Loading...
View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

Loading...
View Options

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Loading...
View Options

src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
View Options

src/applications/people/mail/PhabricatorPeopleEmailLoginMailEngine.php

Loading...
View Options

src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php

Loading...
View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMoveController.php

Loading...
View Options

src/applications/project/state/PhabricatorWorkboardViewState.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Loading...
View Options

src/applications/transactions/bulk/PhabricatorBulkEngine.php

Loading...
View Options

src/infrastructure/log/PhabricatorSSHLog.php

Loading...
View Options

support/startup/preamble-utils.php

Loading...
Phabricator · Built by Phacility