Page MenuHomePhabricator

Addressing PHP8 incompatibilities - Miscellaneous
ClosedPublic

Authored by cspeckmim on May 29 2023, 11:38 PM.
Tags
None
Referenced Files
F17877798: D21869.diff
Mon, Jul 28, 7:53 PM
F17868711: D21869.id52171.diff
Mon, Jul 28, 8:53 AM
F17868656: D21869.id52165.diff
Mon, Jul 28, 8:14 AM
F17845341: D21869.diff
Sun, Jul 27, 3:20 AM
F17674402: D21869.diff
Sun, Jul 13, 7:16 AM
F17657491: D21869.diff
Sat, Jul 12, 12:18 PM
Unknown Object (File)
Jun 17 2025, 8:14 PM
Unknown Object (File)
Jun 17 2025, 8:14 PM
Subscribers

Details

Summary

More perusing through Phabricator to find and address incompatibilities.

Refs T13588

Test Plan
  • Creating macros, changing their text.
  • Upload to use existing SSH key instead of generate one.
  • Modify alt text of an uploaded file.
  • Create phame post
  • Delete phriction document
  • Move tasks around on workboard, assign story points
  • Generate Diviner docs
  • Bulk modify tasks

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cspeckmim held this revision as a draft.

One actual logical issue inline.

scripts/repository/commit_hook.php
122

This incorrectly prevents use of the common and desirable username "0".

(A user with this wholly reasonable username has a registered account on this server and has contributed to Phabricator in the past.)

This revision is now accepted and ready to land.May 30 2023, 2:34 PM
scripts/repository/commit_hook.php
122

👀

Correct the check for an empty username

This revision is now accepted and ready to land.May 30 2023, 3:21 PM