Remove Facebook OAuth dependency on "security_settings" property
be0bb68f6536
Actions

Description

Remove Facebook OAuth dependency on "security_settings" property

Summary: Ref T13615. This property was removed from the Facebook API at some point, perhaps November 2020. Stop relying no it.

Test Plan: Created a local Facebook OAuth app, registered a new account locally.

Maniphest Tasks: T13615

Differential Revision: https://secure.phabricator.com/D21571

Details

Provenance

epriestley	Authored on Feb 19 2021, 6:24 PM
epriestley	Pushed on Feb 19 2021, 6:27 PM

Differential Revision

D21571: Remove Facebook OAuth dependency on "security_settings" property

Parents

rPb3976acc40a6: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php"

Branches

Unknown

Tags

Unknown

Tasks

T13615: Facebook OAuth adapter is failing with "security_settings" error

Build Status

Buildable 25155
Build 34719: Run Core Tests

Event Timeline

epriestley committed rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property (authored by epriestley).Feb 19 2021, 6:27 PM

epriestley added a task: T13615: Facebook OAuth adapter is failing with "security_settings" error.

epriestley added an edge: D21571: Remove Facebook OAuth dependency on "security_settings" property.

Harbormaster completed building B25155: rPbe0bb68f6536: Remove Facebook OAuth dependency on "security_settings" property.Feb 19 2021, 6:32 PM

epriestley mentioned this in 2021 Week 8 (Late February).Feb 19 2021, 7:03 PM

Changes (2)

Path

Size

src/

applications/

auth/

adapter/

PhutilFacebookAuthAdapter.php

provider/

PhabricatorFacebookAuthProvider.php

rPbe0bb68f6536

View Options

src/applications/auth/adapter/PhutilFacebookAuthAdapter.php