Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:56 PM.

Tags

None

Referenced Files

	F18142795: D21568.id51340.diff
	Thu, Aug 14, 2:16 PM

	F18112730: D21568.id.diff
	Tue, Aug 12, 8:00 PM

	F18108903: D21568.diff
	Mon, Aug 11, 10:23 AM

	F18106499: D21568.diff
	Sun, Aug 10, 11:06 PM

	F17952975: D21568.id51339.diff
	Fri, Aug 1, 2:38 AM

	F17948669: D21568.id.diff
	Thu, Jul 31, 9:41 PM

	F17879331: D21568.diff
	Mon, Jul 28, 8:49 PM

	Unknown Object (File)
	May 10 2025, 11:17 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13608: Remarkup hyperlink pattern may backtrack explosively
Commits: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern

Summary

Ref T13608. Building on D21562, further anchor this pattern by adding a negative lookbehind.

Test Plan

Ran unit tests.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 18 2021, 7:56 PM

Harbormaster completed remote builds in B25148: Diff 51339.Feb 18 2021, 7:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 7:58 PM

epriestley requested review of this revision.

Closed by commit rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

markuprule/

PhutilRemarkupHyperlinkRule.php

13 lines

Diff 51340

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Add a negative lookbehind to the Remarkup "bare URI" regular expression patternClosedPublicActions