Page MenuHomePhabricator
Differential D21568

Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:56 PM.
Tags
None
Referenced Files
F19921081: D21568.id51340.diff
Mon, Apr 6, 1:57 AM
F19904201: D21568.id51339.diff
Tue, Mar 31, 7:50 AM
F19899690: D21568.id51339.diff
Sun, Mar 29, 10:43 PM
F19842149: D21568.id51339.diff
Mar 11 2026, 9:34 PM
F19815412: D21568.id51339.diff
Mar 4 2026, 8:47 PM
F19799841: D21568.id.diff
Feb 28 2026, 6:05 AM
F19725696: D21568.id.diff
Feb 13 2026, 4:22 PM
F19668160: D21568.id.diff
Feb 7 2026, 6:24 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13608: Remarkup hyperlink pattern may backtrack explosively
Commits
rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Summary

Ref T13608. Building on D21562, further anchor this pattern by adding a negative lookbehind.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 18 2021, 7:56 PM
Harbormaster completed remote builds in B25148: Diff 51339.Feb 18 2021, 7:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 7:58 PM
epriestley requested review of this revision.
Closed by commit rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
markup/
markuprule/
13 lines

Diff 51340

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Loading...
Phabricator · Built by Phacility