Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 7:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 4:57 PM

	Unknown Object (File)
	Mon, Nov 11, 2:40 AM

	Unknown Object (File)
	Sep 15 2024, 4:49 AM

	Unknown Object (File)
	Sep 6 2024, 8:42 AM

	Unknown Object (File)
	Aug 28 2024, 7:18 PM

	Unknown Object (File)
	Aug 28 2024, 5:22 AM

	Unknown Object (File)
	Aug 17 2024, 6:17 AM

	Unknown Object (File)
	Aug 14 2024, 5:07 AM

View All 76 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13608: Remarkup hyperlink pattern may backtrack explosively
Commits: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern

Summary

Ref T13608. Building on D21562, further anchor this pattern by adding a negative lookbehind.

Test Plan

Ran unit tests.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 18 2021, 7:56 PM

Harbormaster completed remote builds in B25148: Diff 51339.Feb 18 2021, 7:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 7:58 PM

epriestley requested review of this revision.

Closed by commit rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8cfd22c5fe88: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

markuprule/

PhutilRemarkupHyperlinkRule.php

13 lines

Diff 51340

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

Add a negative lookbehind to the Remarkup "bare URI" regular expression patternClosedPublicActions