Maniphest T12559

Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled")
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	Apr 15 2017, 11:20 AM

Tags

Referenced Files

None

Subscribers

Description

If a user is unapproved and disabled, they currently get a purple dot next to their names. They should get a grey dot instead.

Revisions and Commits

rP Phabricator
	D17806	rP89d0c8e388fb Use grey dots for disabled users, even if a user is also unverified

Related Objects

Mentioned Here: D17678: Use violet with not-verified user tags

Event Timeline

epriestley created this task.Apr 15 2017, 11:20 AM

Herald added a subscriber: eadler. · View Herald TranscriptApr 15 2017, 11:20 AM

Actually, I misread D17678, which just replaced the grey dot with a violet dot in all cases.

@chad, was this intended? I expected this:

Disabled user (verified or not): always grey.
Enabled but unverified user: purple.

not intentional

Behavior above sound right? I'll shoot you a diff...

epriestley added a revision: D17806: Use grey dots for disabled users, even if a user is also unverified.Apr 30 2017, 7:58 PM

epriestley closed this task as Resolved by committing rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified.Apr 30 2017, 8:10 PM

epriestley added a commit: rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified.