Page MenuHomePhabricator
Create Task
Maniphest T12559

Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled")
Closed, ResolvedPublic
Actions

Description

If a user is unapproved and disabled, they currently get a purple dot next to their names. They should get a grey dot instead.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley created this task.Apr 15 2017, 11:20 AM
Herald added a subscriber: eadler. · View Herald TranscriptApr 15 2017, 11:20 AM
epriestley added a comment.EditedApr 30 2017, 7:53 PM

Actually, I misread D17678, which just replaced the grey dot with a violet dot in all cases.

@chad, was this intended? I expected this:

  • Disabled user (verified or not): always grey.
  • Enabled but unverified user: purple.
chad added a comment.Apr 30 2017, 7:53 PM

not intentional

epriestley added a comment.Apr 30 2017, 7:53 PM

Behavior above sound right? I'll shoot you a diff...

epriestley added a revision: Restricted Differential Revision.Apr 30 2017, 7:58 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 30 2017, 8:10 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility