Page MenuHomePhabricator
Feed All Stories

Jan 23 2017

mpickering updated subscribers of T12145: Resource allocator does not create new host resources when one is already active.
Jan 23 2017, 9:54 AM · Bug Report, Drydock
mpickering created T12145: Resource allocator does not create new host resources when one is already active.
Jan 23 2017, 9:54 AM · Bug Report, Drydock
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

OK, it seems utcInstanceEpoch is only used in child event of recurring events according to the code. After I canceled the recurring event(E4), there is no more error in phd log.

Jan 23 2017, 7:35 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

I just created a simple test event and the utcInstanceEpoch column is still NULL. What does this column mean?

Jan 23 2017, 7:27 AM · Calendar, Bug Report (Needs Information)
RuralHunter updated subscribers of T12130: DateTime parsing error in phd log.
Jan 23 2017, 7:12 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a project to T12130: DateTime parsing error in phd log: Calendar.

just FYI, I checked the database and found the utcInstanceEpoch is NULL for some old events, which maybe caused by bug in data migration during upgrade.

Jan 23 2017, 7:11 AM · Calendar, Bug Report (Needs Information)
chad removed a project from T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded: Phacility.
Jan 23 2017, 2:15 AM · Inline Comments, Customer Impact, Differential
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

T11036 will probably be the next round of changes, but I don't think we have this stuff on any immediate roadmap.

Jan 23 2017, 1:24 AM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

I think it's not perfectly clear in the UI, but we do have it documented:

Jan 23 2017, 1:19 AM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

That's up to you and your team.

Jan 23 2017, 1:17 AM · Projects, Feature Request
joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.
In T12144#208351, @chad wrote:

I'd rather fix the core problem if it's an unclear typeahead.

Jan 23 2017, 1:16 AM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

I'd rather fix the core problem if it's an unclear typeahead.

Jan 23 2017, 1:12 AM · Projects, Feature Request

Jan 22 2017

joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.

My understanding is that subprojects are basically just regular projects but with a parent relationship. We didn't want these projects to pollute the projects typeahead because no-one should be creating tasks within these subprojects (given that these subprojects dictate what we are working on). By choosing "milestone" instead of "subproject", it becomes clearer in the project typeahead that the subproject is internal to the parent project. That is, if we made #our_january_goal a subproject then it would show up in the projects typeahead as "Our January Goal" whereas as a milestone it is rendered as "Our Team (Our January Goal)".

Jan 22 2017, 11:45 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

If the milestones aren't strictly ordered, why did the user create milestones instead of subprojects?

Jan 22 2017, 11:31 PM · Projects, Feature Request
joshuaspence created T12144: Ability to reorder milestones on a project's workboard.
Jan 22 2017, 11:10 PM · Projects, Feature Request
vpetersson added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

Awesome guys. I can confirm that this resolved the issue.

Jan 22 2017, 10:05 PM · Bug Report
rabahmeradi added a comment to T12141: Cannot access phabricator when wrong email entered at account creation.

I think you can unlock yourself using the cli

Jan 22 2017, 9:08 PM · Bug Report
dmgarcia awarded T12101: Phabricator PHP 7 Compatibility a Yellow Medal token.
Jan 22 2017, 7:35 PM · Infrastructure, Guides
chad awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:26 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

I deployed this to the Phacility production cluster.

Jan 22 2017, 7:03 PM · Bug Report
epriestley merged T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley merged task T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

I'm going to merge this into T12142 since that one has an earlier timestamp even though this one is more pure of heart.

Jan 22 2017, 7:01 PM · Bug Report
janitorial added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.
In T12143#208308, @chad wrote:

This is fixed on master and stable but hasn't rolled out to Phacility yet.

Jan 22 2017, 6:58 PM · Bug Report
chad added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

For the record, this is like the best, clearest bug report I've seen in months. :D

Jan 22 2017, 6:48 PM · Bug Report
chad added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

Are you filing this as a Phacility customer?

Jan 22 2017, 6:39 PM · Bug Report
chad added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

This is fixed on master and stable but hasn't rolled out to Phacility yet.

Jan 22 2017, 6:37 PM · Bug Report
janitorial created T12143: "Create Workboard" action fails when "Make Default" checkbox checked.
Jan 22 2017, 6:30 PM · Bug Report
chad added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

Ok I cherry-picked it, way easier than I expected.

Jan 22 2017, 6:17 PM · Bug Report
chad updated subscribers of T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

I pushed this out to master and @epriestley will probably cherry-pick it to stable today.

Jan 22 2017, 4:43 PM · Bug Report
chad closed T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard as Resolved by committing Restricted Diffusion Commit.
Jan 22 2017, 4:42 PM · Bug Report
chad added a revision to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard: Unknown Object (Differential Revision).
Jan 22 2017, 4:38 PM · Bug Report
chad added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

Bisects back to D17235

Jan 22 2017, 3:58 PM · Bug Report
chad added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

Confirmed, we'll have a fix here shortly and probably cherry-pick to stable.

Jan 22 2017, 3:44 PM · Bug Report
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

Erm… I was just asking for time repository update on the repository you have already cloned, hence the 15 seconds. If I understand this correctly, you seem to indicate that it would still be too much. I'm having a hard time understanding, but if you're adamant about this, then there is nothing left to say :)

Jan 22 2017, 2:19 PM · Bug Report (Needs Information)
dereckson added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

I can repro on an instance upgraded at 20d1bb8fdf too. And indeed PhabricatorProjectWorkboardProfileMenuItem or PhabricatorProfileMenuItem classes don't contain a validateTransactions method.

Jan 22 2017, 11:12 AM · Bug Report
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

I added some log in src/applications/calendar/storage/PhabricatorCalendarEvent.php before line 728 like this:

if ($this->isChildEvent()) {
      $parent = $this->getParentEvent();
      error_log("utc string:".$this->getUTCInstanceEpoch(),3,"/tmp/phadebug.log");
      $instance_datetime = PhutilCalendarAbsoluteDateTime::newFromEpoch(
        $this->getUTCInstanceEpoch());
      $recurrence_id = $instance_datetime->getISO8601();
      $rrule = null;
    }

It indicates $this->getUTCInstanceEpoch() returns empty or null. Any help for this? And I guess it should be related to some recurring events.

Jan 22 2017, 9:20 AM · Calendar, Bug Report (Needs Information)
vpetersson created T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 8:57 AM · Bug Report
chad added a comment to T12130: DateTime parsing error in phd log.

If you do find a way to reproduce the bug, please reply back and we'll look into it.

Jan 22 2017, 4:36 AM · Calendar, Bug Report (Needs Information)
chad closed T12130: DateTime parsing error in phd log as Invalid.
Jan 22 2017, 1:42 AM · Calendar, Bug Report (Needs Information)
chad added a comment to T12130: DateTime parsing error in phd log.

We'd be happy to help you further under Phacility Consulting services. We unfortunately do not take bug reports without reproduction steps or against prototype applications (Calendar).

Jan 22 2017, 1:41 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

No idea, I guess this is something related to the Calendar events in my install as you mentioned. I'm wondering if there is some place in the code I can add some lines to log/debug the actual event and the date/time string which caused the error? I can edit the source and run it again.

Jan 22 2017, 1:34 AM · Calendar, Bug Report (Needs Information)
chad added a comment to T12130: DateTime parsing error in phd log.

Thanks! Do you know how we can reproduce the error locally?

Jan 22 2017, 1:30 AM · Calendar, Bug Report (Needs Information)
RuralHunter added a comment to T12130: DateTime parsing error in phd log.

I'm still seeing this in the latest code:
phabricator

c63ba8337ec7e7f021f17c972e9a2a751f6280e2 (Sat, Jan 21)

arcanist

9503b941cc02be637d967bb50cfb25f852e071e4 (Sat, Jan 7)

phutil

6d8f5a783ebe7993b78632091507f6d7d8cbc215 (Sat, Jan 21)
Jan 22 2017, 1:28 AM · Calendar, Bug Report (Needs Information)

Jan 21 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Maybe someday this will be easier; https://lists.w3.org/Archives/Public/www-style/2016Mar/0370.html

Jan 21 2017, 10:13 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I'll get back to you

Jan 21 2017, 7:50 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Well

Jan 21 2017, 7:50 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think the pros and cons are something like:

Jan 21 2017, 7:29 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

oh man these crack me up.

Jan 21 2017, 7:23 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (110×2 px, 68 KB)

Jan 21 2017, 7:20 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Haha, sorry I think this might be a good JS learning side project for me on the weekends if I have free time.

Jan 21 2017, 7:19 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think we should just use actual emoji for this, not sprite sheets?

Jan 21 2017, 7:07 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

tarnation

Jan 21 2017, 7:05 PM · Remarkup, PHUI
chad updated subscribers of T12139: Add a proper emoji picker to Remarkup bar.
In D17238#205025, @epriestley wrote:

Yep, go for it.

Jan 21 2017, 7:00 PM · Remarkup, PHUI
chad added a comment to T12141: Cannot access phabricator when wrong email entered at account creation.

If this is a bug report, please see Contributing Bug Reports and fill out all required information. If this is a feature request, please see Contributing Feature Requests. If you need support for your account here on secure, please just use General Chat or contact@phacility.com.

Jan 21 2017, 6:41 PM · Bug Report
Tempuz5 created T12141: Cannot access phabricator when wrong email entered at account creation.
Jan 21 2017, 6:24 PM · Bug Report
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I deployed that change here (secure.phabricator.com). I'll cherry-pick it and deploy it on admin in a little bit, if nothing catches on explosion fire.

Jan 21 2017, 4:54 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Haha, no worries. Uninstalling Home is pretty unusual.

Jan 21 2017, 4:49 PM · Phacility, Ops, Applications
chad added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

ugh. sorry

Jan 21 2017, 4:47 PM · Phacility, Ops, Applications
epriestley added a revision to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Unknown Object (Differential Revision).
Jan 21 2017, 4:32 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

After purging dead instances, db003 and db004 are each <25% utilized on their data volumes.

Jan 21 2017, 3:57 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Purging db001 brought primary volume down to 79.2%, which is technically below the 80% caution threshold. It doesn't need to be fixed immediately, but the pathway forward isn't terribly clear. Some options are:

Jan 21 2017, 3:44 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Instance service windows on db003 and db004 have synchronized and the shards are now purging.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The temporary directory storage pressure on repo016 has an unclear root cause (it's related to importing an SVN repository, but I haven't been able to pinpoint where the issue started). The issue no longer appears to be occurring so I'm going to stop digging until it happens again.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The storage pressure on db001 is primarily because an instance imported a large SVN repository with approximately 60M paths. The instance is a free instance with one user.

Jan 21 2017, 3:08 PM · Phacility, Ops, Applications
epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Phacility.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley renamed T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log from When Home is uninstalled, the user menu disappears to When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The db001, db003 and db004 shards have also hit 80% full on their primary volumes. I'm purging dead instances from db001 now. db003 and db004 have never been purged and need to have instance out-of-service dates synchronized first. This is currently underway for db004.

Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I'm going to move forward with the deploy since this shouldn't impact actual instances, the stuff in this menu isn't super-critical, and workarounds (albeit inconvenient ones) exist to access the items.

Jan 21 2017, 2:34 PM · Phacility, Ops, Applications
epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Applications.
Jan 21 2017, 2:33 PM · Phacility, Ops, Applications
epriestley created T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:30 PM · Phacility, Ops, Applications
epriestley edited the content of Changelog.
Jan 21 2017, 2:12 PM
epriestley created 2017 Week 3 (Late January).
Jan 21 2017, 2:12 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

And if I gave you a precise estimate you could be sneaky and just divide it by $1,500/hr to get the answer without paying for it!

Jan 21 2017, 1:59 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Obviously, we can't just hand out estimates for free. Converting units and multiplying numbers together takes away valuable time and resources we could be using to develop Phabricator.

Jan 21 2017, 1:53 PM · Bug Report (Needs Information)
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

What'd be the fee for that 1 second command and a 5 second copy/paste?

Jan 21 2017, 8:13 AM · Bug Report (Needs Information)
chad added a project to T12098: Create Revision from FavoritesMenuItem doesn't work: Profile Menu Item.
Jan 21 2017, 3:16 AM · Dashboards, Differential
chad awarded T12139: Add a proper emoji picker to Remarkup bar a Haypence token.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad updated the task description for T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad created T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:13 AM · Remarkup, PHUI
ftdysa added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

I'll make sure to update this task with full reproduction steps on Monday.

Jan 21 2017, 1:14 AM · Search, Customer Impact, Bug Report
cspeckmim added a comment to T11521: Request Review action should clear "accepted older" status.

I appreciate the details and pointers - we may look at a custom reject transaction and/or required action bucket. I just went digging here for related discussion to see if others may have run across similar scenarios.

If you miss a comment and then forget about a revision you authored for a while, it probably wasn't that critical?

I can investigate further what issues people are having with the current solutions - I'm not sure being critical is the concern but more-so there being a delay for the change to land/verify without it being clear who should be the next step (presumably from the dashboard/bucket?).

Jan 21 2017, 12:45 AM · Restricted Project, Differential, Bug Report

Jan 20 2017

epriestley added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:40 PM · Remarkup, Conpherence
chad added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:39 PM · Remarkup, Conpherence
epriestley created T12138: Send-on-Enter and Fullscreen Mode interact destructively.
Jan 20 2017, 11:36 PM · Remarkup, Conpherence
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to, see Consulting to move forward.

Jan 20 2017, 11:23 PM · Bug Report (Needs Information)
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

How do I reproduce unexpected results at the application level (for example, what's something I can search for that doesn't match but should match)?

Jan 20 2017, 11:18 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T11521: Request Review action should clear "accepted older" status.

Yes and no. So: maybe?

Jan 20 2017, 11:12 PM · Restricted Project, Differential, Bug Report
LeCoyote added a comment to T12129: Mercurial repository updates cause high CPU usage.

Could you at least give me the time output for the broken/test repository update on your test system, so that I have a baseline for comparison later? Thanks!

Jan 20 2017, 11:00 PM · Bug Report (Needs Information)
ftdysa created T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
Jan 20 2017, 10:56 PM · Search, Customer Impact, Bug Report
chad added a revision to T12136: What to do with "Application Counts" with MenuItem: Unknown Object (Differential Revision).
Jan 20 2017, 9:28 PM · Profile Menu Item
cspeckmim added a comment to T11521: Request Review action should clear "accepted older" status.

I want to resist adding additional actions here if they would be rarely used and reasonable workarounds already exist. After EditEngine (T11114), third-party extensions will also be able to provide supplemental actions.

Jan 20 2017, 9:24 PM · Restricted Project, Differential, Bug Report
johnny-bit added a comment to T12136: What to do with "Application Counts" with MenuItem.
In T12136#208145, @chad wrote:

I can vanish them now.

Jan 20 2017, 9:17 PM · Profile Menu Item
chad added a comment to T12136: What to do with "Application Counts" with MenuItem.

I can vanish them now.

Jan 20 2017, 9:02 PM · Profile Menu Item
chad added a comment to T11957: Add MenuEngine to Home.

Yeah I meant to clean that up too

Jan 20 2017, 7:38 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

While I've got you, how do you feel about a diff to:

Jan 20 2017, 7:34 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

(If there's pushback, maybe like a "one-time hacky copy your old global app settings into the menu script that we don't support" sort of thing? But I'd guess users won't feel like this is too painful since the new menu is a lot more flexible/powerful.)

Jan 20 2017, 7:31 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I think it would potentially be reasonable to not migrate, especially if you do another blog post like the Favorites one to ease migration pain. Global stuff is relatively recent and pretty easy to put back in place, and I think a gentle nudge to configure the menu to work well for your install isn't a bad thing.

Jan 20 2017, 7:29 PM · Profile Menu Item, Dashboards