OK, so just unfortunate timing then. Ignore the smell of smoke, there's no fire apparently. :)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Dec 10 2016
I turned on email verification if you previously made an account here and never verified it, you were probably prompted.
In T11989#203387, @epriestley wrote:If you are not an administrator and create a task with THE FAX SUPPORT NUMBER THAT SHALL NOT BE NAMED in the title or body, you will now be immediately logged out of all your sessions and your task will be quarantined.
Adding lints is on hold for now; I'm merging this into T10038 which discusses the issue.
You can implement your linter as an extension - Community Resources has some examples of external linters you can copy.
Unclear if I can globally style these consistently across all browsers / OSs. But no one complained about my select styles yet.
The bug seems to be with Chrome/Ubuntu, as it's inconsistent with their other platforms. Did you file a task in their upstream?
My approach would use gfortran, as a colleague and I wrote a tool to clean up our code and I used gfortran as a linter already:
Does it reproduce here as well? We don't take bug reports from that install from non-admins. It's a forked install and not up to date.
Chrome 54 / Ubuntu 14.04. Tabbing through the comment edit form fields looks like this (screenshots are from phabricator.wikimedia.org):
outline: 4px solid red;
yeehaw
Dec 9 2016
@tgr can we get confirmation on the browser, please?
@chad, it looks like we're just using the browser's default outline for buttons.
It's somewhat invisible in Chrome on Windows too (Behold my powers of image editing! And on a Windows machine too!):
Okay, it does look invisible in Firefox. Is Firefox the browser you're using?
I can't reproduce tab order differing from visual order, either.
I can't reproduce this:
isn't that outline provided by the browser?
I would remove the idea of a "global dashboard" as distinct from "top dashboard" -- we just look through both sections and pick the first dashboard we see, if any exist.
Top dashboard
Global dashboard
Default hardwire
Also, maybe a good way to start is to do this:
(I guess a bad argument for having hard-coded home is that you can uninstall Dashboards. We could make it a mandatory app, though.)
That is, if you delete all of the dashboards from the menu that's fine, you just get hard-coded home.
I think I just didn't fully understand your suggestions on making it simpler, since we still have to keep around a fake dashboard until they install a new one.
I think the short technical path forward is:
Well I'm planning to make you build everything so we can do whatever you want, pretty much.
I thought it was OK for us to test various revenue streams?
If you are not an administrator and create a task with THE FAX SUPPORT NUMBER THAT SHALL NOT BE NAMED in the title or body, you will now be immediately logged out of all your sessions and your task will be quarantined.
You can disable just the LINT_BAD_CHARSET function and still use the rest of TextLinter by adding the following to the .arclint file:
Sorry, had to drop the pup off at pup daycare.
The only real downside I see to this is that if there's no global dashboard installed, we may need to fake a menu item for the "NUX home / default-hard-coded-dashboard" thing, so users who add a personal dashboard can get back to it and so that mobile users can get to it. But that feels not-terribly-problematic to me?
To be clear, I don't care how the plumbing works, I just want the house to look / interact like the mock.
The solution that I think is most promising is this:
But I'm not suggesting it work any such way other than the mock presented.
I don't think there's any reason that model can't work, it just feels really weird/inconsistent to me and not necessary, since I don't think there's any real value in retaining "install dashboard" or having a single magic home dashboard.
I get the sense you have a prefered solution but are walking me down a different road.
Also, is Dashboards going to get a second action so you have this choice when viewing a dashboard?
I guess engineering wise I think "Home" is a wrapper for your default dashboard. You can move it in the menu, but it must always be there. What dashboard is tied to it is fluid from "Install as Home" in Dashboards
Okay, but I can end up with two different dashboard menu items which look the same, work the same, but are edited in completely different ways through entirely separate applications?
I assume it works like the "Manage" item on Projects. You can move it, but you can't hide it.
Also, if the user can't reorder, rename or remove Home, how do we figure out where it goes if they edit their menu and reorganize all the items (e.g., add three copies of their profile, all at the bottom of their favorites)?
Maybe add an edit pencil for Dashboard panelengine items in the menu if you're the owner.
If I install a custom personal dashboard, my personal dashboard becomes Home, replacing the existing "Home" link, and I can't get back to the global home?
If we retain "Install Dashboard", there are also two different ways to install a dashboard: to install a default dashboard, you go to Dashboards > blah blah > Install Dashboard. To install a second dashboard that you just want to be able to switch to, you go to "Customize Favorites > New Dashboard > ...". Seems potentially simpler to throw away "install dashboard" completely and just work like more like searches do.
If I install a custom personal dashboard, my personal dashboard becomes Home, replacing the existing "Home" link, and I can't get back to the global home?
Home is Home, as it stands today. I'm just making it an explicit link since we currently hide it. You can't remove it. Sorry, I feel like I'm bad at explaining this.
I think we now test everything we've seen except RocketLoader (which is hard to test and hasn't come up too much recently) and not serving .whatever paths (which we've only ever seen one instance of, and which is also somewhat hard to test). I'm going to consider this resolved for now until we see more issues.
That's similar but not directly related.
Thanks for pointing me in the right direction -- this was indeed pilot error. Switching to rewrite as stated in the install guide fixes the error.
(Since we no longer have labels, can users add labels if they want?)
So they can remove "Home" and have no way to return to the install's default dashboard, and everyone has their own personal copy of "Home"?
Home is Home, whether it's hardcoded or a dashboard. Maybe don't allow them to remove that? But I don't care if they remove the Profile Photo/Name panel or divider.
In all cases, we have no LABEL anymore
This is the view when you first log in.
Getting another instance of what looks to be a similar issue but for a different function, specifically
That's correct. I'm not sure what's going wrong. My guesses are the crazy stuff you might expect like:
If you have project "AAA" with milestone "BBB", which renders as "AAA (BBB)" in the UI:
Re-applied the scripts and all is well now. Once another SQL script comes into the stable branch I will run the upgrade again, something must still be off here. For reference, after a pull, daemon stop, etc. we are only running storage upgrade --force -- is this incorrect? Seems to be fine in our other instances, but for this one the scripts are being marked as applied, but they aren't.
Actually, I think the issue @jcox reported and the downstream issue (https://phabricator.wikimedia.org/T152726) may not quite be the same.
I'm going to close this as resolved because we now have a setup check for it and haven't seen any more Apache version issues since this report (more than two years).


