Page MenuHomePhabricator
Feed All Stories

Sep 13 2016

chad added a comment to T11628: It's not simple to join a Conpherence.

I think some interstitial or slick JS UI will solve most of my concerns for open/private groups. These settings are very difficult to understand as a new user. Conpherence itself is one of our "everyone in the org" products, and I think it would benefit from a clearer understanding of what it can do.

Sep 13 2016, 4:53 PM · Conpherence
polybuildr awarded T10362: Display comments in a Phabricator task as a tree view instead of quoted inline comments a Mountain of Wealth token.
Sep 13 2016, 4:35 PM · Restricted Project, Maniphest, Feature Request
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Even if everything else defaults to public, I don't think that's an especially strong argument on its own for copying that default. There are a lot of other cases where we diverge from common practice because we think there's a stronger case for a different default or behavior.

Sep 13 2016, 4:34 PM · Conpherence
chad updated the task description for T11628: It's not simple to join a Conpherence.
Sep 13 2016, 4:34 PM · Conpherence
chad added a comment to T11628: It's not simple to join a Conpherence.

HipChat:

Sep 13 2016, 4:33 PM · Conpherence
chad added a comment to T11628: It's not simple to join a Conpherence.

I would be fine even with some interstitial for Room creation, maybe? I don't think Room creation is high volume so the extra step seems ok.

Sep 13 2016, 4:25 PM · Conpherence
chad added a comment to T11628: It's not simple to join a Conpherence.

Mattermost:

Sep 13 2016, 4:24 PM · Conpherence
chad added a comment to T11628: It's not simple to join a Conpherence.

Slacks:

Sep 13 2016, 4:22 PM · Conpherence
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Sorry, we aren't interested in maintaining any version of this change in the upstream at this time.

Sep 13 2016, 4:21 PM · Restricted Project, Differential, Feature Request
chad added a comment to T11628: It's not simple to join a Conpherence.

I'd also argue the defaults are not aligned with how Phabricator works in general either. Every other object is open and nearly always anyone can edit, etc.

Sep 13 2016, 4:18 PM · Conpherence
epriestley added a comment to T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer).

D16465 has details on how to move forward here if anyone wants to steal it before @michaeljs1990 gets back to it.

Sep 13 2016, 4:14 PM · Contributor Onboarding, Paste, Bug Report
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Hmm, I guess I don't have the same experience -- the defaults are what I expect and the UI doesn't seem difficult to me (rough in places, but the basic flows are what I expect/want).

Sep 13 2016, 4:14 PM · Conpherence
chad added a comment to T11628: It's not simple to join a Conpherence.

As a user, I generally expect chat/messaging to be private by default (not "All Users").

Sep 13 2016, 4:12 PM · Conpherence
epriestley moved T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer) from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Contributor Onboarding, Paste, Bug Report
epriestley triaged T11629: Support "editor link" for repos without a callsign as Low priority.
Sep 13 2016, 4:12 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley moved T11629: Support "editor link" for repos without a callsign from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley moved T11632: Display invisible characters on erroneous user input from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Restricted Project, Contributor Onboarding
epriestley added a project to T11629: Support "editor link" for repos without a callsign: Contributor Onboarding.

This stuff is defined in PhabricatorUser->loadEditorLink(), which ain't great but probably not worth generalizing.

Sep 13 2016, 4:11 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Of the visible rooms I'm a member of, 14 out of 15 are private (the other one is General Chat).

Sep 13 2016, 4:04 PM · Conpherence
epriestley closed T11613: New install exception is wrong if preflight setup checks fail as Resolved.
Sep 13 2016, 3:47 PM · Bug Report (Needs Information), Setup
jcox closed T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs as Resolved by committing Restricted Diffusion Commit.
Sep 13 2016, 3:28 PM · Contributor Onboarding
jcox created T11632: Display invisible characters on erroneous user input.
Sep 13 2016, 3:24 PM · Restricted Project, Contributor Onboarding
dfumagalli awarded T11613: New install exception is wrong if preflight setup checks fail a Mountain of Wealth token.
Sep 13 2016, 2:29 PM · Bug Report (Needs Information), Setup
HuMMeL621 awarded F326734: 01EUROPE_-_The_Final_Countdown.mp3 a Love token.
Sep 13 2016, 9:11 AM
starruler added a comment to T11608: Make it easier to review stacks of diffs.

I'd like to tackle this change. From my investigation it doesn't look too difficult.

Sep 13 2016, 7:01 AM · Restricted Project, Differential, Feature Request
dfumagalli added a comment to T11613: New install exception is wrong if preflight setup checks fail.
In T11613#194396, @chad wrote:

Assuming probably you're seeing T10352

Yes, I have read that. Putting "END" solves the recursion but the issue about path being empty comes up as in that bug report.
Since the suggested diagnostic PHP snippet shows path being correctly handled by "END" (except for when we call the website root), a quick'n' dirty fix I have tried is to look at the code checking path <> "" and set path = '/' if empty instead of raising an exception.

Sep 13 2016, 4:33 AM · Bug Report (Needs Information), Setup
chad closed T11631: 登录失败 fail to login as Spite.

Nyancat

Sep 13 2016, 1:35 AM · Bug Report
• zh_open created T11631: 登录失败 fail to login.
Sep 13 2016, 1:27 AM · Bug Report

Sep 12 2016

avivey added a comment to T9530: Release Server / Workflow app / Future of Releeph .

One thing that happened locally wrt "Product Lines" and 40 apps:

  • RelMan wants to think about the 40 apps going out at the same time as a single thing, even if they have slightly different code changes.

For instance, they want to cut them all at the same time, and deploy them all to the staging environment/prod in one go, etc.
ATM, that means that we have a single Release with lots of repos in it, but that might one day grow into a "Meta-Release"/"Release Bag"/"Train", which is basically a collection of releases that are managed together.

Sep 12 2016, 11:51 PM · Restricted Project, Harbormaster
kylec awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Sep 12 2016, 11:43 PM · Arcanist
avivey awarded T11629: Support "editor link" for repos without a callsign a Like token.
Sep 12 2016, 11:22 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
chad closed T9112: Timestamp is not shown on mobile as Resolved by committing Restricted Diffusion Commit.
Sep 12 2016, 10:23 PM · Conpherence
chad closed T8972: Editing a room edits the previously selected one as Resolved by committing Restricted Diffusion Commit.
Sep 12 2016, 10:19 PM · Conpherence (v4)
epriestley closed T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action as Resolved by committing Restricted Diffusion Commit.
Sep 12 2016, 9:49 PM · Setup, Bug Report
chad added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

Generally, it's always cheaper for us to code checks defensively per our time. That lightens support which then allows for time for building features. We're just two developers here and we don't get a paycheck for our time or support we offer. Maybe someday :)

Sep 12 2016, 9:49 PM · Setup, Bug Report
epriestley edited the content of Changelog.
Sep 12 2016, 9:48 PM
epriestley created 2016 Week 37 (Early September).
Sep 12 2016, 9:48 PM
epriestley added a revision to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action: Unknown Object (Differential Revision).
Sep 12 2016, 9:45 PM · Setup, Bug Report
chad added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

Providing support isn't free.

Sep 12 2016, 9:42 PM · Setup, Bug Report
dfumagalli added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.
In T11627#194460, @chad wrote:

Features unfortunately aren't free. They cost time to build, test, and provide lifetime support of, that we must pay.

Sep 12 2016, 9:37 PM · Setup, Bug Report
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

Neither T11277 or T6706 are exactly about that, but I think the ultimate fix to those is likely a general refinement of SSH key metadata (source IP range restrictions, logging, specific permissions).

Sep 12 2016, 9:22 PM
yelirekim added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

The bash workflow is just loaded the same way all of the other ssh workflows are loaded, I think that the problem is one of security policy / segmentation.

Sep 12 2016, 9:13 PM
chad triaged T11630: file list once expanded cannot be shrunk back as Low priority.
Sep 12 2016, 9:05 PM · Differential, Bug Report
chad added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

Features unfortunately aren't free. They cost time to build, test, and provide lifetime support of, that we must pay.

Sep 12 2016, 9:01 PM · Setup, Bug Report
allixsenos updated the task description for T11630: file list once expanded cannot be shrunk back.
Sep 12 2016, 8:55 PM · Differential, Bug Report
allixsenos created T11630: file list once expanded cannot be shrunk back.
Sep 12 2016, 8:55 PM · Differential, Bug Report
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

for sshd and ignore the username

Sep 12 2016, 8:53 PM
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

I'd expect to just hide that in CLI porcelain:

Sep 12 2016, 8:51 PM
dfumagalli added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

This is unique to this particular setup check (open_basedir configured, but not in a way that creates a concrete problem we're able to detect).

I'm inclined to just simplify this check and make any value for open_basedir cause a fatal setup error.

Sep 12 2016, 8:45 PM · Setup, Bug Report
arice added a comment to T11618: "Edit Form Configuration" transaction history not easily accessible.

You're right! That probably makes is more feature request, less bug report. (extremely low priority FR)

Sep 12 2016, 8:45 PM · Contributor Onboarding, Bug Report
arice updated the task description for T11618: "Edit Form Configuration" transaction history not easily accessible.
Sep 12 2016, 8:44 PM · Contributor Onboarding, Bug Report
yelirekim added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

Maybe make it so that we can host an arbitrary number of ssh daemons on different ports with different entry scripts? I suppose we can kinda do that already by just copying the existing script, minus the part where we have different groups of ssh keys, but could probably sub in passphrase as the backing for authentication there.

Sep 12 2016, 8:42 PM
yelirekim updated subscribers of Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

Oh nice, I was expecting the "this is awful" upstream response for this :) I can put together use cases and either @jcox or I can work on upstreaming it.

Sep 12 2016, 8:37 PM
epriestley added Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).
Sep 12 2016, 8:33 PM
eadler added projects to T11629: Support "editor link" for repos without a callsign: Restricted Project, FreeBSD.
Sep 12 2016, 8:26 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
eadler created T11629: Support "editor link" for repos without a callsign.
Sep 12 2016, 8:26 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
achandra added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

That seems promising, I'll look into using a custom field. You can close this ticket, thank you.

Sep 12 2016, 8:09 PM · Feature Request
epriestley renamed T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action from Pressing "Ignore Setup Issue" during setup won't actually cause setup to ignore the issue. to PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.
Sep 12 2016, 8:07 PM · Setup, Bug Report
epriestley added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

This is unique to this particular setup check (open_basedir configured, but not in a way that creates a concrete problem we're able to detect).

Sep 12 2016, 8:06 PM · Setup, Bug Report
chad added a revision to T8972: Editing a room edits the previously selected one: Unknown Object (Differential Revision).
Sep 12 2016, 7:58 PM · Conpherence (v4)
chad added a comment to T11628: It's not simple to join a Conpherence.

This is probably the right default for "Rooms" ?

Sep 12 2016, 7:54 PM · Conpherence
chad created T11628: It's not simple to join a Conpherence.
Sep 12 2016, 7:51 PM · Conpherence
dfumagalli added a comment to T11613: New install exception is wrong if preflight setup checks fail.
In T11613#194396, @chad wrote:

Assuming probably you're seeing T10352

Sep 12 2016, 7:36 PM · Bug Report (Needs Information), Setup
chad edited this Badge.
Sep 12 2016, 7:29 PM
dfumagalli created T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.
Sep 12 2016, 7:28 PM · Setup, Bug Report
chad added a comment to T11613: New install exception is wrong if preflight setup checks fail.

Assuming probably you're seeing T10352

Sep 12 2016, 7:22 PM · Bug Report (Needs Information), Setup
chad added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

You can add this yourself as a Custom Field:

Sep 12 2016, 7:22 PM · Feature Request
achandra added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

Searching through Maniphest tasks in Phabricator

Sep 12 2016, 7:21 PM · Feature Request
chad added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

What application are you referring to specifically?

Sep 12 2016, 7:18 PM · Feature Request
dfumagalli added a comment to T11613: New install exception is wrong if preflight setup checks fail.
In T11613#194389, @chad wrote:

Can you file a bug report then if you believe the documentation contains a bug?

Sep 12 2016, 7:10 PM · Bug Report (Needs Information), Setup
chad added a comment to T11613: New install exception is wrong if preflight setup checks fail.

Can you file a bug report then if you believe the documentation contains a bug?

Sep 12 2016, 7:09 PM · Bug Report (Needs Information), Setup
dfumagalli added a comment to T11613: New install exception is wrong if preflight setup checks fail.
In T11613#194386, @chad wrote:

After fixing a bug in the provided .htaccess (recursion because of using "L" flag in self-modifying path), setup starts.

Are you following another guide on the internet? We don't provide .htaccess configurations in our guides.

Sep 12 2016, 7:07 PM · Bug Report (Needs Information), Setup
achandra added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

My feature request was not about asking users to fill in additional fields. It was about providing a keywords field that could be parsed during a search in case specific keywords might not be in the title or in the content of the phab. This is a feature that is part of many knowledgebases, and it allows additional search terms for a specific article or item without having to just type a bunch of words into the actual content.

Sep 12 2016, 7:06 PM · Feature Request
yelirekim updated Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? from to What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines?.
Sep 12 2016, 7:05 PM · Drydock
chad added a comment to T11613: New install exception is wrong if preflight setup checks fail.

After fixing a bug in the provided .htaccess (recursion because of using "L" flag in self-modifying path), setup starts.

Sep 12 2016, 7:05 PM · Bug Report (Needs Information), Setup
avivey added a comment to T11613: New install exception is wrong if preflight setup checks fail.

we detect and work correctly with both apc and apcu; Specifically, apcu pretends to be apc in many contexts, and we have code to distinguish them when needed.

Sep 12 2016, 7:02 PM · Bug Report (Needs Information), Setup
chad added a comment to T11613: New install exception is wrong if preflight setup checks fail.

Did you pull the latest code down? What is the error you are seeing now?

Sep 12 2016, 7:01 PM · Bug Report (Needs Information), Setup
avivey added a comment to T8635: Show history of changes to Herald rules.

Does this mean "render them nicely", or is this a very old ticket? because we technically show something now, although it's mostly useless.

Sep 12 2016, 7:00 PM · Restricted Project, Herald
dfumagalli added a comment to T11613: New install exception is wrong if preflight setup checks fail.

After fixing a bug in the provided .htaccess (recursion because of using "L" flag in self-modifying path), setup starts. However by quickly assessing the PHP code, I have noticed how APC "auto-detect" is PHP < 5.5 oriented.

Sep 12 2016, 7:00 PM · Bug Report (Needs Information), Setup
huangsj created T11626: Phabricator should properly display non-English characters such as Chinese in diffusion commit page.
Sep 12 2016, 6:31 PM · Restricted Project, Bug Report
epriestley awarded T11308: Re-enable direct messaging in Conpherence a Pirate Logo token.
Sep 12 2016, 5:24 PM · Conpherence (v4)
epriestley added a comment to T11308: Re-enable direct messaging in Conpherence.

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/project/lipsum/PhabricatorProjectNameContextFreeGrammar.php

Sep 12 2016, 5:24 PM · Conpherence (v4)
chad claimed T11622: In mobile Conpherence, provide a way to upload files.

I have an idea for this.

Sep 12 2016, 5:21 PM · Conpherence (v4), Files, Mobile
chad renamed T11308: Re-enable direct messaging in Conpherence from Re-enable to Re-enable direct messaging in Conpherence.
Sep 12 2016, 5:16 PM · Conpherence (v4)
chad renamed T11308: Re-enable direct messaging in Conpherence from Don't require a room name or build a separate direct message create form to Re-enable .
Sep 12 2016, 5:13 PM · Conpherence (v4)
chad awarded T11623: Make Conpherence send text with bare return key, like a chatroom a Party Time token.
Sep 12 2016, 5:03 PM · Conpherence (v4)
jonathanrseawright awarded T11623: Make Conpherence send text with bare return key, like a chatroom a Like token.
Sep 12 2016, 4:59 PM · Conpherence (v4)
chad closed T11624: Include ability to add keywords to Phabs to make them more search-friendly as Invalid.

Basically, I don't see any root problem here that Phabricator can solve. Asking users to fill in additional fields isn't a scalable approach - either they won't do it, or they'll do it incorrectly, or it'll become too time consuming to provide any benefit. The cost/benefit there is just way too high. It's more reasonable to ask you to simply adjust your search query to fewer words.

Sep 12 2016, 4:08 PM · Feature Request
hach-que renamed T11625: Merge build variables into Harbormaster build names from Merge build variables into Harbormaster builds to Merge build variables into Harbormaster build names.
Sep 12 2016, 3:33 PM · Restricted Project, Harbormaster, Feature Request
hach-que created T11625: Merge build variables into Harbormaster build names.
Sep 12 2016, 3:33 PM · Restricted Project, Harbormaster, Feature Request
chad added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

I would expect your search to return results. Do you have any unresolved setup warnings?

Sep 12 2016, 3:22 PM · Feature Request
chad added a comment to T11624: Include ability to add keywords to Phabs to make them more search-friendly.

So the solution here is to ask every user to add additional search terms to use Phabricator?

Sep 12 2016, 3:15 PM · Feature Request
achandra updated the task description for T11624: Include ability to add keywords to Phabs to make them more search-friendly.
Sep 12 2016, 2:56 PM · Feature Request
achandra created T11624: Include ability to add keywords to Phabs to make them more search-friendly.
Sep 12 2016, 2:53 PM · Feature Request
epriestley added a comment to T11613: New install exception is wrong if preflight setup checks fail.

D16542 should fix this and reveal whatever the underlying error is.

Sep 12 2016, 2:45 PM · Bug Report (Needs Information), Setup
epriestley added a revision to T11613: New install exception is wrong if preflight setup checks fail: Unknown Object (Differential Revision).
Sep 12 2016, 2:36 PM · Bug Report (Needs Information), Setup
epriestley created T11623: Make Conpherence send text with bare return key, like a chatroom.
Sep 12 2016, 1:58 PM · Conpherence (v4)
epriestley added a comment to T11621: View full commit message in diffusion query results.

Yes, if you want the change to apply retroactively. Something like bin/repository reparse --message --all rXYZ, but see bin/repository help reparse first to test that on a few commits and make sure it does what you want.

Sep 12 2016, 1:56 PM · Diffusion, Search, Feature Request
stevenm added a comment to T11621: View full commit message in diffusion query results.

Ok, I understand.

Sep 12 2016, 1:41 PM · Diffusion, Search, Feature Request
epriestley created T11622: In mobile Conpherence, provide a way to upload files.
Sep 12 2016, 1:36 PM · Conpherence (v4), Files, Mobile