Page MenuHomePhabricator
Feed All Stories

Jun 24 2016

epriestley added a revision to T11208: Support Subversion revprops: Restricted Differential Revision.
Jun 24 2016, 3:51 PM · Restricted Project, Subversion, Diffusion
UltimatePancake added a watcher for Phrequent: UltimatePancake.
Jun 24 2016, 3:44 PM
epriestley created T11208: Support Subversion revprops.
Jun 24 2016, 3:10 PM · Restricted Project, Subversion, Diffusion
ilendir added a comment to T10982: Harbormaster builds fail to allocate resource.

I have a somewhat similar problem when I try to start a working copy job:

Jun 24 2016, 12:19 PM · Harbormaster, Bug Report
epriestley added a comment to T11207: User can change properties on the task, even when not having edit policy rights.

There are many situations where you can make an edit in one way but not in another. For example, you can't edit the subscribers for a task via "Edit Task" on the detail page, workboards, or task list, or via the API, or via mail commands but you can edit them via "Subscribe", "Unsubscribe", with Herald, by commenting with @username, or via the action dropdown.

Jun 24 2016, 12:06 PM · Restricted Project, Policy, Bug Report
kibs added a comment to T11207: User can change properties on the task, even when not having edit policy rights.

Thanks for the quick reply.

Jun 24 2016, 12:02 PM · Restricted Project, Policy, Bug Report
epriestley added a comment to T11207: User can change properties on the task, even when not having edit policy rights.

This is expected. You do not need "edit" permission to comment on a task, subscribe to it, award it tokens, or take other actions available in the action dropdown.

Jun 24 2016, 11:59 AM · Restricted Project, Policy, Bug Report
epriestley added a comment to T11196: post-receive-hook configured from Phabricator web interface.

I have no plans to support that in the upstream. Running commands on the Phabricator host is a very unusual use case, and it would allow anyone who can write a Herald rule to write one that runs rm -rf / or compromises the Phabricator install by reading session keys out of MySQL.

Jun 24 2016, 11:43 AM · Herald, Feature Request
remusvrm added a comment to T11196: post-receive-hook configured from Phabricator web interface.

Hi Evan!

Jun 24 2016, 9:46 AM · Herald, Feature Request
kibs created T11207: User can change properties on the task, even when not having edit policy rights.
Jun 24 2016, 8:22 AM · Restricted Project, Policy, Bug Report
chad closed T11206: No categorization of bugs as Invalid.

Assume you are testing. Please use http://phacility.com if you want to try Phabricator at no cost. This is a working installation.

Jun 24 2016, 6:36 AM · Bug Report
• alan.raj created T11206: No categorization of bugs.
Jun 24 2016, 6:31 AM · Bug Report
exp10r3r added a watcher for Prioritized: exp10r3r.
Jun 24 2016, 5:51 AM
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Jun 24 2016, 4:50 AM · Phame
avivey created T11205: Hard/Impossible to disable SSH built-in URIs.
Jun 24 2016, 1:57 AM · Diffusion (v3), Bug Report
narutolee closed Q374: Harbormaster is always pending as resolved.
Jun 24 2016, 1:49 AM
narutolee added Q374: Harbormaster is always pending (Answer 407).
Jun 24 2016, 1:49 AM
chad changed the visibility for T3307: Create `phutil_utf8_truncate()` or make `phutil_utf8_shorten()` more sophisticated.
Jun 24 2016, 1:37 AM · libphutil
chad added a comment to T5391: Support custom fields in 'Export to Excel'.

See D10391

Jun 24 2016, 1:15 AM · Data Exporters
• sergio.xga added a comment to T5391: Support custom fields in 'Export to Excel'.

@witrin Thanks for that contribution! I really need this.
I tried to set this up but I got the followeing error:

Jun 24 2016, 1:09 AM · Data Exporters

Jun 23 2016

epriestley added a comment to T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.

Additionally, you should use maniphest.edit, not maniphest.update.

Jun 23 2016, 10:51 PM · Bug Report (Needs Information)
chad added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

Also, for clarification, "Administrators" on Phabricator are just regular users as far as policies go. They don't override them.

Jun 23 2016, 10:05 PM · Projects, Bug Report (Needs Information)
chad closed T11162: Unable to Edit Projects as Administrator, Showing Restricted as Invalid.

Closing for lack of feedback. If you're able to update your install and provide this task with a set of reproducible steps, we can look into it further.

Jun 23 2016, 10:04 PM · Projects, Bug Report (Needs Information)
chad edited projects for T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response, added: Bug Report (Needs Information); removed Bug Report.
Jun 23 2016, 9:47 PM · Bug Report (Needs Information)
chad added a comment to T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.

This issue is not always reproducible but happens very frequently:

Jun 23 2016, 9:47 PM · Bug Report (Needs Information)
chad added a comment to T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.

Updating Phabricator is required before submitting a bug report.

Jun 23 2016, 9:35 PM · Bug Report (Needs Information)
zhiyuchen updated the task description for T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.
Jun 23 2016, 9:32 PM · Bug Report (Needs Information)
zhiyuchen updated the task description for T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.
Jun 23 2016, 9:30 PM · Bug Report (Needs Information)
zhiyuchen created T11204: Sometimes maniphest status is not correctly updated after maniphest.update conduit api call returns success response.
Jun 23 2016, 9:26 PM · Bug Report (Needs Information)
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Yeah, I think you can just do a SQL migration like:

Jun 23 2016, 7:33 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

User enters full URI (protocol + domain + optional port), like https://blog.phacility.com/ (UI is basically the same as it is now -- they still enter one value, it just has protocol + port now).

Jun 23 2016, 7:31 PM · Phame
chad claimed T9117: Remove unused edges after Ponder comes out of beta.
Jun 23 2016, 5:45 PM · Contributor Onboarding, Ponder
chad added a comment to T9640: Make Phabricator compatible with PHP7.
In T9640#172158, @chad wrote:

I'll fire up a VM this weekend and see if there are any issues.

Jun 23 2016, 4:27 PM · Prioritized, Restricted Project, Infrastructure
epriestley closed T11203: Observing svn+ssh on non-standard ssh port as Resolved by committing Restricted Diffusion Commit.
Jun 23 2016, 2:40 PM · Bug Report
epriestley added a revision to T11203: Observing svn+ssh on non-standard ssh port: Unknown Object (Differential Revision).
Jun 23 2016, 2:35 PM · Bug Report
enckse added a comment to T11203: Observing svn+ssh on non-standard ssh port.

I've applied the patch and updated by URI accordingly (removed the ssh config as well) - seems to work

Jun 23 2016, 2:13 PM · Bug Report
• tomelssjo added a comment to T9640: Make Phabricator compatible with PHP7.

So what exactly do you need to comment out for this to work on PHP7? Is is src/applications/cache/spec/PhabricatorDataCacheSpec.php and src/applications/cache/spec/PhabricatorOpcodeCacheSpec.php

Jun 23 2016, 2:04 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T11203: Observing svn+ssh on non-standard ssh port.

Yes, put the port in the URI like a normal URI (host.com:1234).

Jun 23 2016, 2:02 PM · Bug Report
enckse added a comment to T11203: Observing svn+ssh on non-standard ssh port.

I'm willing to give it a go, just to confirm before I do that what my URI would be in the UI?

svn+ssh://svn.host.name:port/srv/repo/url/path/
Jun 23 2016, 2:01 PM · Bug Report
epriestley closed T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions as Resolved by committing Restricted Diffusion Commit.
Jun 23 2016, 1:45 PM · Bug Report
epriestley added a comment to T11203: Observing svn+ssh on non-standard ssh port.

If you have time, can you let me know if this patch fixes things?

Jun 23 2016, 1:42 PM · Bug Report
epriestley added a comment to T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.

I think the root of this is largely building a commit mapping from "draft" commits to their equivalent "published" commits. I believe all of the approaches available to us are:

Jun 23 2016, 1:26 PM · Prioritized, Restricted Project, Arcanist
enckse created T11203: Observing svn+ssh on non-standard ssh port.
Jun 23 2016, 1:06 PM · Bug Report
epriestley renamed T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions from Exception when destroy diffusion repository to Exception when destroying an object with edges that no longer have corresponding edge definitions.
Jun 23 2016, 12:53 PM · Bug Report
epriestley merged T10525: "Ghost" user created in external accounts table under certain circumstances into T5953: Build a modular user account batch importer.
Jun 23 2016, 12:49 PM · Restricted Project, Auth, Projects
epriestley merged task T10525: "Ghost" user created in external accounts table under certain circumstances into T5953: Build a modular user account batch importer.
Jun 23 2016, 12:49 PM · LDAP, Auth, Bug Report
epriestley added a comment to T10525: "Ghost" user created in external accounts table under certain circumstances.

I'm just going to merge this into T5953. The LDAP importer is a contributed patch from yesteryear which we wouldn't bring upstream today, and unlikely to see improvements outside of a more formal upstream effort in T5953.

Jun 23 2016, 12:49 PM · LDAP, Auth, Bug Report
epriestley closed T10489: Unexpected Remarkup behavior for links as Wontfix.

git blame suggests that this hasn't ever matched on word boundaries (it didn't in August 2012, when it was first written -- see rPHU45f7bd6a).

Jun 23 2016, 12:46 PM · Bug Report, Remarkup
epriestley closed T10433: Repo in Diffusion has no padding after Branches box if footer is not configured as Resolved.

I can't reproduce this on the linked install or locally either; presuming we fixed it at some point.

Jun 23 2016, 12:38 PM · Diffusion, Bug Report
epriestley merged T10380: Editing subscribers list should allow selection of exact or closest matched username into T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Jun 23 2016, 12:35 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley merged task T10380: Editing subscribers list should allow selection of exact or closest matched username into T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Jun 23 2016, 12:35 PM · Wikimedia, Maniphest, Bug Report
epriestley closed T10376: Error handling for mail send-test needs improvement as Wontfix.

We haven't seen other users encounter difficulty with this, and the error message is relatively specific already.

Jun 23 2016, 12:34 PM · Mail, Bug Report
epriestley closed T10326: Property Lists use "Projects", not "Tags" as Resolved.

This is sort of resolved since Diffusion moved to PHUITwoColumnView and project tags are now listed in the sidebar, labeled "Tags", while VCS tags are listed in the main list, also labeled "Tags". Labeling them both "tags" isn't great, but context provides some help and this doesn't immediately appear to be particularly confusing.

Jun 23 2016, 12:31 PM · Projects, Diffusion, Bug Report
epriestley added a comment to T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

When we destroy an object, we load all its edges and destroy them too.

Jun 23 2016, 12:18 PM · Bug Report
epriestley claimed T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.
Jun 23 2016, 12:17 PM · Bug Report
epriestley added a revision to T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions: Unknown Object (Differential Revision).
Jun 23 2016, 12:16 PM · Bug Report
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

This install now exposes two separate actions in a new submenu, although the backend is only sort of halfway converted. My plan is:

Jun 23 2016, 12:00 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
remusvrm added a comment to T11196: post-receive-hook configured from Phabricator web interface.

Thank you Evan for your ansewer!

Jun 23 2016, 10:46 AM · Herald, Feature Request
netroby added a comment to T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

The repository created last year.

Jun 23 2016, 5:59 AM · Bug Report
netroby added a comment to T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

I am running Phabricator up to date (I upgrade it today, using git pull --rebase)

Jun 23 2016, 5:58 AM · Bug Report
chad merged T11202: 502 while access /config/issue into T10987: /config/issue/ causes coredump in PHP-FPM.
Jun 23 2016, 3:40 AM · Bug Report
chad merged task T11202: 502 while access /config/issue into T10987: /config/issue/ causes coredump in PHP-FPM.
Jun 23 2016, 3:40 AM · Bug Report
netroby updated the task description for T11202: 502 while access /config/issue.
Jun 23 2016, 3:29 AM · Bug Report
netroby updated the task description for T11202: 502 while access /config/issue.
Jun 23 2016, 3:28 AM · Bug Report
netroby created T11202: 502 while access /config/issue.
Jun 23 2016, 3:27 AM · Bug Report
chad updated subscribers of T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

Edge Constant 39 was TYPE_OBJECT_USES_CREDENTIAL, which was removed a few months back.

Jun 23 2016, 2:35 AM · Bug Report
chad added a comment to T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.

What are the steps to reproduce the error, specifically? I can't trigger this exception.

Jun 23 2016, 1:59 AM · Bug Report
netroby created T11201: Exception when destroying an object with edges that no longer have corresponding edge definitions.
Jun 23 2016, 1:52 AM · Bug Report

Jun 22 2016

avivey added Q432: What is/are: arc lint + arc unit harbormaster autoplan? (Answer 406).
Jun 22 2016, 11:15 PM
jsturgeon updated Q432: What is/are: arc lint + arc unit harbormaster autoplan? from to What is/are: arc lint + arc unit harbormaster autoplan?.
Jun 22 2016, 10:27 PM
chad closed T11200: Cannot access installation Phabricator script (install_ubuntu.sh) from the website. as Resolved.

Sorry for the disruption.

Jun 22 2016, 9:00 PM · Bug Report
avivey added a comment to T11200: Cannot access installation Phabricator script (install_ubuntu.sh) from the website..

Should probably be fixed once D16170 is deployed...

Jun 22 2016, 8:58 PM · Bug Report
ograchikov created T11200: Cannot access installation Phabricator script (install_ubuntu.sh) from the website..
Jun 22 2016, 8:49 PM · Bug Report
avivey added a comment to T9365: Harbormaster results are hard to aggregate .

Here's what I'm thinking here:

  • Add lint/unit/coverage "summary" field to each Build.
  • Recalculate whenever new lint/unit objects show up (Possibly offline via daemon).
  • arc-side lint/unit already generates a Build, so this one will hold the --nolint/--nounit information (+ excuse?)
  • Anywhere we currently show that information, load the summary information and aggregate that, instead of aggregating all lints/units directly.
Jun 22 2016, 8:26 PM · Harbormaster, Restricted Project, Restricted Project
chad closed T11164: Badges: Unwanted entry at the history as Resolved by committing Restricted Diffusion Commit.
Jun 22 2016, 8:26 PM · Badges, Bug Report
chad added a revision to T11164: Badges: Unwanted entry at the history: Unknown Object (Differential Revision).
Jun 22 2016, 8:00 PM · Badges, Bug Report
chad closed T11166: When an install has no footer, Maniphest task previews have no bottom margin as Resolved by committing Restricted Diffusion Commit.
Jun 22 2016, 7:17 PM · PHUI
chad added a revision to T11166: When an install has no footer, Maniphest task previews have no bottom margin: Unknown Object (Differential Revision).
Jun 22 2016, 7:15 PM · PHUI
epriestley closed T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks", a subtask of T4788: Allow "Edit Dependencies" both ways (blocking and depending), as Resolved.
Jun 22 2016, 6:56 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks" as Resolved.

The UI stuff seems to be figured out so I'm going to call this done this continue work in T4788.

Jun 22 2016, 6:56 PM · Restricted Project, Design, Maniphest
epriestley closed T11198: browser timezone popup shows for disabled accounts as Resolved by committing Restricted Diffusion Commit.
Jun 22 2016, 6:54 PM · Bug Report
epriestley added a comment to T11198: browser timezone popup shows for disabled accounts.

Thanks. D16167 should hide this and the similar HTTP/HTTPS check for unapproved, disabled, unverified, etc., users, who can't act on them.

Jun 22 2016, 6:47 PM · Bug Report
epriestley added a revision to T11198: browser timezone popup shows for disabled accounts: Unknown Object (Differential Revision).
Jun 22 2016, 6:45 PM · Bug Report
scode added a comment to T11199: User visible error message on X-Forwarded-For header.

Thanks! That is exactly what we had, and I was not aware of it. And yes, we have this on purpose because of there being a load balancing (trusted) proxy in front of Phabricator. For whatever reason, I assumed Phabricator had it's own X-Forwarded-For handling. Mainly my mistake here was jumping to the assumption that Phabricator was looking at X-Forwarded-For based on the value - even though the error message never indicated that it was.

Jun 22 2016, 6:42 PM · Bug Report
epriestley added a comment to T11199: User visible error message on X-Forwarded-For header.

Since I typed up most of this anyway:

Jun 22 2016, 6:37 PM · Bug Report
scode added a comment to T11199: User visible error message on X-Forwarded-For header.

Closed as "invalid". I apologize for the noise. This was an undocumented Twitter specific patch.

Jun 22 2016, 6:25 PM · Bug Report
scode closed T11199: User visible error message on X-Forwarded-For header as Invalid.
Jun 22 2016, 6:24 PM · Bug Report
epriestley closed T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog as Resolved by committing Restricted Diffusion Commit.
Jun 22 2016, 6:20 PM · Maniphest
scode created T11199: User visible error message on X-Forwarded-For header.
Jun 22 2016, 6:18 PM · Bug Report
epriestley added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

I believe D16166 resolves this. See T11179 and T4788 for followups.

Jun 22 2016, 6:14 PM · Maniphest
eadler added a comment to T11198: browser timezone popup shows for disabled accounts.

this is a rather minor nit, but figured I should report it regardless.

Jun 22 2016, 6:14 PM · Bug Report
eadler created T11198: browser timezone popup shows for disabled accounts.
Jun 22 2016, 6:13 PM · Bug Report
epriestley added a comment to T11165: Changing a callsign throws a 404.

Yeah, this is a little obscure since I was trying not to build more than we needed. The URI comes from DiffusionRepositoryManagementPanel->newEditEnginePage(), which does this:

Jun 22 2016, 6:02 PM · Diffusion (v3), Bug Report
chad added a comment to T11165: Changing a callsign throws a 404.

I dinked around on this but for the life of me, can't find where it's getting the URI from. I did learn how paging works in EditEngine though.

Jun 22 2016, 5:56 PM · Diffusion (v3), Bug Report
jaredbischof added a comment to T11197: AphrontSchemaQueryException after phabricator upgrade.

Thanks!

Jun 22 2016, 5:49 PM · Bug Report
epriestley added a revision to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog: Unknown Object (Differential Revision).
Jun 22 2016, 5:36 PM · Maniphest
epriestley added a revision to T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks": Unknown Object (Differential Revision).
Jun 22 2016, 5:36 PM · Restricted Project, Design, Maniphest
epriestley closed T11197: AphrontSchemaQueryException after phabricator upgrade as Resolved.

Follow the instructions in Restarting Phabricator.

Jun 22 2016, 5:31 PM · Bug Report
jaredbischof created T11197: AphrontSchemaQueryException after phabricator upgrade.
Jun 22 2016, 5:28 PM · Bug Report
epriestley added a comment to T11195: Drydock's working copy should run "git lfs fetch && git lfs checkout" for repositories known to use Git LFS.

Offhand, I'm surprised by this. I expect LFS smudging to be a side effect of git checkout and for all Drydock working copy construction pathways to invoke git checkout. This appears consistent with advice from the LFS upstream (albeit a year or so old):

Jun 22 2016, 5:23 PM · Drydock, Feature Request