Page MenuHomePhabricator
Feed All Stories

May 23 2016

chad renamed T11016: When owner of Owners package is a project, audit triggers even when member of project signs off from when owner of Owners package is a project, audit triggers even when member of project signs off to When owner of Owners package is a project, audit triggers even when member of project signs off.
May 23 2016, 10:43 PM · Owners, Bug Report
chad added a project to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user: Owners.
May 23 2016, 10:42 PM · Owners, Bug Report
chad added a comment to T11000: Ability to mark maniphest fields are required in custom form.

Generally, we want to understand problems, which is why I linked the guide to you. A example might be that Team A is "Marketing" and Team B is "Engineering" and the Field is a Select, that uses values X, Y, and Z, and Engineering triages them, but Marketing doesn't need to set them. This tells us a good story at which to understand overarching needs. Upcoming tools like Nuance sit in front of Maniphest and might be what you're looking for, or maybe not, I just don't have enough backstory here.

May 23 2016, 10:34 PM · EditEngine, Feature Request
chad added a comment to T8786: Add support for custom fields per project.
May 23 2016, 10:34 PM · Projects, Custom Fields
chad added a comment to T11000: Ability to mark maniphest fields are required in custom form.

Sorry, I understood perfectly the feature you wanted. I don't understand the core problem you're trying to solve. If you could get into specifics, it would help us better understand if, for instance, you should just be using Nuance. Can you be more specific and tell us what the field your attempting to us is, for example?

May 23 2016, 10:30 PM · EditEngine, Feature Request
zhiyuchen added a comment to T11000: Ability to mark maniphest fields are required in custom form.

@chad Sorry that I didn't explain that clear enough in the description, here is what I'm trying to accomplish:

May 23 2016, 10:19 PM · EditEngine, Feature Request
epriestley created T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?.
May 23 2016, 10:17 PM · Clusters, Diffusion
eadler added a comment to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.

ref T9412

May 23 2016, 10:04 PM · Owners, Bug Report
eadler added a comment to T11019: Improve UX and general awareness of "remote diff" processing.
May 23 2016, 10:04 PM · Restricted Project, Arcanist, Feature Request
yelirekim created T11019: Improve UX and general awareness of "remote diff" processing.
May 23 2016, 9:51 PM · Restricted Project, Arcanist, Feature Request
joshuaspence created T11018: Restricted credentials show as unknown in Drydock .
May 23 2016, 9:42 PM · Bug Report, Drydock
edibiase added a comment to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.

That sounds like it might be what's going on. I apologize for not having better steps to reproduce; I'm working backward from example emails that folks are receiving, so it's been a bit of a guessing game as to how to make this happen.

May 23 2016, 9:00 PM · Owners, Bug Report
epriestley added a comment to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.

I think I have a pretty good guess about this one.

May 23 2016, 8:56 PM · Owners, Bug Report
chad added a comment to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.

Can you be more specific about the steps to reproduce?

May 23 2016, 8:39 PM · Owners, Bug Report
edibiase created T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.
May 23 2016, 8:32 PM · Owners, Bug Report
allixsenos added a comment to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.
  1. manually restarted php5-fpm and phd services
  2. colleague, member of ops submitted review touching src/ansible
  3. that review doesn't explicitly list "ops" as blocking reviewers because he's also an owner of ansible, but it does highlight my review in yellow
    Screen Shot 2016-05-23 at 22.03.22.png (43×179 px, 5 KB)
  4. he lands it after I accept it
  5. his commit is flagged for review despite both of us being members of ops
May 23 2016, 8:04 PM · Owners, Bug Report
epriestley added a comment to T10939: Support for OWNERS files.

@joshuaspence, see T11010, I think. Not sure why nginx was 502'ing there, but should be fixed in HEAD.

May 23 2016, 7:49 PM · Prioritized, Restricted Project, Owners
epriestley closed T11010: Http502 when submitting or updating a diff as Resolved by committing Restricted Diffusion Commit.
May 23 2016, 7:48 PM · Bug Report
allixsenos added a comment to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.

I will manually restart everything and reproduce again

May 23 2016, 7:45 PM · Owners, Bug Report
epriestley added a comment to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.

Before I dig into this, is there any possibility this was a daemon running old code? I don't remember if I tested this explicitly and it could quite reasonably be an upstream bug, but the code at least attempts to check for this, and D15939 theoretically fixed issues with this.

May 23 2016, 7:45 PM · Owners, Bug Report
allixsenos updated the task description for T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.
May 23 2016, 7:43 PM · Owners, Bug Report
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

We can also use weird implicit magic to try to resolve this. Here's a ruleset that will make everyone equally confused and unhappy:

May 23 2016, 7:25 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
allixsenos created T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.
May 23 2016, 7:16 PM · Owners, Bug Report
scode added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

That's a lot more clear, thanks!

May 23 2016, 7:07 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I think that that creates some tension that I'm not immediately sure how to resolve:

May 23 2016, 7:02 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
scode added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

The user story most important to us is:

May 23 2016, 6:38 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
eadler added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.
In T10855#172123, @chad wrote:

A Phriction Panel which we talked about briefly would provide this automagically without wiring Dashboards to Conduit.

We would be okay with this too.

May 23 2016, 6:36 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T4103: Implement "Role Profiles" to provide search, homepage and application defaults from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:35 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a project to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Prioritized.
May 23 2016, 6:34 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:34 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a project to T10855: Allow external systems to edit the content of dashboard panels so they can publish information: Prioritized.

We aren't really sold on this as a specific use case, but can give you a modern dashboard.panel.edit which will let you implement it. If there are weird followups arising from this (like difficulty managing the 300,000 transactions on the panel detail a year from now) we may be somewhat less sympathetic to them than we would be to a more on-label use case.

May 23 2016, 6:33 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:25 PM · Prioritized, Restricted Project, Feature Request
epriestley added a project to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Prioritized.

This is about two hours of work.

May 23 2016, 6:25 PM · Prioritized, Restricted Project, Feature Request
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Paused to Preflight on the Prioritized board.
May 23 2016, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

There were ultimately two sort of related requests here, although some of the discussion happened off-thread. Let's call them arc diff --draft and arc diff --try:

May 23 2016, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
lpriestley added a revision to T9606: "Calendar" tab on user profiles is pretty junky: Unknown Object (Differential Revision).
May 23 2016, 6:20 PM · Calendar
eadler moved T4103: Implement "Role Profiles" to provide search, homepage and application defaults from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:15 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
eadler moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:13 PM · Prioritized, Restricted Project, Feature Request
eadler moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:13 PM · Dashboards, Restricted Project, Conduit, Feature Request
eadler moved T8909: Provide ability to hide all inline or done comments from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:13 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
eadler moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
eadler moved T3837: Support updating JIRA custom field when revisions change status from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:13 PM · Restricted Project, Doorkeeper, Differential
eadler removed a project from T3837: Support updating JIRA custom field when revisions change status: Prioritized.
May 23 2016, 6:12 PM · Restricted Project, Doorkeeper, Differential
eadler moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:12 PM · Dashboards, Restricted Project, Conduit, Feature Request
eadler moved T4103: Implement "Role Profiles" to provide search, homepage and application defaults from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:11 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
eadler moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:11 PM · Prioritized, Restricted Project, Feature Request
eadler moved T2495: Improve whitespace expansion of tab literals from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 23 2016, 6:06 PM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley added a revision to T11010: Http502 when submitting or updating a diff: Unknown Object (Differential Revision).
May 23 2016, 5:43 PM · Bug Report
eadler added a project to T2495: Improve whitespace expansion of tab literals: Restricted Project.
May 23 2016, 5:43 PM · Restricted Project, FreeBSD, Differential, Diffusion
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

unfortumately

May 23 2016, 5:36 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

The time zone selected below has been auto-detected based on your browser settings

May 23 2016, 5:36 PM · Prioritized, Restricted Project, User Preferences
chad added a comment to T11012: Audit not Triggered Sometimes in Owners/Packages Application.

This may also be T11015.

May 23 2016, 5:35 PM · Restricted Project, Owners, Bug Report
epriestley added a revision to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them: Unknown Object (Differential Revision).
May 23 2016, 5:28 PM · Prioritized, Restricted Project, User Preferences
lpriestley added a revision to T9606: "Calendar" tab on user profiles is pretty junky: Unknown Object (Differential Revision).
May 23 2016, 5:28 PM · Calendar
cjrjscgallo added a comment to Q397: ERR_EMPTY_RESPONSE.

Thanks, that's what I'm thinking, too, but I wanted to check all of the options. Thank you.

May 23 2016, 5:18 PM
chad added a comment to Q397: ERR_EMPTY_RESPONSE.

Or, at least, not one we've ever heard of nor are likely to be able to replicate. Google seems to suggest this is a local computer / network issue.

May 23 2016, 5:12 PM
chad added a comment to Q397: ERR_EMPTY_RESPONSE.

This isn't a problem with Phabricator.

May 23 2016, 5:10 PM
cjrjscgallo updated Q397: ERR_EMPTY_RESPONSE from to ERR_EMPTY_RESPONSE.
May 23 2016, 4:59 PM
scode added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

I tried it out. One thing I realized was that without having the context of this ticket, during the pop-up after you click the notification, it's not obvious whether the timezone being shown is the *current* setting or the *new setting based on your browser*. That could cause confusion, so would suggest a slight phrasing change there.

May 23 2016, 4:45 PM · Prioritized, Restricted Project, User Preferences
epriestley renamed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash from Owners not picking up code reviews, unclear if properly configured to Owners has perplexing behavior when directory paths are not terminated with a slash.
May 23 2016, 4:34 PM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Yeah, current behavior is garbage. Not sure if I changed it by accident while doing other changes or we just didn't run into it before, but there's no technical or product reason for it to work like it currently does.

May 23 2016, 4:31 PM · Owners, Bug Report
eadler added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

I ran into an identical issue (and debugged on chat). Agreed that there could be better messaging around this.

May 23 2016, 4:24 PM · Owners, Bug Report
chad changed the image for Image Macro "yougotit".
May 23 2016, 4:02 PM
allixsenos added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

that worked. there's no indication in the UI that the trailing slash is required, the link rendered works fine

May 23 2016, 3:48 PM · Owners, Bug Report
epriestley added a comment to T11002: permit wildcards in OWNERs paths.

I suspect it isn't going to get very far because we lose our ability to optimize lookups (I wrote this in the general case as "regexp", but mean "regexp/wildcard" -- wildcards aren't as complex but I think the general case still holds).

May 23 2016, 3:31 PM · FreeBSD, Owners, Feature Request
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Try /wsl_root/src/ansible/ (with a trailing slash)?

May 23 2016, 3:09 PM · Owners, Bug Report
allixsenos created T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.
May 23 2016, 2:47 PM · Owners, Bug Report
epriestley closed T11014: Voluptas soluta ut quod vel vel voluptatem quo provident autem reprehenderit dolorem quibusdam ullamco at reprehenderit natus obcaecati labore debitis as Spite.
May 23 2016, 2:33 PM · Abuse
flashydave added a comment to T9640: Make Phabricator compatible with PHP7.

For issues with Ubuntu 16.04 LTS and acpu with PHP7 giving rise to "apc_sma_info() not found" Exceptions then you could install backward compatibility library package php-apcu-bc_1.0.3-2_amd64.deb using dpkg once downloaded from future Ubuntu Yakkety release universe repository. No doubt this deb will get back-ported to 16.04 LTS soon enough assuming phabricator itself isnt updated to no longer reference this missing function.

May 23 2016, 2:26 PM · Prioritized, Restricted Project, Infrastructure
• hacker924 created T11014: Voluptas soluta ut quod vel vel voluptatem quo provident autem reprehenderit dolorem quibusdam ullamco at reprehenderit natus obcaecati labore debitis.
May 23 2016, 2:26 PM · Abuse
chad added a comment to T11012: Audit not Triggered Sometimes in Owners/Packages Application.

Please follow all the steps in Contributing Bug Reports. Specifically we need to know how to reproduce the issue locally.

May 23 2016, 1:46 PM · Restricted Project, Owners, Bug Report
cspeckmim added a comment to T10716: Differential Checklist Feature Request.

Funny enough there were discussions among the engineering leads on Friday about having this type of functionality in Phabricator being useful. It wasn't a main point of discussion but several did look to Phabricator for being able to solve some concerns. The primary concern was around having accountability for specific quality points which may not necessarily be clear from the revision alone. Without Phabricator we approach this pretty much as I had mentioned above (training materials and KB/wiki with a checklist to be used with some pre-commit unit tests to help with some items that can be automatically checked), however we work in a well-regulated industry where checklists/documents as evidence are often highly valued. I think for the time being if we decide to move forward with this in Phab we may include a "template comment" to be filled out and used when accepting revisions.

May 23 2016, 1:37 PM · Differential, Feature Request
joshuaspence created T11013: "Unknown Object" when attempting to create a new Almanac network.
May 23 2016, 1:33 PM · Almanac, Bug Report
florianb awarded T10203: Support Windows hosts in Drydock a Like token.
May 23 2016, 12:22 PM · Haskell.org, Harbormaster, Feature Request, Drydock
eadler updated the task description for T10939: Support for OWNERS files.
May 23 2016, 12:05 PM · Prioritized, Restricted Project, Owners
OCram awarded Configuring a Windows build agent for Drydock a Yellow Medal token.
May 23 2016, 10:54 AM
OCram awarded T10203: Support Windows hosts in Drydock a Like token.
May 23 2016, 10:50 AM · Haskell.org, Harbormaster, Feature Request, Drydock
• mdchristoffer updated the question details for Q396: How are you suppose to work with Phabricator when you have revisions based on revisions?.
May 23 2016, 10:19 AM · Phabricator
RuralHunter created T11012: Audit not Triggered Sometimes in Owners/Packages Application.
May 23 2016, 9:52 AM · Restricted Project, Owners, Bug Report
• mdchristoffer updated the question details for Q396: How are you suppose to work with Phabricator when you have revisions based on revisions?.
May 23 2016, 9:39 AM · Phabricator
• mdchristoffer updated Q396: How are you suppose to work with Phabricator when you have revisions based on revisions? from to How are you suppose to work with Phabricator when you have revisions based on revisions?.
May 23 2016, 9:35 AM · Phabricator
aklapper added a comment to T7171: Periodically email saved queries.

Evan, thanks (as usual) for elaborating which options are available! This is very helpful.

May 23 2016, 9:16 AM
allixsenos closed T11009: owners packages details screen throws exception as Invalid.

I apologize, my ansible deploy script *should* have restarted everything that needs restarting, but it appears it didn't.

May 23 2016, 9:13 AM · Bug Report
Luke081515.2 added a comment to T10939: Support for OWNERS files.

General question: Why is the owners option "Add as reviewer (blocking)" if an owner uploads a revision? I know that this is expected, but why? For example at Wikimedia we currently have the system, that every change needs a review from an "owner" before the patch gets merged, so it's not useful, if an owner of the package uploads a change, and no reviewers get added. Maybe the a compromise may be a setting, where you can choose, if a package gets added as reviewer too, if the author of the revision is an owner too? I think that would help all.

May 23 2016, 9:02 AM · Prioritized, Restricted Project, Owners
joshuaspence added a comment to T11011: Can't connect to MySQL server.

The following queries are full table scans:

May 23 2016, 5:31 AM · Performance, Bug Report
joshuaspence created T11011: Can't connect to MySQL server.
May 23 2016, 5:27 AM · Performance, Bug Report
hach-que added a comment to M1464: Curtain v2.

Yeah I think assignee is an important piece of information, but created seems not that important? And like, in terms of focusing a user's attention, the gutter feels like "this is the second most important thing to title". Like having the avatar of the user who created it doesn't feel like very useful information.

May 23 2016, 5:23 AM · PHUI
chad added a comment to M1464: Curtain v2.

The main challenge here is in Phabricator, tasks are ephemeral wikis that tend to be community built. Knowing the author is generally inconsequential, though here directly we may treat the severity of the task differently if we know which install is filing it. I think assignee is reasonable to highlight, but is not always present. So then do we only show if it's assigned, or have some pointless placeholder text taking up space. We tend to never hide information, so then on this install we'd be stuck with 98% of tasks saying unassigned. It's all kind of lose-lose which is why it's how it is today (which still feels correct for most installs).

May 23 2016, 4:57 AM · PHUI
chad added a comment to M1464: Curtain v2.

Maybe we should just improve curtain first

May 23 2016, 4:40 AM · PHUI
chad added a comment to M1464: Curtain v2.

Actions are always at the top of the sidebar, and pushing them down inst something I want to explore, since it makes day to day use significantly harder, but maybe it wouldn't be as bad as I imagine.

May 23 2016, 4:36 AM · PHUI
hach-que added a comment to M1464: Curtain v2.

Personally I'm not really sold on the gutter text. It forces everything else down for what could just be positioned at the top of the sidebar?

May 23 2016, 4:30 AM · PHUI
• donotreply created T11010: Http502 when submitting or updating a diff.
May 23 2016, 4:05 AM · Bug Report
chad added a comment to M1464: Curtain v2.

It's an interesting idea. I'm not super happy about promoting the author as the "important" part of the task / image, but having a nice summary explaining it's full current state seems pretty helpful.

May 23 2016, 3:40 AM · PHUI
joshuaspence added a comment to T10939: Support for OWNERS files.

I don't know how to reproduce the issue, but figured I'd let you know that I'm seeing this in our error logs:

May 23 2016, 12:27 AM · Prioritized, Restricted Project, Owners
avivey added a comment to T11009: owners packages details screen throws exception.

Did you restart all webservers/php-fpm/etc. after upgrading? Did you upgrade the storage?
I cannot immediately reproduce this - see Contributing Bug Reports for some more information that can help you.

May 23 2016, 12:17 AM · Bug Report
epriestley added a comment to T11009: owners packages details screen throws exception.

Did you fully restart everything (see Restarting Phabricator) after upgrading? I can't reproduce this and it looks like the kind of thing that could happen if Phabricator was not fully restarted.

May 23 2016, 12:13 AM · Bug Report

May 22 2016

allixsenos created T11009: owners packages details screen throws exception.
May 22 2016, 11:59 PM · Bug Report
epriestley closed T10381: Tweak linebreak preservation behavior of PHUIRemarkupView as Resolved by committing Restricted Diffusion Commit.
May 22 2016, 7:23 PM · Remarkup
epriestley closed T992: Send rich HTML mail bodies without impacting reply handling functionality as Resolved.

We now send HTML mail by default.

May 22 2016, 7:20 PM · Mail, Differential
eadler moved T8909: Provide ability to hide all inline or done comments from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 22 2016, 6:41 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD