Phabricator sending unexpected email for commits that aren't obviously related to the user
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	edibiase
	May 23 2016, 8:32 PM

Description

After upgrading our Phabricator installation to 2016 Week 21, a lot of our users started receiving email notifications about commits that aren't obviously related to them.

It looks like the issue may be that Phabricator is sending out audit email to owners of a package for all commits that are in that package, even if no audit is triggered.

For example, one user received an unexpected email about a commit that had X-Phabricator-Mail-Tags: <audit-commit>, <audit-add-auditors>. The commit only had one group auditor, however, and this user wasn't a member of that group. Interestingly, though, the commit did contain files that were part of other packages that the user was a member of, but the groups for those packages were not added as auditors.

Version Information

phabricator 77d543ba44638a2e43e1b6bb7f75db80b4046409 (Fri, May 20)
arcanist 0249f90a9a4aa42da0823673a6ac8c620251d82a (Fri, May 20)
phutil 7ff4bd8dfb0b58686a72821dd0e9e79e0f5cbbb9 (Fri, May 20)

Revisions and Commits

rP Phabricator
	D15970	rP74e117ae41dd Don't send mail to "uninteresting" auditors

Related Objects

Mentioned Here: T9412: Annotate all the reasons that a user is included on the recipient list for mail
rP77d543ba4463: (stable) Promote 2016 Week 21
rARC0249f90a9a4a: (stable) Promote 2016 Week 21
rPHU7ff4bd8dfb0b: (stable) Promote 2016 Week 21

Event Timeline

edibiase created this task.May 23 2016, 8:32 PM

Can you be more specific about the steps to reproduce?

I think I have a pretty good guess about this one.

I think we're sending mail to all auditors, including "uninteresting" auditors. I think we always did this, but previously packages couldn't actually receive mail, so it was moot. Fix is likely to just exclude the "uninteresting" auditors from mail recipients.

That sounds like it might be what's going on. I apologize for not having better steps to reproduce; I'm working backward from example emails that folks are receiving, so it's been a bit of a guessing game as to how to make this happen.

One detail I forgot to include is that the To: line of at least one such email contained all of the packages that matched files in the commit (and the recipient was a member of a couple of those packages), which, in conjunction with the mail tags, is what got me thinking that packages are involved.