Page MenuHomePhabricator
Feed All Stories

Feb 28 2016

eadler updated the task description for T10466: Wrong mail and extra feed story when joining a project.
Feb 28 2016, 5:27 AM · Projects, Bug Report
eadler created T10466: Wrong mail and extra feed story when joining a project.
Feb 28 2016, 5:25 AM · Projects, Bug Report
eadler added a member for Wikimedia: eadler.
Feb 28 2016, 5:08 AM
Krinkle added a project to T2442: Show images in Diffusion diffs: Wikimedia.
Feb 28 2016, 1:08 AM · Wikimedia, Diffusion

Feb 27 2016

chad closed T10465: Test report as Invalid.
Feb 27 2016, 11:46 PM · Bug Report
• dolftax created T10465: Test report.
Feb 27 2016, 10:40 PM · Bug Report
epriestley closed T10464: Understanding the as Spite.

Pretty sure this is the same user as @9999999999, @Persona, @nagya and @nagym. They're just registering an account every day, being vaguely annoying, and then getting disabled. O.o

Feb 27 2016, 6:50 PM · Feature Request
• totova created T10464: Understanding the.
Feb 27 2016, 6:48 PM · Feature Request
• teror4uks added a comment to T10460: Commit Still Parsing.

i am cloning repo in my local phabricator(ssh only read) and cloning repo in my notebook, then add new file in dir1 "test" and commit he in rSVNTEST then accept commit and i found this revision on my local phabricator where she all the same do not open for review code same all post revisions...

Снимок экрана от 2016-02-27 20:34:34.png (768×1 px, 149 KB)

Feb 27 2016, 5:36 PM · Diffusion, Bug Report (Needs Information)
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 5:23 PM · Harbormaster (v3), Drydock (v3), Phacility
• teror4uks added a comment to T10460: Commit Still Parsing.

okey im trying pull test repo in my sandbox, but im not sure what it's working. Chad how you can see on offer connect in my local phabricator and see all your self ? :)

Feb 27 2016, 5:08 PM · Diffusion, Bug Report (Needs Information)
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 5:05 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10462: AASTNode in libphutil missing tokenCache declaration as Resolved.
Feb 27 2016, 5:03 PM · Infrastructure, Bug Report
chad added a comment to T10460: Commit Still Parsing.

We're also not familiar with https://riouxsvn.com/, so maybe removing that host as a variable would help. Phabricator has built in SVN hosting.

Feb 27 2016, 4:40 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10460: Commit Still Parsing.

Unfortunately no, we need reproduction steps to be able to move further. We need some means of observing the issue in a local sandbox so we can be sure we've found and fixed the right bug. That might mean you isolating the offending commit that is giving Phabricator trouble, breaking down to a minimal test case, and pushing an example to rSVNTEST for us to inspect.

Feb 27 2016, 4:37 PM · Diffusion, Bug Report (Needs Information)
• teror4uks added a comment to T10460: Commit Still Parsing.

chad you have any ideas what's wrong in my local phabricator or whath next steps i have to do for resove it's problem?

Feb 27 2016, 4:19 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10461: ui.footer-items doesn't support mailto links.

Yeah footer links aren't a great place for a mailto:. Overall you're better making a Phriction document with all the vital information, and have a link to that in the footer under "Contact Review Team" or something. Just an email link without context seems a like a wasted opportunity.

Feb 27 2016, 4:13 PM · Feature Request
chad edited projects for T10460: Commit Still Parsing, added: Bug Report (Needs Information), Diffusion; removed Bug Report.
Feb 27 2016, 4:10 PM · Diffusion, Bug Report (Needs Information)
chad added projects to T10452: Provide more flexible management over disabling/changing ldap user accounts: Auth, LDAP.
Feb 27 2016, 4:09 PM · Restricted Project, LDAP, Auth, Feature Request
epriestley added a comment to T10462: AASTNode in libphutil missing tokenCache declaration.

D15358 should fix this by declaring the property. Nice catch on finding this!

Feb 27 2016, 3:27 PM · Infrastructure, Bug Report
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 27 2016, 3:27 PM
epriestley claimed T10462: AASTNode in libphutil missing tokenCache declaration.
Feb 27 2016, 3:27 PM · Infrastructure, Bug Report
epriestley added a comment to T10462: AASTNode in libphutil missing tokenCache declaration.

Specifically, the issue is that this class extends Phobject, which implements __set() and throws when an undeclared property is written to. The exception is swallowed elsewhere in the stack.

Feb 27 2016, 3:24 PM · Infrastructure, Bug Report
epriestley closed T10011: Allow to search for the build status in habormaster querys as Resolved by committing Restricted Diffusion Commit.
Feb 27 2016, 3:13 PM · Harbormaster (v3), Feature Request
epriestley added a comment to T10246: Deploy Drydock in the Phacility cluster.

This is detailed in T10463, but the API changes seem to have deployed with only a few minor rough patches, so we're currently on track to deploy everything else next Saturday (March 5).

Feb 27 2016, 1:59 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10463: Deploy Almanac v2 Changes to the Cluster as Resolved.

Test instance workflow looks good, and general monitoring also looks clean. I'll keep an eye on things but I think we're in the clear.

Feb 27 2016, 1:56 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

Also, the backup changes from last week (rCOREbf0c93a46f8b) seem to have worked correctly. The instances that were hitting problems and delays have written backups exactly on schedule every day since then.

Feb 27 2016, 1:52 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

Daemons look good -- we accumulated a bit of a queue of backup tasks while the tier was out of sync, but these have now almost completely flushed on their own.

Feb 27 2016, 1:50 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've deployed the remainder of the repo tier, and the auxiliary service tiers. I believe deployment is essentially complete.

Feb 27 2016, 1:47 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

repo001 seems to have gone smoothly and daemons/repositories are now restored, I'm deploying the remainder of the tier.

Feb 27 2016, 1:41 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

db tier is deployed, now deploying repo001.

Feb 27 2016, 1:38 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've upgraded db001 and sorted out host instances and service sync flows, which seem OK now. I'm going to upgrade the rest of the db tier.

Feb 27 2016, 1:32 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

web is sort of back up, but needs the new schema to actually make any progress, so this isn't conclusive. I'm deploying the db tier now to get the new schema.

Feb 27 2016, 1:19 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.
  • I stopped web.
  • I deployed admin.
  • I manually removed now-invalid configuration from instances and from Alamanac properties.
  • I spot-checked instance/Almanac service relationships.
  • I spot-checked Almanac service properties.
  • I manually invoked almanac.service.search to look for issues, but everything looks good.
Feb 27 2016, 1:13 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've stopped the daemons. I'm going to stop the web tier, deploy admin, fix instance configuration, then deploy the web tier. I expect this to be the riskiest part of the upgrade.

Feb 27 2016, 1:03 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I'm getting this underway now. I'm going to preemptively stop all daemons, which will pause repository imports, outgoing mail, etc. They'll be restarted at the end of the process.

Feb 27 2016, 1:00 PM · Phacility, Ops
epriestley created T10463: Deploy Almanac v2 Changes to the Cluster.
Feb 27 2016, 12:26 PM · Phacility, Ops
epriestley edited the content of Changelog.
Feb 27 2016, 12:16 PM
epriestley created 2016 Week 9 (Very Late February).
Feb 27 2016, 12:16 PM
epriestley created Blog Post: Development Notes (2016 Week 9).
Feb 27 2016, 12:15 PM
• totova awarded T10456: Conduit interprets all arguments from curl requests as strings a Heartbreak token.
Feb 27 2016, 10:29 AM · Restricted Project, Conduit, Bug Report
tetrapus created T10462: AASTNode in libphutil missing tokenCache declaration.
Feb 27 2016, 4:56 AM · Infrastructure, Bug Report
hach-que added a comment to T5822: Implement garbage collection / automatic archiving for Harbormaster logs.

I believe our Harbormaster log table is several GBs in size and by several GB I'm talking 20-80GB range depending on the last time I hard deleted the records.

Feb 27 2016, 4:41 AM · Harbormaster, Restricted Project
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 3:54 AM · Harbormaster (v3), Drydock (v3), Phacility
eserrano added a comment to T10349: Projects v3 Errata.

When creating the first subproject there is a note that all members of the project will be moved to the subproject.

Feb 27 2016, 3:19 AM · Restricted Project, Projects (v3)
epriestley added a comment to T5822: Implement garbage collection / automatic archiving for Harbormaster logs.

Pretty sure I can scope this into the current iteration under T10457 and provide some corresponding purge tools, just in case any installs hypothetically insert gigabytes of data into build logs.

Feb 27 2016, 1:17 AM · Harbormaster, Restricted Project
epriestley moved T5822: Implement garbage collection / automatic archiving for Harbormaster logs from v2 to v3 on the Harbormaster board.
Feb 27 2016, 1:14 AM · Harbormaster, Restricted Project

Feb 26 2016

epriestley closed T10459: AphrontSchemaQueryException on create\update task as Invalid.

In any case, this is definitely some kind of problem in your local environment and not an issue with the upstream. We can't and won't be able to reproduce it and can't help you with installation and setup issues (see Support Resources).

Feb 26 2016, 11:40 PM · Bug Report (Needs Information)
epriestley added a comment to T10459: AphrontSchemaQueryException on create\update task.

Oh, wait, you're actually on stable and just haven't updated master.

Feb 26 2016, 11:38 PM · Bug Report (Needs Information)
epriestley added a comment to T10459: AphrontSchemaQueryException on create\update task.

This column and the property for it were both removed in 32225d1 (Feb 8). You are running b5518d4b (Feb 7), but have somehow upgraded your database using a newer version of Phabricator.

Feb 26 2016, 11:36 PM · Bug Report (Needs Information)
epriestley added a comment to T10461: ui.footer-items doesn't support mailto links.

A workaround is to write a wiki page like "how to get help with stuff" and put the link there.

Feb 26 2016, 9:18 PM · Feature Request
eadler created T10461: ui.footer-items doesn't support mailto links.
Feb 26 2016, 9:10 PM · Feature Request
• teror4uks edited projects for T10460: Commit Still Parsing, added: Bug Report; removed Bug Report (Needs Information).
Feb 26 2016, 9:02 PM · Diffusion, Bug Report (Needs Information)
epriestley added a revision to T10011: Allow to search for the build status in habormaster querys: Unknown Object (Differential Revision).
Feb 26 2016, 8:47 PM · Harbormaster (v3), Feature Request
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 26 2016, 8:23 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 26 2016, 8:05 PM · Harbormaster (v3), Drydock (v3), Phacility
eadler edited projects for T3980: Support "Bind to External Thing" to define project membership, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 8:01 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
eadler edited projects for T5547: Allow members of a project to add rules with project reviewers, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 8:00 PM · Restricted Project, Herald
eadler edited projects for T5889: Allow herald rules to act on existence of auditors, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 8:00 PM · Restricted Project, Audit, Herald
eadler edited projects for T6207: Add a "Can Use Herald Rules" application permission, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:59 PM · Restricted Project, Policy, Herald
eadler edited projects for T8804: Replacing a Herald rule with a Doorkeeper extension, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:58 PM · Restricted Project, Herald, Doorkeeper
eadler edited projects for T7834: Package owners doesn't get mail after a commit triggers an audit, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:58 PM · Unknown Object (Project), Audit, Herald
eadler edited projects for T9766: Expose conduit API to activate/disable Herald rules, added: Unknown Object (Project); removed Owners.
Feb 26 2016, 7:58 PM · Restricted Project, Restricted Project, Conduit, Herald
eadler edited projects for T9766: Expose conduit API to activate/disable Herald rules, added: Owners; removed Restricted Project.
Feb 26 2016, 7:58 PM · Restricted Project, Restricted Project, Conduit, Herald
eadler edited projects for T5758: Package auditing should only require auditing on closing branches, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:57 PM · Restricted Project, Owners
eadler edited projects for T8887: Allow owners packages to add blocking reviewers, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:56 PM · Haskell.org, Restricted Project, Owners
eadler edited projects for T1258: Add an "Automatically CC Owners on Differential Revisions" checkbox to Owners, added: Unknown Object (Project); removed Restricted Project.
Feb 26 2016, 7:56 PM · Restricted Project, Owners
epriestley closed T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds as Resolved by committing Restricted Diffusion Commit.
Feb 26 2016, 7:38 PM · Harbormaster (v3), Restricted Project
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

My broad philosophical stance here is that engineers should be disciplined and professional about not killing enemy builds, but I think the complexity cost to put some more guard rails on the thing isn't overbearing and these additional policies are generally pretty reasonable and make sense, and have some redeeming value in preventing mistakes with tools like "Restart All Builds".

Feb 26 2016, 7:38 PM · Harbormaster (v3), Restricted Project
epriestley awarded T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds a Baby Tequila token.
Feb 26 2016, 7:32 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds: Unknown Object (Differential Revision).
Feb 26 2016, 7:32 PM · Harbormaster (v3), Restricted Project
• teror4uks added a comment to T10460: Commit Still Parsing.

UPD: find error at "arc diff"

Feb 26 2016, 7:25 PM · Diffusion, Bug Report (Needs Information)
avivey changed the visibility for T2525: Delete `ArcanistLicenseLinter` and `ArcanistApacheLicenseLinter`.
Feb 26 2016, 7:14 PM · OS Students 2013, Arcanist
avivey changed the visibility for T2274: license linting doesn't allow for copyright years other than the current.
Feb 26 2016, 7:09 PM · Arcanist
avivey changed the visibility for T2035: Is there a legal reason to have license block in every single PHP file?.
Feb 26 2016, 7:03 PM
avivey changed the visibility for D3886: Delete license headers from files.
Feb 26 2016, 7:03 PM
• teror4uks added a comment to T10460: Commit Still Parsing.

thank's, at ulr, I do it

./repository reparse --importing --all --trace  R10
Feb 26 2016, 7:01 PM · Diffusion, Bug Report (Needs Information)
epriestley closed T10458: Remove obsolete Drydock build steps from Harbormaster, a subtask of T10457: Improve Harbomaster/Drydock UI/UX before release, as Resolved.
Feb 26 2016, 6:35 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10458: Remove obsolete Drydock build steps from Harbormaster as Resolved by committing Restricted Diffusion Commit.
Feb 26 2016, 6:35 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a revision to T10458: Remove obsolete Drydock build steps from Harbormaster: Unknown Object (Differential Revision).
Feb 26 2016, 6:33 PM · Harbormaster (v3), Drydock (v3), Phacility
michaeljs1990 added a comment to T10452: Provide more flexible management over disabling/changing ldap user accounts.

They do lose access to managing both accounts which has caused a few issues around email addresses. It looks like we could have reduced massive pain on ourselves by letting users unlink ldap accounts and instructing them to link the new account.

Feb 26 2016, 6:32 PM · Restricted Project, LDAP, Auth, Feature Request
epriestley closed T10447: When the push phase of "Land Revision" fails, show the error in the UI as Resolved.

Presuming resolved by D15350.

Feb 26 2016, 6:30 PM · Drydock (v3)
• partiallysaneash added a comment to Q323: Audit history of file.

Hi Chad. Thanks for taking the time to post that, it's helpful. I don't mind too much that it's per commit rather than file but it would be nice to have a view that said "this file you have open, was audited in as part of commit A,B,C" .

Feb 26 2016, 5:38 PM
chad added a comment to T10459: AphrontSchemaQueryException on create\update task.

Maybe also related, T10003. Do you have any special configuration for Maniphest?

Feb 26 2016, 5:27 PM · Bug Report (Needs Information)
chad added a comment to T10459: AphrontSchemaQueryException on create\update task.

You can check database status and issues in Config -> Database

Feb 26 2016, 5:20 PM · Bug Report (Needs Information)
• ant1ucem added a comment to T10459: AphrontSchemaQueryException on create\update task.

Git says "Already up-to-date"
I did restart both nginx and php5-fpm many many times

Feb 26 2016, 5:13 PM · Bug Report (Needs Information)
• ant1ucem edited P1949 phabricator_db_update_inclomplete T10459.
Feb 26 2016, 5:09 PM
• ant1ucem created P1949 phabricator_db_update_inclomplete T10459.
Feb 26 2016, 5:08 PM
chad changed the visibility for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.
Feb 26 2016, 4:55 PM · Phortune, Phacility
chad edited projects for T10460: Commit Still Parsing, added: Bug Report (Needs Information); removed Bug Report.
Feb 26 2016, 4:47 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10460: Commit Still Parsing.

See https://secure.phabricator.com/book/phabricator/article/repository_imports/

Feb 26 2016, 4:46 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10459: AphrontSchemaQueryException on create\update task.

When we say "restart webserver", we mean Phabricator itself, which means php-fpm for you. See https://secure.phabricator.com/book/phabricator/article/restarting/ for more details.

Feb 26 2016, 4:35 PM · Bug Report (Needs Information)
• AnysM added a watcher for Projects: • AnysM.
Feb 26 2016, 4:28 PM
chad edited projects for T10459: AphrontSchemaQueryException on create\update task, added: Bug Report (Needs Information); removed Bug Report.
Feb 26 2016, 4:13 PM · Bug Report (Needs Information)
chad added a comment to T10459: AphrontSchemaQueryException on create\update task.

Either your database didn't get updated, the code didn't fully download, or you didn't restart the webserver.

Feb 26 2016, 4:12 PM · Bug Report (Needs Information)
• teror4uks created T10460: Commit Still Parsing.
Feb 26 2016, 4:08 PM · Diffusion, Bug Report (Needs Information)
• ant1ucem created T10459: AphrontSchemaQueryException on create\update task.
Feb 26 2016, 3:27 PM · Bug Report (Needs Information)
epriestley added a comment to T10260: Harbormaster Herald Rules.

Maybe a more natural approach to this would be to add a "Notify" build step? We'd also need an "on failure" set of actions or something which implicitly accomplished the same goal, but that seems reasonable to me.

Feb 26 2016, 3:23 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley moved T9516: Copying text from a Harbormaster build log copies the line numbers as well from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:07 PM · Harbormaster, Restricted Project
epriestley moved T10011: Allow to search for the build status in habormaster querys from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:06 PM · Harbormaster (v3), Feature Request