Feed All Stories
Jun 24 2019
Jun 24 2019
epriestley committed rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons (authored by epriestley).
Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
Stop writing PID files in daemons
epriestley committed rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files (authored by epriestley).
Make "phd start" and "phd reload" use the process list, not PID files
epriestley committed rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of… (authored by epriestley).
Make "bin/phd status" report local daemons from the process list, not a mess of…
epriestley committed rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()" (authored by epriestley).
Remove "PhutilDaemonOverseer->findRunningDaemons()"
epriestley committed rPb99c240aa374: Deprecate "bin/phd ... --gently" and update documentation (authored by epriestley).
Deprecate "bin/phd ... --gently" and update documentation
epriestley committed rPd98bf8ef8ee6: Drive "phd stop" entirely from the process list, not PID files on disk (authored by epriestley).
Drive "phd stop" entirely from the process list, not PID files on disk
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
- Rebase to clear tests.
Harbormaster failed remote builds in B23039: Diff 49165 for D20601: Drive "phd stop" entirely from the process list, not PID files on disk!
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
- Wordsmithing: "any instance" -> "all instances"
epriestley committed rPHUb6505e98bfbc: Formalize a "Query" class for looking at the process list (authored by epriestley).
Formalize a "Query" class for looking at the process list
epriestley committed rPHUb9f35642c4e0: Parse remarkup tables with something like a real parser instead of regular… (authored by epriestley).
Parse remarkup tables with something like a real parser instead of regular…
epriestley committed rP09ecf49ee454: (stable) Require commit identities when editing commits to resolve an issue… (authored by epriestley).
(stable) Require commit identities when editing commits to resolve an issue…
epriestley committed rP75c359835903: Require commit identities when editing commits to resolve an issue with audit… (authored by epriestley).
Require commit identities when editing commits to resolve an issue with audit…
D20612: Require commit identities when editing commits to resolve an issue with audit actions not applying properly is now accepted and ready to land.
Jun 22 2019
Jun 22 2019
epriestley added a comment to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
See one followup in T13326. The "import from disk" part seems to have worked properly in production.
epriestley committed rPHUb675a06bf741: (stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort… (authored by epriestley).
(stable) Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort…
epriestley committed rPHUf5879cc6a9dc: Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function (authored by epriestley).
Allow "PhutilClassMapQuery" to sort with a PhutilSortVector sort function
epriestley edited the content of Changelog.
Herald added 1 auditor(s) for rARCdb4cd55d4673: Merge branch "master" into "experimental".: Cowboy Commits.
Merge branch "master" into "experimental".
epriestley created an object: 2019 Week 25 (Late June).
(stable) Promote 2019 Week 25
(stable) Promote 2019 Week 25
(stable) Promote 2019 Week 25
Jun 21 2019
Jun 21 2019
20after4 awarded T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion a Mountain of Wealth token.
20after4 added a comment to D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion.
I've been wishing for this literally forever. If I could award more mountains of wealth tokens, I most certainly would!
20after4 awarded D20539: Add a "{src ...}" Remarkup rule to provide a more flexible way to reference source files in Diffusion a Mountain of Wealth token.
epriestley committed rPca56e8590a3d: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way… (authored by epriestley).
Don't handle JIRA/Asana URIs with anchors or query parameters in a special way…
epriestley added a comment to D20592: Don't handle JIRA/Asana URIs with anchors or query parameters in a special way (with Doorkeeper).
I'm just going to land this as-is pending feedback on actual use cases, anticipating a followup to do parameter/anchor support if some reasonable #comment-123 URI exists in either external system. Then it will at least be easy for us to link-and-preserve-parameters or decline-to-link and we can figure out whatever else arises on a case-by-case basis.
olasd edited the content of Organizations Using Phabricator.
Jun 20 2019
Jun 20 2019
amckinley committed rP6b9f4a918b85: Modularize PhabricatorEditEngineConfigurationTransaction (authored by amckinley).
Modularize PhabricatorEditEngineConfigurationTransaction
epriestley committed rPc0dc411d2319: Update "phabricator/" for "topological" API changes (authored by epriestley).
Update "phabricator/" for "topological" API changes
epriestley added a comment to rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.
(Build failure is just D20599 landing out-of-order, oops.)
epriestley committed rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects (authored by epriestley).
Fix an issue in Owners where a transaction change could show too many effects
epriestley committed rARCd92fa96366c0: Fix two "msort()" vs "msortv()" issues in "arc land" (authored by epriestley).
Fix two "msort()" vs "msortv()" issues in "arc land"
epriestley committed rARC1ef94098179f: Update "arcanist/" for "topological" API changes (authored by epriestley).
Update "arcanist/" for "topological" API changes
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.
I just ran into this for the first time:
epriestley committed rPHU8eaf1b38d417: Replace made-up use of "topographical" ordering with professional, high-quality… (authored by epriestley).
Replace made-up use of "topographical" ordering with professional, high-quality…
epriestley added inline comments to D20607: Stop writing PID files in daemons.
D20596: Fix an issue in Owners where a transaction change could show too many effects is now accepted and ready to land.
D20608: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons is now accepted and ready to land.
D20606: Make "phd start" and "phd reload" use the process list, not PID files is now accepted and ready to land.
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
epriestley added inline comments to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
D20604: Make "bin/phd status" report local daemons from the process list, not a mess of local/remote information is now accepted and ready to land.
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.
I've also never seen anyone use kill -TERM `cat /path/to/pidfile` in real life over some flavor of pkill, which is basically the same thing as "pattern match the process titles".
D20603: Remove "PhutilDaemonOverseer->findRunningDaemons()" is now accepted and ready to land.
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.
provided I'm not missing some secret reason to retain PID files.
D20602: Deprecate "bin/phd ... --gently" and update documentation is now accepted and ready to land.
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
D20601: Drive "phd stop" entirely from the process list, not PID files on disk is now accepted and ready to land.
D20600: Formalize a "Query" class for looking at the process list is now accepted and ready to land.
D20605: Fix two "msort()" vs "msortv()" issues in "arc land" is now accepted and ready to land.
epriestley requested review of D20607: Stop writing PID files in daemons.
amckinley added a comment to D20595: Modularize PhabricatorEditEngineConfigurationTransaction.
Pick up changes from D20594.
epriestley requested review of D20606: Make "phd start" and "phd reload" use the process list, not PID files.
epriestley requested review of D20605: Fix two "msort()" vs "msortv()" issues in "arc land".
epriestley added a comment to T11037: `bin/phd status` is misleading about local / remote daemons.
I've marked D20604 as resolving this; it does so by making bin/phd status report local process status only. I strongly suspect that this is probably a better / less confusing behavior.
epriestley added a comment to D20601: Drive "phd stop" entirely from the process list, not PID files on disk.
- "DEAMONS" -> "DAEMONS"
epriestley requested review of D20603: Remove "PhutilDaemonOverseer->findRunningDaemons()".