Stop writing PID files in daemons
7adfe4e4f4a3
Actions

Description

Stop writing PID files in daemons

Summary: Ref T13321. There are no more PID file readers, so we can stop writing them.

Test Plan: Ran bin/phd start, saw daemons doing stuff.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13321

Differential Revision: https://secure.phabricator.com/D20607

Details

Provenance

epriestley	Authored on Jun 20 2019, 10:01 PM
epriestley	Pushed on Jun 24 2019, 6:28 PM

Reviewer

amckinley

Differential Revision

D20607: Stop writing PID files in daemons

Parents

rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()"

Branches

Unknown

Tags

Unknown

Tasks

T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date

Build Status

Buildable 23046
Build 31636: Run Core Tests

Event Timeline

epriestley committed rPHU7adfe4e4f4a3: Stop writing PID files in daemons (authored by epriestley).Jun 24 2019, 6:28 PM

epriestley added a task: T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

epriestley added an edge: D20607: Stop writing PID files in daemons.

Harbormaster completed building B23046: rPHU7adfe4e4f4a3: Stop writing PID files in daemons.Jun 24 2019, 6:29 PM

Changes (2)

Path

Size

src/

daemon/

PhutilDaemonHandle.php

PhutilDaemonOverseer.php

rPHU7adfe4e4f4a3

View Options

src/daemon/PhutilDaemonHandle.php