Page MenuHomePhabricator

Stop writing PID files in daemons
ClosedPublic

Authored by epriestley on Thu, Jun 20, 10:05 PM.

Details

Summary

Ref T13321. There are no more PID file readers, so we can stop writing them.

Test Plan

Ran bin/phd start, saw daemons doing stuff.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jun 20, 10:05 PM
epriestley requested review of this revision.Thu, Jun 20, 10:06 PM
amckinley accepted this revision.Thu, Jun 20, 10:51 PM

src/daemon/PhutilDaemonOverseer.php
124–125

One thing we're losing here is that daemons will no longer crash instantly on startup if they don't have permissions or the disk is full.

This revision is now accepted and ready to land.Thu, Jun 20, 10:51 PM
epriestley added inline comments.Thu, Jun 20, 11:01 PM
src/daemon/PhutilDaemonOverseer.php
124–125

Haha, yes. All told, I think I deleted like four blocks of // TODO: It would be nice if this wasn't a horrible, fragile mess. code.

This revision was automatically updated to reflect the committed changes.